cli-plugins/hooks: slight tweaks in templates

thaJeztah · thaJeztah · commit cd053606a6ee · 2026-03-19T12:24:35.000+01:00
- use `%q` instead of manually quoting the string
- use `%d` instead of manually converting the number to a string

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli-plugins/hooks/hook_utils.go b/cli-plugins/hooks/hook_utils.go
@@ -2,13 +2,12 @@ package hooks
 
 import (
 	"fmt"
-	"strconv"
 )
 
 const (
 	hookTemplateCommandName = `{{.Name}}`
-	hookTemplateFlagValue   = `{{flag . "%s"}}`
-	hookTemplateArg         = `{{arg . %s}}`
+	hookTemplateFlagValue   = `{{flag . %q}}`
+	hookTemplateArg         = `{{arg . %d}}`
 )
 
 // TemplateReplaceSubcommandName returns a hook template string
@@ -54,5 +53,5 @@ func TemplateReplaceFlagValue(flag string) string {
 // will result in the message:
 // "Run this image with `docker run alpine`"
 func TemplateReplaceArg(i int) string {
-	return fmt.Sprintf(hookTemplateArg, strconv.Itoa(i))
+	return fmt.Sprintf(hookTemplateArg, i)
 }

Original file line number	Diff line number	Diff line change
`@@ -2,13 +2,12 @@ package hooks`
`2`	`2`
`3`	`3`	`import (`
`4`	`4`	`"fmt"`
`5`		`- "strconv"`
`6`	`5`	`)`
`7`	`6`
`8`	`7`	`const (`
`9`	`8`	hookTemplateCommandName = `{{.Name}}`
`10`		- hookTemplateFlagValue = `{{flag . "%s"}}`
`11`		- hookTemplateArg = `{{arg . %s}}`
	`9`	+ hookTemplateFlagValue = `{{flag . %q}}`
	`10`	+ hookTemplateArg = `{{arg . %d}}`
`12`	`11`	`)`
`13`	`12`
`14`	`13`	`// TemplateReplaceSubcommandName returns a hook template string`
`@@ -54,5 +53,5 @@ func TemplateReplaceFlagValue(flag string) string {`
`54`	`53`	`// will result in the message:`
`55`	`54`	// "Run this image with `docker run alpine`"
`56`	`55`	`func TemplateReplaceArg(i int) string {`
`57`		`- return fmt.Sprintf(hookTemplateArg, strconv.Itoa(i))`
	`56`	`+ return fmt.Sprintf(hookTemplateArg, i)`
`58`	`57`	`}`