modernize: stringscut

thaJeztah · thaJeztah · commit 2875e480249b · 2026-02-11T13:16:13.000+01:00
go install golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest
    modernize -stringscut -fix ./...

Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli/command/telemetry_utils.go b/cli/command/telemetry_utils.go
@@ -155,11 +155,11 @@ func (e statusError) Error() string {
 // Note: The root command's name is excluded. If cmd is the root cmd, return ""
 func getCommandName(cmd *cobra.Command) string {
 	fullCmdName := getFullCommandName(cmd)
-	i := strings.Index(fullCmdName, " ")
-	if i == -1 {
+	_, after, ok := strings.Cut(fullCmdName, " ")
+	if !ok {
 		return ""
 	}
-	return fullCmdName[i+1:]
+	return after
 }
 
 // getFullCommandName gets the full cobra command name in the format

Original file line number	Diff line number	Diff line change
`@@ -155,11 +155,11 @@ func (e statusError) Error() string {`
`155`	`155`	`// Note: The root command's name is excluded. If cmd is the root cmd, return ""`
`156`	`156`	`func getCommandName(cmd *cobra.Command) string {`
`157`	`157`	`fullCmdName := getFullCommandName(cmd)`
`158`		`- i := strings.Index(fullCmdName, " ")`
`159`		`- if i == -1 {`
	`158`	`+ _, after, ok := strings.Cut(fullCmdName, " ")`
	`159`	`+ if !ok {`
`160`	`160`	`return ""`
`161`	`161`	`}`
`162`		`- return fullCmdName[i+1:]`
	`162`	`+ return after`
`163`	`163`	`}`
`164`	`164`
`165`	`165`	`// getFullCommandName gets the full cobra command name in the format`