cli-plugins/manager: simplify ctx-cancel check

thaJeztah · thaJeztah · commit 0501cf829347 · 2026-03-18T12:18:46.000+01:00
Signed-off-by: Sebastiaan van Stijn &lt;github@gone.nl&gt;
diff --git a/cli-plugins/manager/hooks.go b/cli-plugins/manager/hooks.go
@@ -55,11 +55,8 @@ func runHooks(ctx context.Context, cfg *configfile.ConfigFile, rootCmd, subComma
 }
 
 func invokeAndCollectHooks(ctx context.Context, cfg *configfile.ConfigFile, rootCmd, subCmd *cobra.Command, subCmdStr string, flags map[string]string, cmdErrorMessage string) []string {
-	// check if the context was cancelled before invoking hooks
-	select {
-	case <-ctx.Done():
+	if ctx.Err() != nil {
 		return nil
-	default:
 	}
 
 	pluginsCfg := cfg.Plugins

Original file line number	Diff line number	Diff line change
`@@ -55,11 +55,8 @@ func runHooks(ctx context.Context, cfg *configfile.ConfigFile, rootCmd, subComma`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`func invokeAndCollectHooks(ctx context.Context, cfg configfile.ConfigFile, rootCmd, subCmd cobra.Command, subCmdStr string, flags map[string]string, cmdErrorMessage string) []string {`
`58`		`- // check if the context was cancelled before invoking hooks`
`59`		`- select {`
`60`		`- case <-ctx.Done():`
	`58`	`+ if ctx.Err() != nil {`
`61`	`59`	`return nil`
`62`		`- default:`
`63`	`60`	`}`
`64`	`61`
`65`	`62`	`pluginsCfg := cfg.Plugins`