cli-plugins/hooks: rename HookType to ResponseType

Rename the type to match the struct it's used for. Also;

- Fix the type of the NextSteps const
- Don't use iota for values; the ResponseType is used as
  part of the "wire" format, which means that plugins using
  the value can use a different version of the module code;
  using iota increases the risk of (accidentally) changing
  values, which would break the wire format.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Author: thaJeztah

cli-plugins/hooks/hook_types.go

@@ -1,5 +1,12 @@
 package hooks
 
+// ResponseType is the type of response from the plugin.
+type ResponseType int
+
+const (
+	NextSteps ResponseType = 0
+)
+
 // Request is the type representing the information
 // that plugins declaring support for hooks get passed when
 // being invoked following a CLI command execution.
@@ -18,10 +25,17 @@ type Request struct {
 // representation of this type when their hook subcommand
 // is invoked.
 type Response struct {
-	Type     HookType
+	Type     ResponseType
 	Template string
 }
 
+// HookType is the type of response from the plugin.
+//
+// Deprecated: use [ResponseType] instead.
+//
+//go:fix inline
+type HookType = ResponseType
+
 // HookMessage represents a plugin hook response.
 //
 // Deprecated: use [Response] instead.

cli-plugins/hooks/template.go

@@ -11,12 +11,6 @@ import (
 	"github.com/spf13/cobra"
 )
 
-type HookType int
-
-const (
-	NextSteps = iota
-)
-
 // TemplateReplaceSubcommandName returns a hook template string
 // that will be replaced by the CLI subcommand being executed
 //