chore: fix errcheck issues

Signed-off-by: Yves Brissaud <yves.brissaud@docker.com>

Author: eunomie

commands/cmd.go

@@ -254,7 +254,7 @@ func readWorkspace(args []string, cli command.Cli) (string, error) {
 	} else if v, ok := os.LookupEnv("ATOMIST_WORKSPACE"); v != "" && ok {
 		workspace = v
 	} else {
-		fmt.Fprintf(cli.Out(), "Workspace: ")
+		_, _ = fmt.Fprintf(cli.Out(), "Workspace: ")
 
 		workspace = readInput(cli.In(), cli.Out())
 		if workspace == "" {
@@ -282,12 +282,12 @@ func readApiKey(apiKeyStdin bool, cli command.Cli) (string, error) {
 		if err != nil {
 			return "", err
 		}
-		fmt.Fprintf(cli.Out(), "API key: ")
-		term.DisableEcho(cli.In().FD(), oldState)
+		_, _ = fmt.Fprintf(cli.Out(), "API key: ")
+		_ = term.DisableEcho(cli.In().FD(), oldState)
 
 		apiKey = readInput(cli.In(), cli.Out())
-		fmt.Fprint(cli.Out(), "\n")
-		term.RestoreTerminal(cli.In().FD(), oldState)
+		_, _ = fmt.Fprint(cli.Out(), "\n")
+		_ = term.RestoreTerminal(cli.In().FD(), oldState)
 		if apiKey == "" {
 			return "", errors.Errorf("Error: API key required")
 		}
@@ -299,7 +299,7 @@ func readInput(in io.Reader, out io.Writer) string {
 	reader := bufio.NewReader(in)
 	line, _, err := reader.ReadLine()
 	if err != nil {
-		fmt.Fprintln(out, err.Error())
+		_, _ = fmt.Fprintln(out, err.Error())
 		os.Exit(1)
 	}
 	return string(line)

internal/spinner.go

@@ -63,7 +63,7 @@ func StartInfoSpinner(text string, isTerminal bool) *Spinner {
 func StartSpinner(level string, text string, isTerminal bool) *Spinner {
 	if isTerminal {
 		s := spinner.New(spinner.CharSets[14], 100*time.Millisecond)
-		s.Color("yellow")
+		_ = s.Color("yellow")
 
 		spinner := &Spinner{
 			level:      level,

query/base.go

@@ -136,6 +136,9 @@ func ForBaseImageInIndex(digest digest.Digest, workspace string, apiKey string)
 func ForBaseImageWithoutCve(cve string, name string, sb *types.Sbom, workspace string, apiKey string) (*[]types.Image, error) {
 	cf := (*sb).Source.Image.Config
 	resp, err := query(fmt.Sprintf(baseImageCveQuery, cve, name, cf.OS, cf.Architecture, cf.Variant), "base_image_cve_query", workspace, apiKey)
+	if err != nil {
+		return nil, errors.Wrapf(err, "failed to query for base image without CVE")
+	}
 
 	var result ImageQueryResult
 	err = edn.NewDecoder(resp.Body).Decode(&result)
@@ -174,6 +177,9 @@ func ForBaseImageWithoutCve(cve string, name string, sb *types.Sbom, workspace s
 // ForBaseImageInDb returns images with matching digest in :docker.image/blob-digest or :docker.image/diff-chain-id
 func ForBaseImageInDb(digest digest.Digest, workspace string, apiKey string) (*[]types.Image, error) {
 	resp, err := query(fmt.Sprintf(baseImageQuery, digest), "base_image_query", workspace, apiKey)
+	if err != nil {
+		return nil, errors.Wrapf(err, "failed to query for base image in DB")
+	}
 
 	var result ImageQueryResult
 	err = edn.NewDecoder(resp.Body).Decode(&result)
@@ -204,6 +210,9 @@ func ForBaseImageInDb(digest digest.Digest, workspace string, apiKey string) (*[
 
 func ForRepositoryInDb(repo string, workspace string, apiKey string) (*types.Repository, error) {
 	resp, err := query(fmt.Sprintf(repositoryQuery, repo), "repository_query", workspace, apiKey)
+	if err != nil {
+		return nil, errors.Wrapf(err, "failed to query for repository in DB")
+	}
 
 	var result RepositoryQueryResult
 	err = edn.NewDecoder(resp.Body).Decode(&result)

sbom/detect/detect.go

@@ -110,7 +110,7 @@ var (
 )
 
 func readStrings(reader io.ReadCloser, expr *regexp.Regexp) [][]string {
-	defer reader.Close()
+	defer reader.Close() //nolint:errcheck
 	in := bufio.NewReader(reader)
 	str := make([]rune, 0, max)
 	filePos := int64(0)

sbom/lsp.go

@@ -72,7 +72,7 @@ func SendFileHashes(image string, tx chan<- string) error {
 			content, err := res.FileContentsByLocation(source.NewLocation(string(ref.RealPath)))
 			if err == nil {
 				b, _ := io.ReadAll(content)
-				content.Close()
+				content.Close() //nolint:errcheck
 				h := sha256.New()
 				h.Write(b)
 				hash := fmt.Sprintf("sha256:%x", h.Sum(nil))

sbom/trivy.go

@@ -56,7 +56,7 @@ func trivySbom(cache *registry.ImageCache, lm *types.LayerMapping, resultChan ch
 		resultChan <- result
 		return
 	}
-	defer cacheClient.Close()
+	defer cacheClient.Close() //nolint:errcheck
 
 	img, err := image.NewArchiveImage(cache.ImagePath)
 	if err != nil {