Replace remaining Printf and Println by their Fprint* counterparts

Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>

Author: Jean-Christophe Sirot

internal/commands/install.go

@@ -142,6 +142,6 @@ func runInstall(dockerCli command.Cli, appname string, opts installOptions) erro
 		return err2
 	}
 
-	fmt.Printf("Application %q installed on context %q\n", installationName, opts.targetContext)
+	fmt.Fprintf(os.Stdout, "Application %q installed on context %q\n", installationName, opts.targetContext)
 	return nil
 }

internal/commands/pull.go

@@ -2,6 +2,7 @@ package commands
 
 import (
 	"fmt"
+	"os"
 
 	"github.com/docker/app/internal/store"
 	"github.com/docker/cli/cli"
@@ -46,7 +47,7 @@ func runPull(dockerCli command.Cli, name string, opts registryOptions) error {
 		return errors.Wrap(err, name)
 	}
 
-	fmt.Printf("Successfully pulled %q (%s) from %s\n", bndl.Name, bndl.Version, ref.String())
+	fmt.Fprintf(os.Stdout, "Successfully pulled %q (%s) from %s\n", bndl.Name, bndl.Version, ref.String())
 
 	return nil
 }

internal/commands/push.go

@@ -118,7 +118,7 @@ func runPush(dockerCli command.Cli, name string, opts pushOptions) error {
 	if err != nil {
 		return errors.Wrapf(err, "pushing to %q", retag.cnabRef)
 	}
-	fmt.Printf("Successfully pushed bundle to %s. Digest is %s.\n", retag.cnabRef.String(), descriptor.Digest)
+	fmt.Fprintf(os.Stdout, "Successfully pushed bundle to %s. Digest is %s.\n", retag.cnabRef.String(), descriptor.Digest)
 	return nil
 }
 

internal/commands/uninstall.go

@@ -86,6 +86,6 @@ func runUninstall(dockerCli command.Cli, installationName string, opts uninstall
 	if err := installationStore.Delete(installationName); err != nil {
 		return fmt.Errorf("Failed to delete installation %q from the installation store: %s", installationName, err)
 	}
-	fmt.Printf("Application %q uninstalled on context %q\n", installationName, opts.targetContext)
+	fmt.Fprintf(os.Stdout, "Application %q uninstalled on context %q\n", installationName, opts.targetContext)
 	return nil
 }

internal/commands/upgrade.go

@@ -97,6 +97,6 @@ func runUpgrade(dockerCli command.Cli, installationName string, opts upgradeOpti
 	if err2 != nil {
 		return err2
 	}
-	fmt.Printf("Application %q upgraded on context %q\n", installationName, opts.targetContext)
+	fmt.Fprintf(os.Stdout, "Application %q upgraded on context %q\n", installationName, opts.targetContext)
 	return nil
 }

internal/packager/init.go

@@ -181,7 +181,7 @@ func initFromComposeFile(name string, composeFile string) error {
 		return errors.Wrap(err, "failed to write parameters.yml")
 	}
 	if needsFilling {
-		fmt.Println("You will need to edit parameters.yml to fill in default values.")
+		fmt.Fprintln(os.Stderr, "You will need to edit parameters.yml to fill in default values.")
 	}
 	return nil
 }