ci: add all default-enabled golangci-lint linters

This adds the enabled by default ones not in the current list.

Note that `govet` is a synonym for `vet`, use `govet` since it is the one used
in the list.

This brings up several issues:
    internal/commands/cnab_test.go:19:22: Error return value of `dockerCli.Initialize` is not checked (errcheck)
    	dockerCli.Initialize(cliflags.NewClientOptions())
    	                    ^
    internal/commands/completion.go:183:27: Error return value of `rootCmd.GenBashCompletion` is not checked (errcheck)
    	rootCmd.GenBashCompletion(buf)
    	                         ^
    internal/commands/push.go:186:13: Error return value of `r.out.Write` is not checked (errcheck)
    	r.out.Write(out.Bytes())
    	           ^
    internal/commands/root.go:52:17: Error return value of `dockerCli.Apply` is not checked (errcheck)
    	dockerCli.Apply(command.WithCombinedStreams(ioutil.Discard))
    	               ^
    internal/commands/root.go:54:18: Error return value of `dockerCli.Apply` is not checked (errcheck)
    		dockerCli.Apply(command.WithOutputStream(stdout), command.WithErrorStream(stderr))
    		               ^
    cmd/cnab-run/render.go:42:13: SA1006: printf-style function with dynamic first argument and no further arguments should use print-style function instead (staticcheck)
    	fmt.Printf(res)
    	           ^
    e2e/commands_test.go:74:3: SA4006: this value of `result` is never used (staticcheck)
    		result = icmd.RunCmd(cmd).Assert(t, icmd.Success)
    		^

Fix them all.

Signed-off-by: Ian Campbell <ijc@docker.com>

Author: Ian Campbell

.golangci.yml

@@ -3,20 +3,25 @@ linters:
   disable-all: true
   enable:
     - deadcode
+    - errcheck
     - gocyclo
     - gofmt
     - goimports
     - golint
     - gosimple
+    - govet
     - ineffassign
     - interfacer
     - lll
     - misspell
     - nakedret
+    - staticcheck
+    - structcheck
+    - typecheck
     - unconvert
     - unparam
     - unused
-    - vet
+    - varcheck
 linters-settings:
   gocyclo:
     min-complexity: 16

cmd/cnab-run/render.go

@@ -39,7 +39,7 @@ func renderAction(instanceName string) error {
 	if err != nil {
 		return err
 	}
-	fmt.Printf(res)
+	fmt.Print(res)
 
 	return nil
 }

e2e/commands_test.go

@@ -71,7 +71,7 @@ func testRenderApp(appPath string, env ...string) func(*testing.T) {
 		assert.Assert(t, is.Equal(readFile(t, filepath.Join(appPath, "expected.txt")), result.Stdout()), "rendering mismatch")
 		// Checks rendering to a file
 		cmd.Command = append(cmd.Command, "--output="+dir.Join("actual.yaml"))
-		result = icmd.RunCmd(cmd).Assert(t, icmd.Success)
+		icmd.RunCmd(cmd).Assert(t, icmd.Success)
 
 		assert.Assert(t, is.Equal(readFile(t, filepath.Join(appPath, "expected.txt")), readFile(t, dir.Join("actual.yaml"))), "rendering mismatch")
 	}

internal/commands/cnab_test.go

@@ -16,7 +16,8 @@ import (
 func TestRequiresBindMount(t *testing.T) {
 	dockerCli, err := command.NewDockerCli()
 	assert.NilError(t, err)
-	dockerCli.Initialize(cliflags.NewClientOptions())
+	err = dockerCli.Initialize(cliflags.NewClientOptions())
+	assert.NilError(t, err)
 
 	testCases := []struct {
 		name               string

internal/commands/completion.go

@@ -180,7 +180,9 @@ _complete dockerapp 2>/dev/null
 func runCompletionZsh(out io.Writer, rootCmd *cobra.Command) error {
 	fmt.Fprint(out, zshHead)
 	buf := new(bytes.Buffer)
-	rootCmd.GenBashCompletion(buf)
+	if err := rootCmd.GenBashCompletion(buf); err != nil {
+		return err
+	}
 	fmt.Fprint(out, buf.String())
 	fmt.Fprint(out, zshTail)
 	return nil

internal/commands/push.go

@@ -183,7 +183,8 @@ func (r *interactiveDisplay) onEvent(ev remotes.FixupEvent) {
 	for _, s := range r.images {
 		r.previousLineCount += s.print(out)
 	}
-	r.out.Write(out.Bytes())
+	// nolint because there is nothing much we can do with an error to write to our output.
+	r.out.Write(out.Bytes()) //nolint:errcheck
 }
 
 func (r *interactiveDisplay) imageIndex(name string) int {

internal/commands/root.go

@@ -49,9 +49,10 @@ func firstOrEmpty(list []string) string {
 func muteDockerCli(dockerCli command.Cli) func() {
 	stdout := dockerCli.Out()
 	stderr := dockerCli.Err()
-	dockerCli.Apply(command.WithCombinedStreams(ioutil.Discard))
+	// nolint because WithCombinedStreams cannot error
+	dockerCli.Apply(command.WithCombinedStreams(ioutil.Discard)) //nolint:errcheck
 	return func() {
-		dockerCli.Apply(command.WithOutputStream(stdout), command.WithErrorStream(stderr))
+		dockerCli.Apply(command.WithOutputStream(stdout), command.WithErrorStream(stderr)) //nolint:errcheck
 	}
 }