Merge pull request #649 from rumpl/image-ls-ignore-unknown

Ignore unknown files on image ls

Author: eunomie

internal/store/bundle.go

@@ -75,7 +75,7 @@ func (b *bundleStore) List() ([]reference.Named, error) {
 		}
 
 		if !strings.HasSuffix(info.Name(), ".json") {
-			return fmt.Errorf("unknown file %q in bundle store", path)
+			return nil
 		}
 
 		ref, err := b.pathToReference(path)

internal/store/bundle_test.go

@@ -2,6 +2,7 @@ package store
 
 import (
 	"os"
+	"path"
 	"path/filepath"
 	"testing"
 
@@ -232,4 +233,14 @@ func TestList(t *testing.T) {
 		assert.Equal(t, bundles[0].String(), "docker.io/my-repo/a-bundle:my-tag")
 		assert.Equal(t, bundles[1].String(), "docker.io/my-repo/b-bundle@sha256:"+testSha)
 	})
+
+	t.Run("Ignores unknown files in the bundle store", func(t *testing.T) {
+		p := path.Join(dockerConfigDir.Path(), AppConfigDirectory, BundleStoreDirectory)
+		//nolint:errcheck
+		os.OpenFile(path.Join(p, "filename"), os.O_CREATE, 06444)
+
+		bundles, err := bundleStore.List()
+		assert.NilError(t, err)
+		assert.Equal(t, len(bundles), 2)
+	})
 }