Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit 0c5301a

Browse files
Ulysses Souzaulyssessouza
authored andcommitted
Remove obsolete commands after introducing CNAB
Remove commands and tests related to: - image-add - image-load - pack - unpack Signed-off-by: Ulysses Souza <ulysses.souza@docker.com>
1 parent 941df3f commit 0c5301a

6 files changed

Lines changed: 0 additions & 189 deletions

File tree

cmd/docker-app/image-add.go

Lines changed: 0 additions & 74 deletions
This file was deleted.

cmd/docker-app/image-load.go

Lines changed: 0 additions & 23 deletions
This file was deleted.

cmd/docker-app/pack.go

Lines changed: 0 additions & 44 deletions
This file was deleted.

cmd/docker-app/root.go

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,11 +62,7 @@ func addCommands(cmd *cobra.Command, dockerCli command.Cli) {
6262
)
6363
if internal.Experimental == "on" {
6464
cmd.AddCommand(
65-
imageAddCmd(),
66-
imageLoadCmd(),
67-
packCmd(dockerCli),
6865
pullCmd(),
69-
unpackCmd(),
7066
)
7167
}
7268
}

cmd/docker-app/unpack.go

Lines changed: 0 additions & 22 deletions
This file was deleted.

e2e/commands_test.go

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -188,28 +188,6 @@ func TestDetectApp(t *testing.T) {
188188
})
189189
}
190190

191-
func TestPack(t *testing.T) {
192-
skip.If(t, !hasExperimental, "experimental mode needed for this test")
193-
tempDir, err := ioutil.TempDir("", "dockerapp")
194-
assert.NilError(t, err)
195-
defer os.RemoveAll(tempDir)
196-
icmd.RunCommand(dockerApp, "pack", "testdata/attachments", "-o", filepath.Join(tempDir, "test.dockerapp")).Assert(t, icmd.Success)
197-
// check that our commands run on the packed version
198-
icmd.RunCommand(dockerApp, "inspect", filepath.Join(tempDir, "test")).Assert(t, icmd.Expected{
199-
Out: "myapp",
200-
})
201-
icmd.RunCommand(dockerApp, "render", filepath.Join(tempDir, "test")).Assert(t, icmd.Expected{
202-
Out: "nginx",
203-
})
204-
assert.NilError(t, os.Mkdir(filepath.Join(tempDir, "output"), 0755))
205-
icmd.RunCmd(icmd.Cmd{
206-
Command: []string{dockerApp, "unpack", "test", "-o", "output"},
207-
Dir: tempDir,
208-
}).Assert(t, icmd.Success)
209-
_, err = os.Stat(filepath.Join(tempDir, "output", "test.dockerapp", "docker-compose.yml"))
210-
assert.NilError(t, err)
211-
}
212-
213191
func TestSplitMerge(t *testing.T) {
214192
icmd.RunCommand(dockerApp, "merge", "testdata/render/envvariables/my.dockerapp", "-o", "remerged.dockerapp").Assert(t, icmd.Success)
215193
defer os.Remove("remerged.dockerapp")

0 commit comments

Comments
 (0)