Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Commit 0967cd4

Browse files
Change custom parameters prefix from "docker" to reverse DNS "com.docker.app" for:
* kubernetes-namespace * orchestrator Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
1 parent 5082323 commit 0967cd4

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

e2e/testdata/simple-bundle.json.golden

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@
6464
"env": "docker_param1"
6565
}
6666
},
67-
"docker.kubernetes-namespace": {
67+
"com.docker.app.kubernetes-namespace": {
6868
"type": "string",
6969
"defaultValue": "",
7070
"required": false,
@@ -76,7 +76,7 @@
7676
"env": "DOCKER_KUBERNETES_NAMESPACE"
7777
}
7878
},
79-
"docker.orchestrator": {
79+
"com.docker.app.orchestrator": {
8080
"type": "string",
8181
"defaultValue": "",
8282
"allowedValues": [

internal/packager/cnab.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ func ToCNAB(app *types.App, invocationImageName string) (*bundle.Bundle, error)
1212
mapping := ExtractCNABParameterMapping(app.Parameters())
1313
flatParameters := app.Parameters().Flatten()
1414
parameters := map[string]bundle.ParameterDefinition{
15-
"docker.orchestrator": {
15+
internal.Namespace + "orchestrator": {
1616
DataType: "string",
1717
AllowedValues: []interface{}{
1818
"",
@@ -27,15 +27,15 @@ func ToCNAB(app *types.App, invocationImageName string) (*bundle.Bundle, error)
2727
Description: "Orchestrator on which to deploy",
2828
},
2929
},
30-
"docker.kubernetes-namespace": {
31-
DataType: "string",
30+
internal.Namespace + "kubernetes-namespace": {
31+
DataType: "string",
32+
DefaultValue: "",
3233
Destination: &bundle.Location{
3334
EnvironmentVariable: internal.DockerKubernetesNamespaceEnvVar,
3435
},
3536
Metadata: &bundle.ParameterMetadata{
3637
Description: "Namespace in which to deploy",
3738
},
38-
DefaultValue: "",
3939
},
4040
}
4141
for name, envVar := range mapping.ParameterToCNABEnv {

0 commit comments

Comments
 (0)