From 8afa7120293d27ada2102f8d83e05fc8ceafeb60 Mon Sep 17 00:00:00 2001 From: dmmdea Date: Wed, 11 Nov 2026 12:17:39 -0500 Subject: [PATCH] ## 0.230.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - **Fixed:** a Windows swap now sees a node started through a junction (#850). A component's live directory can be a junction into its generation directory. The process finder compared the path CIM reports with the generation path by spelling, so a llama-swap swap restarted the daemon and then reported "no process appeared", and the rollback check failed the same way. Paths are now matched by the file they name. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Deletes: changes/unreleased/fix-windows-finder-follows-junctions.md --- .printing-press.json | 2 +- CHANGELOG.md | 9 +++++++++ VERSION | 2 +- .../unreleased/fix-windows-finder-follows-junctions.md | 6 ------ internal/buildinfo/buildinfo.go | 2 +- 5 files changed, 12 insertions(+), 9 deletions(-) delete mode 100644 changes/unreleased/fix-windows-finder-follows-junctions.md diff --git a/.printing-press.json b/.printing-press.json index eec53023b..4a4c28ad3 100644 --- a/.printing-press.json +++ b/.printing-press.json @@ -1,7 +1,7 @@ { "api_name": "local-offload", "cli_name": "local-offload", - "version": "0.229.0", + "version": "0.230.0", "printing_press_version": "hand-built-2026-06-12", "generated_at": "2026-06-12", "description": "Local offload harness - delegate grunt work (summarize/classify/extract/triage, plus vision, OCR, transcription and media generation) to a free local Gemma-family cascade via llama.cpp; MCP + CLI; the cascade never calls cloud and defers to the caller instead. The opt-in offload_nim tool is the only remote model surface; the opt-in offload_browse lane drives the operator's own browser with typed choices from a loopback decision endpoint the operator runs.", diff --git a/CHANGELOG.md b/CHANGELOG.md index 295b4be1e..5da5038b5 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,15 @@ Releases before 0.190.0 are archived verbatim under [docs/changelog/](docs/chang ## [Unreleased] +## [0.230.0] - 2026-11-11 - release: 0.230.0 + +### Fixed - a Windows swap sees a node started through a junction + +- **Why.** On Windows, llama-swap's live directory is a junction into its generation directory (`/llama-swap` -> `/llama-swap-versions/`). The process finder compared the path CIM reports, which is the path the process was started through (the junction), with the generation path the swap names, by spelling. The two never matched. Measured on a Windows node: the swap restarted llama-swap, and both the post-restart check and the rollback's check reported "no process appeared" against a running node. +- **What it does.** The finder fetches processes by file name and then matches a path by the file it names (`os.SameFile`). It still accepts an exact spelling. A junction or symlink on either side, or a short 8.3 name, now matches. A process whose path the OS will not give is still returned as unreadable, as before. The Linux finder already resolved links. +- **Where.** `internal/nodeswap/deps_windows.go` (`findProcessesByExeWindows`, `sameExecutable`). +- **Check.** One Windows test starts a real process through a junction and asks the finder for both the junction path and the generation path. On the old code it fails ("not found in []"); with the fix it passes. + ## [0.229.0] - 2026-11-11 - release: 0.229.0 ### Fixed - an engine swap run under `gpu reserve` no longer waits for its own lease diff --git a/VERSION b/VERSION index 6e04cb06f..cd52fec52 100644 --- a/VERSION +++ b/VERSION @@ -1 +1 @@ -0.229.0 +0.230.0 diff --git a/changes/unreleased/fix-windows-finder-follows-junctions.md b/changes/unreleased/fix-windows-finder-follows-junctions.md deleted file mode 100644 index ca4059e46..000000000 --- a/changes/unreleased/fix-windows-finder-follows-junctions.md +++ /dev/null @@ -1,6 +0,0 @@ -### Fixed - a Windows swap sees a node started through a junction - -- **Why.** On Windows, llama-swap's live directory is a junction into its generation directory (`/llama-swap` -> `/llama-swap-versions/`). The process finder compared the path CIM reports, which is the path the process was started through (the junction), with the generation path the swap names, by spelling. The two never matched. Measured on a Windows node: the swap restarted llama-swap, and both the post-restart check and the rollback's check reported "no process appeared" against a running node. -- **What it does.** The finder fetches processes by file name and then matches a path by the file it names (`os.SameFile`). It still accepts an exact spelling. A junction or symlink on either side, or a short 8.3 name, now matches. A process whose path the OS will not give is still returned as unreadable, as before. The Linux finder already resolved links. -- **Where.** `internal/nodeswap/deps_windows.go` (`findProcessesByExeWindows`, `sameExecutable`). -- **Check.** One Windows test starts a real process through a junction and asks the finder for both the junction path and the generation path. On the old code it fails ("not found in []"); with the fix it passes. diff --git a/internal/buildinfo/buildinfo.go b/internal/buildinfo/buildinfo.go index d3f80e536..8fdeef54d 100644 --- a/internal/buildinfo/buildinfo.go +++ b/internal/buildinfo/buildinfo.go @@ -29,7 +29,7 @@ import ( // `version` const aliases it (keeping the VERSION-file agreement test in // main_test.go binding), and fleet/pipeline stampers read it directly so no // plumbing carries it through config. -const Version = "0.229.0" +const Version = "0.230.0" var ( buildOnce sync.Once