HttpClient Socket Exhaustion

[vella-nicholas]

A new instance of HttpClient is created with every CustomerIO instance. I am concerned on HttpClient Socket Exhaustion. Do you have any opinion on this, please?

[vegardlarsen]

HttpClient exhaustion is a real issue that you should examine if you are hitting. It may very well be that our architecture is wrong here; I wrote CustomerIOSharp before I was aware of this issue.

But I think you can get away with having your CustomerIo object be a singleton, and therefore avoid the issue entirely. As long as your ICustomerFactory can tolerate being long-lived, that should work just fine?

[vella-nicholas]

Socket Exhaustion can now be avoided using HttpClientFactory, I just needed to make sure I did not miss anything in this implementation.

My take on this would be to wire up HttpClientFactory in the composition root and if this is packaged provide extension methods for IServiceCollection like services.UseCustomerIo();.

To conclude, I still think this is a great API and will save anyone a lot of development time!

[vegardlarsen]

I would be happy to accept a pull request for this.

It could be interesting to get a separate CustomerIOSharp.AspNetCore package as well, so you can do what you outline? That should probably be its own separate pull request, though.

[vella-nicholas]

If we go forward with this, I would be more than happy to fork the project and issue a PR!

[vegardlarsen]

Go for it! :)