Refactor: centralize test name extraction logic in SelfieExtension

Author: sksamuel

jvm/selfie-runner-junit5/src/main/kotlin/com/diffplug/selfie/junit5/SelfieExtension.kt

@@ -43,11 +43,12 @@ class SelfieExtension(projectConfig: AbstractProjectConfig) :
       execute: suspend (TestCase) -> TestResult
   ): TestResult {
     val file = SnapshotSystemJUnit5.forClass(testCase.spec::class.java.name)
-    val coroutineLocal = CoroutineDiskStorage(DiskStorageJUnit5(file, testCase.name.name))
+    val name = testCase.name.name
+    val coroutineLocal = CoroutineDiskStorage(DiskStorageJUnit5(file, name))
     return withContext(currentCoroutineContext() + coroutineLocal) {
-      file.startTest(testCase.name.name, false)
+      file.startTest(name, false)
       val result = execute(testCase)
-      file.finishedTestWithSuccess(testCase.name.name, false, result.isSuccess)
+      file.finishedTestWithSuccess(name, false, result.isSuccess)
       result
     }
   }

jvm/selfie-runner-kotest/src/commonMain/kotlin/com/diffplug/selfie/kotest/SelfieExtension.kt

@@ -90,8 +90,9 @@ class SelfieExtension(
     val file = results.keys.map { snapshotFileFor(it) }.firstOrNull() ?: return
     results.entries.forEach {
       if (it.value.isIgnored) {
-        file.startTest(it.key.name.name)
-        file.finishedTestWithSuccess(it.key.name.name, false)
+        val name = it.key.name.name
+        file.startTest(name)
+        file.finishedTestWithSuccess(name, false)
       }
     }
     file.finishedClassWithSuccess(results.entries.all { it.value.isSuccess })