Claude Code simplify: remove dead promoteTodo method and hoist duplicated clearRecoveryTimer in toggleTodo

Author: nedtwigg

lib/src/lib/alarm-manager.test.ts

@@ -266,15 +266,15 @@ describe('AlarmManager in isolation', () => {
     expect(manager.getState(id).todo).toBeCloseTo(0.5);
   });
 
-  it('promoting a partially-struck soft-TODO resets to hard', () => {
+  it('marking a partially-struck soft-TODO as hard resets to hard', () => {
     const id = 'bucket-promote';
     createSoftTodo(id);
 
     manager.drainTodoBucket(id);
     manager.drainTodoBucket(id);
     expect(manager.getState(id).todo).toBeCloseTo(0.5);
 
-    manager.promoteTodo(id);
+    manager.markTodo(id);
     expect(manager.getState(id).todo).toBe(TODO_HARD);
   });
 
@@ -347,7 +347,7 @@ describe('AlarmManager in isolation', () => {
     createSoftTodo(id);
 
     // Promote to hard
-    manager.promoteTodo(id);
+    manager.markTodo(id);
     expect(manager.getState(id).todo).toBe(TODO_HARD);
 
     // Drive to ALARM_RINGING again

lib/src/lib/alarm-manager.ts

@@ -237,12 +237,11 @@ export class AlarmManager {
   /** Toggle: off → hard, soft → hard, hard → off */
   toggleTodo(id: string): void {
     const entry = this.getOrCreateEntry(id);
+    this.clearRecoveryTimer(entry);
     if (entry.todo === TODO_HARD) {
-      this.clearRecoveryTimer(entry);
       entry.todo = TODO_OFF;
       this.notify(id);
     } else {
-      this.clearRecoveryTimer(entry);
       entry.todo = TODO_HARD;
       if (entry.monitor?.getStatus() === 'ALARM_RINGING') {
         entry.monitor.attend();
@@ -266,15 +265,6 @@ export class AlarmManager {
     this.notify(id);
   }
 
-  /** Promote soft TODO to hard */
-  promoteTodo(id: string): void {
-    const entry = this.getOrCreateEntry(id);
-    if (!isSoftTodo(entry.todo)) return;
-    this.clearRecoveryTimer(entry);
-    entry.todo = TODO_HARD;
-    this.notify(id);
-  }
-
   /** Clear any TODO state */
   clearTodo(id: string): void {
     const entry = this.getOrCreateEntry(id);

lib/src/lib/platform/fake-adapter.ts

@@ -147,7 +147,6 @@ export class FakePtyAdapter implements PlatformAdapter {
   alarmClearAttention(id?: string): void { this.alarmManager.clearAttention(id); }
   alarmToggleTodo(id: string): void { this.alarmManager.toggleTodo(id); }
   alarmMarkTodo(id: string): void { this.alarmManager.markTodo(id); }
-  alarmPromoteTodo(id: string): void { this.alarmManager.promoteTodo(id); }
   alarmClearTodo(id: string): void { this.alarmManager.clearTodo(id); }
   alarmDrainTodoBucket(id: string): void { this.alarmManager.drainTodoBucket(id); }
   onAlarmState(handler: (detail: AlarmStateDetail) => void): void { this.alarmStateHandlers.add(handler); }

lib/src/lib/platform/types.ts

@@ -55,7 +55,6 @@ export interface PlatformAdapter {
   alarmClearAttention(id?: string): void;
   alarmToggleTodo(id: string): void;
   alarmMarkTodo(id: string): void;
-  alarmPromoteTodo(id: string): void;
   alarmClearTodo(id: string): void;
   alarmDrainTodoBucket(id: string): void;
   onAlarmState(handler: (detail: AlarmStateDetail) => void): void;

lib/src/lib/platform/vscode-adapter.ts

@@ -203,10 +203,6 @@ export class VSCodeAdapter implements PlatformAdapter {
     this.vscode.postMessage({ type: 'alarm:markTodo', id });
   }
 
-  alarmPromoteTodo(id: string): void {
-    this.vscode.postMessage({ type: 'alarm:promoteTodo', id });
-  }
-
   alarmClearTodo(id: string): void {
     this.vscode.postMessage({ type: 'alarm:clearTodo', id });
   }

lib/src/lib/session-save.test.ts

@@ -50,7 +50,6 @@ function createPlatform(savedState: PersistedSession | null): PlatformAdapter {
     alarmClearAttention: () => {},
     alarmToggleTodo: () => {},
     alarmMarkTodo: () => {},
-    alarmPromoteTodo: () => {},
     alarmClearTodo: () => {},
     alarmDrainTodoBucket: () => {},
     onAlarmState: () => {},

standalone/src/tauri-adapter.ts

@@ -205,10 +205,6 @@ export class TauriAdapter implements PlatformAdapter {
     this.alarmManager.markTodo(id);
   }
 
-  alarmPromoteTodo(id: string): void {
-    this.alarmManager.promoteTodo(id);
-  }
-
   alarmClearTodo(id: string): void {
     this.alarmManager.clearTodo(id);
   }

vscode-ext/src/message-router.ts

@@ -298,9 +298,6 @@ export function attachRouter(
       case 'alarm:markTodo':
         alarmManager.markTodo(msg.id);
         break;
-      case 'alarm:promoteTodo':
-        alarmManager.promoteTodo(msg.id);
-        break;
       case 'alarm:clearTodo':
         alarmManager.clearTodo(msg.id);
         break;

vscode-ext/src/message-types.ts

@@ -23,7 +23,6 @@ export type WebviewMessage =
   | { type: 'alarm:clearAttention'; id?: string }
   | { type: 'alarm:toggleTodo'; id: string }
   | { type: 'alarm:markTodo'; id: string }
-  | { type: 'alarm:promoteTodo'; id: string }
   | { type: 'alarm:clearTodo'; id: string }
   | { type: 'alarm:drainTodoBucket'; id: string };