You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
fix: align public API and docs with project philosophy
Export Brightness, PulsatingEffect, and NAMED_COLORS from the top-level
package. Fix brand name references to "Dimplex, Faber, and Real Flame"
across __init__.py, pyproject.toml, and cli.py. Remove stale fan-only
heat-mode from README, fix brightness docs (low/high not 0-255), and
remove light-status from argparse help text.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy file name to clipboardExpand all lines: .ai/task-manager/plans/13--philosophy-alignment-fixes/plan-13--philosophy-alignment-fixes.md
+37Lines changed: 37 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -124,9 +124,46 @@ Six targeted text fixes across four files:
124
124
- Existing CI pipeline (ruff, mypy, pytest) for validation
125
125
- No new dependencies or tools required
126
126
127
+
## Execution Blueprint
128
+
129
+
```mermaid
130
+
graph TD
131
+
01["Task 01: Public API exports"] --> Done["Done"]
132
+
02["Task 02: Documentation fixes"] --> Done
133
+
```
134
+
135
+
### ✅ Phase 1: All Fixes
136
+
**Parallel Tasks:**
137
+
- ✔️ Task 01: Export missing model types from __init__.py
138
+
- ✔️ Task 02: Fix documentation and brand name inconsistencies
139
+
140
+
### Execution Summary
141
+
- Total Phases: 1
142
+
- Total Tasks: 2
143
+
- All tasks completed in parallel
144
+
145
+
## Execution Summary
146
+
147
+
**Status**: ✅ Completed Successfully
148
+
**Completed Date**: 2026-02-26
149
+
150
+
### Results
151
+
-**Public API**: Added `Brightness`, `PulsatingEffect`, and `NAMED_COLORS` to `__init__.py` imports and `__all__`.
152
+
-**Brand names**: Updated from "Dimplex/Faber" or "Dimplex" to "Dimplex, Faber, and Real Flame" in `__init__.py`, `pyproject.toml`, and `cli.py`.
153
+
-**README**: Removed `fan-only` from heat-mode example, changed brightness from "0-255" to "low, high".
154
+
-**CLI**: Removed `light-status` from argparse settable parameter list.
155
+
- All 1044 tests pass, mypy clean, ruff clean.
156
+
157
+
### Noteworthy Events
158
+
No significant issues encountered. All changes were small, targeted text edits.
159
+
160
+
### Recommendations
161
+
None — all philosophy gaps identified in the audit have been addressed.
162
+
127
163
## Notes
128
164
129
165
### Change Log
130
166
131
167
- 2026-02-25: Initial plan creation
132
168
- 2026-02-25: Refinement — all 8 gaps verified against codebase; added `__all__` placement guidance for new exports; no clarifications needed from user
169
+
- 2026-02-26: Execution completed — all 8 fixes applied
0 commit comments