refactor: consolidate display overrides and add field validation asserts

Phase 3 of dynamic typing hardening:
- Remove duplicate _FIRE_MODE_DISPLAY and _FLAME_COLOR_DISPLAY dicts
  from cli.py, replacing with centralized display_name() from models.py
- Remove duplicate _MODE_DISPLAY dict from tui/widgets.py
- Add module-level assert validating _FEATURE_LABELS field names
  against FireFeatures dataclass fields
- Add module-level assert validating _FLAME_EFFECT_SETTERS field
  names against FlameEffectParam dataclass fields

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: deviantintegral

src/flameconnect/cli.py

@@ -4,6 +4,7 @@
 
 import argparse
 import asyncio
+import dataclasses
 import logging
 import sys
 import webbrowser
@@ -54,18 +55,6 @@
     temp_suffix,
 )
 
-# ---------------------------------------------------------------------------
-# Enum display-name overrides (only where display_name() is insufficient)
-# ---------------------------------------------------------------------------
-
-_FIRE_MODE_DISPLAY: dict[FireMode, str] = {FireMode.MANUAL: "On"}
-
-_FLAME_COLOR_DISPLAY: dict[FlameColor, str] = {
-    FlameColor.YELLOW_RED: "Yellow/Red",
-    FlameColor.YELLOW_BLUE: "Yellow/Blue",
-    FlameColor.BLUE_RED: "Blue/Red",
-}
-
 # Mapping from CLI heat-mode string to HeatMode enum value
 _HEAT_MODE_LOOKUP: dict[str, HeatMode] = {
     kebab_name(m): m for m in (HeatMode.NORMAL, HeatMode.BOOST, HeatMode.ECO)
@@ -129,7 +118,7 @@ def _display_mode(
     display_temp = convert_temp(param.target_temperature, unit)
     print("\n  [321] Mode")
     print(f"  {'─' * 40}")
-    mode = _FIRE_MODE_DISPLAY.get(param.mode, display_name(param.mode))
+    mode = display_name(param.mode)
     print(f"    Mode:           {mode}")
     print(f"    Target Temp:    {display_temp}\u00b0{unit_suffix}")
 
@@ -145,7 +134,7 @@ def _display_flame_effect(param: FlameEffectParam) -> None:
     pulsating = display_name(param.pulsating_effect)
     print(f"    Brightness:     {brightness}")
     print(f"    Pulsating:      {pulsating}")
-    color = _FLAME_COLOR_DISPLAY.get(param.flame_color, display_name(param.flame_color))
+    color = display_name(param.flame_color)
     print(f"    Flame Color:    {color}")
     theme = display_name(param.media_theme)
     rgbw = _format_rgbw(param.media_color)
@@ -286,6 +275,10 @@ def _display_log_effect(param: LogEffectParam) -> None:
     ("rgb_log_effect", "RGB Log Effect"),
 ]
 
+assert {fn for fn, _ in _FEATURE_LABELS} == {
+    f.name for f in dataclasses.fields(FireFeatures)
+}, "_FEATURE_LABELS field names do not match FireFeatures fields"
+
 
 def _display_features(features: FireFeatures) -> None:
     """Display supported feature flags."""
@@ -408,6 +401,11 @@ async def cmd_status(client: FlameConnectClient, fire_id: str) -> None:
     ),
 }
 
+assert all(
+    setter.field in {f.name for f in dataclasses.fields(FlameEffectParam)}
+    for setter in _FLAME_EFFECT_SETTERS.values()
+), "_FLAME_EFFECT_SETTERS contains invalid FlameEffectParam field names"
+
 
 async def cmd_on(client: FlameConnectClient, fire_id: str) -> None:
     """Turn on a fireplace."""

src/flameconnect/tui/widgets.py

@@ -122,12 +122,6 @@ def _format_rgbw(color: RGBWColor) -> str:
     return f"R:{color.red} G:{color.green} B:{color.blue} W:{color.white}"
 
 
-_MODE_DISPLAY: dict[FireMode, str] = {
-    FireMode.STANDBY: "Standby",
-    FireMode.MANUAL: "On",
-}
-
-
 def _format_mode(
     param: ModeParam,
     temp_unit: TempUnitParam | None = None,
@@ -136,7 +130,7 @@ def _format_mode(
 
     Returns a list of FormattedParam tuples.
     """
-    mode_label = _MODE_DISPLAY.get(param.mode, display_name(param.mode))
+    mode_label = display_name(param.mode)
     suffix = temp_suffix(temp_unit)
     unit = temp_unit.unit if temp_unit else TempUnit.CELSIUS
     display_temp = convert_temp(param.target_temperature, unit)