feat: validate temperature range and timer duration in CLI set commands (#56)

* feat: add input validation for heat-temp and timer CLI commands

Co-authored-by: deviantintegral <255023+deviantintegral@users.noreply.github.com>

* refactor: remove try/except from _set_heat_temp to match existing handler pattern

Co-authored-by: deviantintegral <255023+deviantintegral@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: deviantintegral <255023+deviantintegral@users.noreply.github.com>

Author: Copilot

src/flameconnect/cli.py

@@ -20,8 +20,13 @@
     DEFAULT_TARGET_TEMPERATURE,
     MAX_BOOST_DURATION,
     MAX_FLAME_SPEED,
+    MAX_TEMP_CELSIUS,
+    MAX_TEMP_FAHRENHEIT,
+    MAX_TIMER_DURATION,
     MIN_BOOST_DURATION,
     MIN_FLAME_SPEED,
+    MIN_TEMP_CELSIUS,
+    MIN_TEMP_FAHRENHEIT,
 )
 from flameconnect.models import (
     NAMED_COLORS,
@@ -566,11 +571,24 @@ async def _set_heat_temp(client: FlameConnectClient, fire_id: str, value: str) -
     """Set the heater setpoint temperature."""
     temp = float(value)
     overview = await client.get_fire_overview(fire_id)
+    temp_unit_param = _find_param(overview.parameters, TempUnitParam)
+    unit = temp_unit_param.unit if temp_unit_param else TempUnit.CELSIUS
+    if unit == TempUnit.FAHRENHEIT:
+        min_temp, max_temp = MIN_TEMP_FAHRENHEIT, MAX_TEMP_FAHRENHEIT
+    else:
+        min_temp, max_temp = MIN_TEMP_CELSIUS, MAX_TEMP_CELSIUS
+    if not (min_temp <= temp <= max_temp):
+        unit_suffix = temp_suffix(temp_unit_param)
+        print(
+            f"Error: heat-temp must be between"
+            f" {min_temp} and {max_temp}\u00b0{unit_suffix}."
+        )
+        sys.exit(1)
     current = _find_param(overview.parameters, HeatParam)
     if current is None:
         print("Error: no HeatSettings parameter found.")
         sys.exit(1)
-    unit_suffix = temp_suffix(_find_param(overview.parameters, TempUnitParam))
+    unit_suffix = temp_suffix(temp_unit_param)
     new_param = replace(current, setpoint_temperature=temp)
     await client.write_parameters(fire_id, [new_param])
     print(f"Heat temperature set to {temp}\u00b0{unit_suffix}.")
@@ -582,6 +600,9 @@ async def _set_timer(client: FlameConnectClient, fire_id: str, value: str) -> No
     if minutes < 0:
         print("Error: timer must be non-negative (0 to disable).")
         sys.exit(1)
+    if minutes > MAX_TIMER_DURATION:
+        print(f"Error: timer must not exceed {MAX_TIMER_DURATION} minutes.")
+        sys.exit(1)
     timer_status = TimerStatus.ENABLED if minutes > 0 else TimerStatus.DISABLED
     timer_param = TimerParam(timer_status=timer_status, duration=minutes)
     await client.write_parameters(fire_id, [timer_param])

tests/test_cli_commands.py

@@ -1219,9 +1219,9 @@ async def test_heat_temp_with_fahrenheit_suffix(self, capsys):
             ],
         )
         client.get_fire_overview.return_value = overview
-        await cmd_set(client, FIRE_ID, "heat-temp", "25.0")
+        await cmd_set(client, FIRE_ID, "heat-temp", "72.0")
         out = capsys.readouterr().out
-        assert "25.0\u00b0F" in out
+        assert "72.0\u00b0F" in out
 
 
 # ===================================================================

tests/test_cli_set.py

@@ -23,7 +23,12 @@
     cmd_set,
 )
 from flameconnect.client import FlameConnectClient
-from flameconnect.const import API_BASE
+from flameconnect.const import (
+    API_BASE,
+    MAX_TEMP_CELSIUS,
+    MAX_TIMER_DURATION,
+    MIN_TEMP_CELSIUS,
+)
 from flameconnect.models import RGBWColor
 
 FIXTURES_DIR = Path(__file__).parent / "fixtures"
@@ -481,6 +486,35 @@ async def test_set_heat_temp(self, mock_api, token_auth, overview_payload):
         body = calls[0].kwargs["json"]
         assert body["Parameters"][0]["ParameterId"] == 323
 
+    async def test_set_heat_temp_too_low(
+        self, mock_api, token_auth, overview_payload, capsys
+    ):
+        mock_api.get(OVERVIEW_URL, payload=overview_payload)
+
+        async with FlameConnectClient(token_auth) as client:
+            with pytest.raises(SystemExit):
+                await _set_heat_temp(client, FIRE_ID, str(MIN_TEMP_CELSIUS - 1))
+        captured = capsys.readouterr()
+        assert "Error" in captured.out
+        assert str(MIN_TEMP_CELSIUS) in captured.out
+
+    async def test_set_heat_temp_too_high(
+        self, mock_api, token_auth, overview_payload, capsys
+    ):
+        mock_api.get(OVERVIEW_URL, payload=overview_payload)
+
+        async with FlameConnectClient(token_auth) as client:
+            with pytest.raises(SystemExit):
+                await _set_heat_temp(client, FIRE_ID, str(MAX_TEMP_CELSIUS + 1))
+        captured = capsys.readouterr()
+        assert "Error" in captured.out
+        assert str(MAX_TEMP_CELSIUS) in captured.out
+
+    async def test_set_heat_temp_not_a_number(self, mock_api, token_auth):
+        async with FlameConnectClient(token_auth) as client:
+            with pytest.raises(ValueError):
+                await _set_heat_temp(client, FIRE_ID, "hot")
+
 
 # ---------------------------------------------------------------------------
 # _set_timer
@@ -518,6 +552,14 @@ async def test_set_timer_negative(self, mock_api, token_auth, capsys):
         captured = capsys.readouterr()
         assert "Error" in captured.out
 
+    async def test_set_timer_exceeds_max(self, mock_api, token_auth, capsys):
+        async with FlameConnectClient(token_auth) as client:
+            with pytest.raises(SystemExit):
+                await _set_timer(client, FIRE_ID, str(MAX_TIMER_DURATION + 1))
+        captured = capsys.readouterr()
+        assert "Error" in captured.out
+        assert str(MAX_TIMER_DURATION) in captured.out
+
 
 # ---------------------------------------------------------------------------
 # cmd_set dispatch