fix: pulsating effect belongs to overhead light, not flames (#67)

* Initial plan

* fix: pulsating effect is for overhead light, not flames

Co-authored-by: deviantintegral <255023+deviantintegral@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: deviantintegral <255023+deviantintegral@users.noreply.github.com>

Author: Copilot

README.md

@@ -205,7 +205,7 @@ seconds. Key bindings:
 | `e` | Toggle flame effect |
 | `c` | Set flame color |
 | `b` | Toggle brightness (high/low) |
-| `g` | Toggle pulsating effect |
+| `g` | Toggle pulsating overhead light effect |
 | `m` | Set media theme |
 | `l` | Toggle media light |
 | `d` | Set media color (RGBW) |

src/flameconnect/cli.py

@@ -136,16 +136,16 @@ def _display_flame_effect(param: FlameEffectParam) -> None:
     print(f"    Flame:          {flame}")
     print(f"    Flame Speed:    {param.flame_speed} / {MAX_FLAME_SPEED}")
     brightness = display_name(param.brightness)
-    pulsating = display_name(param.pulsating_effect)
     print(f"    Brightness:     {brightness}")
-    print(f"    Pulsating:      {pulsating}")
     color = display_name(param.flame_color)
     print(f"    Flame Color:    {color}")
     theme = display_name(param.media_theme)
     rgbw = _format_rgbw(param.media_color)
     print(f"    Media Light:    {theme} | {rgbw}")
     light = display_name(param.light_status)
+    pulsating = display_name(param.pulsating_effect)
     print(f"    Overhead Light: {light}")
+    print(f"    Overhead Pulsating: {pulsating}")
     print(f"    Overhead Color: {_format_rgbw(param.overhead_color)}")
     ambient = display_name(param.ambient_sensor)
     print(f"    Ambient Sensor: {ambient}")
@@ -372,7 +372,7 @@ async def cmd_status(client: FlameConnectClient, fire_id: str) -> None:
     "pulsating": _FlameEffectSetter(
         "pulsating_effect",
         dict[str, object](_PULSATING_LOOKUP),
-        "Pulsating effect",
+        "Pulsating overhead light effect",
     ),
     "flame-color": _FlameEffectSetter(
         "flame_color",

src/flameconnect/models.py

@@ -32,7 +32,7 @@ class Brightness(IntEnum):
 
 
 class PulsatingEffect(IntEnum):
-    """Pulsating flame effect."""
+    """Pulsating overhead light effect."""
 
     OFF = 0
     ON = 1

src/flameconnect/tui/app.py

@@ -109,7 +109,9 @@ class _ControlCommand(NamedTuple):
     _ControlCommand("Flame Color", "Set flame color", "set_flame_color"),
     _ControlCommand("Flame Speed", "Set flame speed", "set_flame_speed"),
     _ControlCommand("Brightness", "Toggle brightness high/low", "toggle_brightness"),
-    _ControlCommand("Pulsating", "Toggle pulsating effect", "toggle_pulsating"),
+    _ControlCommand(
+        "Pulsating", "Toggle pulsating overhead light effect", "toggle_pulsating"
+    ),
     _ControlCommand("Media Theme", "Set media theme", "set_media_theme"),
     _ControlCommand("Media Light", "Toggle media light on/off", "toggle_media_light"),
     _ControlCommand("Media Color", "Set media color", "set_media_color"),
@@ -472,7 +474,7 @@ def action_toggle_flame_effect(self) -> None:
         )
 
     def action_toggle_pulsating(self) -> None:
-        """Handle the 'g' key binding to toggle pulsating on/off."""
+        """Handle the 'g' key binding to toggle pulsating overhead light on/off."""
         from flameconnect.models import PulsatingEffect
 
         result = self._get_current_param(FlameEffectParam)

src/flameconnect/tui/widgets.py

@@ -176,11 +176,6 @@ def _format_flame_effect(
             display_name(param.brightness),
             "toggle_brightness",
         ),
-        FormattedParam(
-            "  Pulsating: ",
-            display_name(param.pulsating_effect),
-            "toggle_pulsating",
-        ),
         FormattedParam(
             "  Media Theme: ",
             display_name(param.media_theme),
@@ -201,6 +196,11 @@ def _format_flame_effect(
             display_name(param.light_status),
             "toggle_overhead_light",
         ),
+        FormattedParam(
+            "  Overhead Pulsating: ",
+            display_name(param.pulsating_effect),
+            "toggle_pulsating",
+        ),
         FormattedParam(
             "  Overhead Color: ",
             _format_rgbw(param.overhead_color),

tests/test_cli_commands.py

@@ -255,7 +255,7 @@ def test_all_fields_displayed(self, capsys):
         assert "Flame:          On" in out
         assert "4 / 5" in out
         assert "Low" in out
-        assert "Pulsating:      On" in out
+        assert "Overhead Pulsating: On" in out
         assert "Blue" in out
         assert "Prism" in out
         assert "RGBW(10, 20, 30, 40)" in out
@@ -778,7 +778,7 @@ async def test_dispatch_pulsating(self, capsys):
         client.get_fire_overview.return_value = overview
         await cmd_set(client, FIRE_ID, "pulsating", "on")
         out = capsys.readouterr().out
-        assert "Pulsating effect set to on" in out
+        assert "Pulsating overhead light effect set to on" in out
 
     async def test_dispatch_flame_color(self, capsys):
         client = AsyncMock()

tests/test_widgets_format.py

@@ -265,8 +265,8 @@ def test_basic_flame_effect(self):
         param = _sample_flame_effect()
         result = _format_flame_effect(param)
         # Should have 11 tuples (flame_effect + color + speed + brightness
-        #   + pulsating + media_theme + media_light + media_color
-        #   + overhead_light + overhead_color + ambient_sensor)
+        #   + media_theme + media_light + media_color
+        #   + overhead_light + pulsating + overhead_color + ambient_sensor)
         assert len(result) == 11
 
     def test_flame_effect_labels_and_actions(self):
@@ -278,11 +278,11 @@ def test_flame_effect_labels_and_actions(self):
         assert labels_and_actions[1][1] == "set_flame_color"
         assert labels_and_actions[2][1] == "set_flame_speed"
         assert labels_and_actions[3][1] == "toggle_brightness"
-        assert labels_and_actions[4][1] == "toggle_pulsating"
-        assert labels_and_actions[5][1] == "set_media_theme"
-        assert labels_and_actions[6][1] == "toggle_media_light"
-        assert labels_and_actions[7][1] == "set_media_color"
-        assert labels_and_actions[8][1] == "toggle_overhead_light"
+        assert labels_and_actions[4][1] == "set_media_theme"
+        assert labels_and_actions[5][1] == "toggle_media_light"
+        assert labels_and_actions[6][1] == "set_media_color"
+        assert labels_and_actions[7][1] == "toggle_overhead_light"
+        assert labels_and_actions[8][1] == "toggle_pulsating"
         assert labels_and_actions[9][1] == "set_overhead_color"
         assert labels_and_actions[10][1] == "toggle_ambient_sensor"
 
@@ -302,16 +302,16 @@ def test_flame_effect_values(self):
         assert result[1][1] == "Blue"  # FlameColor.BLUE
         assert result[2][1] == "5/5"  # flame_speed
         assert result[3][1] == "Low"  # Brightness.LOW
-        assert result[4][1] == "On"  # PulsatingEffect.ON
-        assert result[5][1] == "Prism"  # MediaTheme.PRISM
-        assert result[6][1] == "Off"  # media_light OFF
+        assert result[4][1] == "Prism"  # MediaTheme.PRISM
+        assert result[5][1] == "Off"  # media_light OFF
+        assert result[8][1] == "On"  # PulsatingEffect.ON
         assert result[10][1] == "On"  # ambient_sensor ON
 
     def test_flame_effect_media_color_format(self):
         color = RGBWColor(red=10, green=20, blue=30, white=40)
         param = _sample_flame_effect(media_color=color)
         result = _format_flame_effect(param)
-        assert result[7][1] == "R:10 G:20 B:30 W:40"
+        assert result[6][1] == "R:10 G:20 B:30 W:40"
 
     def test_flame_effect_overhead_color_format(self):
         color = RGBWColor(red=50, green=60, blue=70, white=80)
@@ -322,7 +322,7 @@ def test_flame_effect_overhead_color_format(self):
     def test_overhead_light_status_display(self):
         param = _sample_flame_effect(light_status=LightStatus.OFF)
         result = _format_flame_effect(param)
-        assert result[8][1] == "Off"  # Overhead Light uses light_status
+        assert result[7][1] == "Off"  # Overhead Light uses light_status
 
 
 # ---------------------------------------------------------------------------