From 4124205be40ff7dac1d747b01bfb76c1080bd1f0 Mon Sep 17 00:00:00 2001 From: Kyle Barron Date: Mon, 1 Jun 2026 15:15:28 -0400 Subject: [PATCH] chore: Update comment mentioning `derive(FromPyObject)` --- obstore/src/get.rs | 3 +-- obstore/src/put.rs | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/obstore/src/get.rs b/obstore/src/get.rs index 31c25914..afdcc978 100644 --- a/obstore/src/get.rs +++ b/obstore/src/get.rs @@ -37,8 +37,7 @@ impl<'py> FromPyObject<'_, 'py> for PyGetOptions { type Error = PyErr; fn extract(obj: Borrowed<'_, 'py, PyAny>) -> Result { - // Update to use derive(FromPyObject) when default is implemented: - // https://github.com/PyO3/pyo3/issues/4643 + // Can't use derive(FromPyObject) when all fields have default values let dict = obj.extract::>>()?; Ok(Self { if_match: dict.get("if_match").map(|x| x.extract()).transpose()?, diff --git a/obstore/src/put.rs b/obstore/src/put.rs index 3601446e..68433107 100644 --- a/obstore/src/put.rs +++ b/obstore/src/put.rs @@ -52,8 +52,7 @@ impl<'py> FromPyObject<'_, 'py> for PyUpdateVersion { type Error = PyErr; fn extract(obj: Borrowed<'_, 'py, PyAny>) -> Result { - // Update to use derive(FromPyObject) when default is implemented: - // https://github.com/PyO3/pyo3/issues/4643 + // Can't use derive(FromPyObject) when all fields have default values let dict = obj.extract::>>()?; Ok(Self(UpdateVersion { e_tag: dict.get("e_tag").map(|x| x.extract()).transpose()?,