Swift 1.2 compiler errors

[RaviDesai]

Hey Denis, when using your library with the latest Xcode, I ran across some compiler errors. The following fixes to KeychainSwiftApi.swift gets rid of the compiler errors.

   public class func secItemAdd(#query : Query) -> (status: ResultCode, result: NSObject?)
     {
         let dic = query.toNSDictionary()
-        let resultAndStatus = CXKeychainHelper.secItemAddCaller(query.toNSDictionary())
+        let resultAndStatus = CXKeychainHelper.secItemAddCaller(query.toNSDictionary() as [NSObject : AnyObject])
         let status = ResultCode.fromRaw(resultAndStatus.status)
         return (status: status, result: resultAndStatus.result)
     }
 @@ -1027,7 +1027,7 @@ public class Keychain
     public class func secItemCopyMatching(#query : Query) -> (status: ResultCode, result: NSObject?)
     {
         let dic : NSDictionary = query.toNSDictionary()
-        let resultAndStatus = CXKeychainHelper.secItemCopyMatchingCaller(dic)
+        let resultAndStatus = CXKeychainHelper.secItemCopyMatchingCaller(dic as [NSObject : AnyObject])
         return (status: ResultCode.fromRaw(resultAndStatus.status), result: resultAndStatus.result)
     }

However, I forked your repo and also modified your test project to use your Pod as a framework. Which changes a massive number of files around. I can PR the whole branch if you like, but not sure if you'd be interested in that. You can check here to see my fork: https://github.com/RaviDesai/KeychainSwiftAPI/tree/fixes-for-new-xcode

[deniskr]

Hi Ravindranath,

Thanks for your fixes. Yes please make a PR.

Denis

Am 17.05.2015 um 01:01 schrieb Ravindranath Desai notifications@github.com:

Hey Denis, when using your library with the latest Xcode, I ran across some compiler errors. The following fixes to KeychainSwiftApi.swift gets rid of the compiler errors.

public class func secItemAdd(#query : Query) -> (status: ResultCode, result: NSObject?)
{
let dic = query.toNSDictionary()

let resultAndStatus = CXKeychainHelper.secItemAddCaller(query.toNSDictionary())
let resultAndStatus = CXKeychainHelper.secItemAddCaller(query.toNSDictionary() as [NSObject : AnyObject]) let status = ResultCode.fromRaw(resultAndStatus.status) return (status: status, result: resultAndStatus.result) } @@ -1027,7 +1027,7 @@ public class Keychain public class func secItemCopyMatching(#query : Query) -> (status: ResultCode, result: NSObject?) { let dic : NSDictionary = query.toNSDictionary()
let resultAndStatus = CXKeychainHelper.secItemCopyMatchingCaller(dic)
let resultAndStatus = CXKeychainHelper.secItemCopyMatchingCaller(dic as [NSObject : AnyObject]) return (status: ResultCode.fromRaw(resultAndStatus.status), result: resultAndStatus.result) }
However, I forked your repo and also modified your test project to use your Pod as a framework. Which changes a massive number of files around. I can PR the whole branch if you like, but not sure if you'd be interested in that. You can check here to see my fork: https://github.com/RaviDesai/KeychainSwiftAPI/tree/fixes-for-new-xcode https://github.com/RaviDesai/KeychainSwiftAPI/tree/fixes-for-new-xcode
—
Reply to this email directly or view it on GitHub #4.