Changed call to Test-PdcConfiguration

Fixed bug in query for clone
Changed check for test in Remove-PdcDatabaseImage
Removed text from referring to previous module

Author: sanderstad

functions/Invoke-PdcRepairClone.ps1

@@ -49,7 +49,7 @@ function Invoke-PdcRepairClone {
 
     begin {
         # Test the module database setup
-        $result = Test-PdcConfiguration -SqlInstance $ecDatabaseServer -SqlCredential $SqlCredential -Database $ecDatabaseName
+        $result = Test-PdcConfiguration
 
         if(-not $result.Check){
             Stop-PSFFunction -Message $result.Message -Target $result -Continue

functions/New-PdcDatabaseClone.ps1

@@ -95,7 +95,7 @@ function New-PdcDatabaseClone {
         Write-PSFMessage -Message "Started image creation" -Level Output
 
         # Test the module database setup
-        $result = Test-PdcConfiguration -SqlInstance $ecDatabaseServer -SqlCredential $SqlCredential -Database $ecDatabaseName
+        $result = Test-PdcConfiguration
 
         if(-not $result.Check){
             Stop-PSFFunction -Message $result.Message -Target $result -Continue
@@ -157,7 +157,7 @@ function New-PdcDatabaseClone {
                                 [DatabaseName],
                                 [DatabaseTimestamp],
                                 [CreatedOn]
-                        FROM [EasyClone].[dbo].[Image]
+                        FROM [dbo].[Image]
                         WHERE DatabaseName = '$db'
                         ORDER BY CreatedOn DESC;
                     "

functions/New-PdcDatabaseImage.ps1

@@ -119,7 +119,7 @@ function New-PdcDatabaseImage {
     begin {
 
         # Test the module database setup
-        $result = Test-PdcConfiguration -SqlInstance $ecDatabaseServer -SqlCredential $SqlCredential -Database $ecDatabaseName
+        $result = Test-PdcConfiguration
 
         if(-not $result.Check){
             Stop-PSFFunction -Message $result.Message -Target $result -Continue

functions/Remove-PdcDatabaseClone.ps1

@@ -85,7 +85,7 @@ function Remove-PdcDatabaseClone {
         Write-PSFMessage -Message "Started removing database clones" -Level Verbose
 
         # Test the module database setup
-        $result = Test-PdcConfiguration -SqlInstance $ecDatabaseServer -SqlCredential $SqlCredential -Database $ecDatabaseName
+        $result = Test-PdcConfiguration
 
         if(-not $result.Check){
             Stop-PSFFunction -Message $result.Message -Target $result -Continue
@@ -147,12 +147,12 @@ function Remove-PdcDatabaseClone {
         foreach ($result in $results) {
 
             # Connect to the instance
-            Write-PSFMessage -Message "Attempting to connect to easy clone database server $($result.SqlInstance).." -Level Verbose
+            Write-PSFMessage -Message "Attempting to connect to clone database server $($result.SqlInstance).." -Level Verbose
             try {
                 $server = Connect-DbaInstance -SqlInstance $result.SqlInstance -SqlCredential $SqlCredential
             }
             catch {
-                Stop-PSFFunction -Message "Could not connect to Sql Server instance $server" -ErrorRecord $_ -Target $server -Continue
+                Stop-PSFFunction -Message "Could not connect to clone Sql Server instance $server" -ErrorRecord $_ -Target $server -Continue
             }
 
             # Remove the database

functions/Remove-PdcDatabaseImage.ps1

@@ -45,12 +45,8 @@ function Remove-PdcDatabaseImage {
     begin {
         Write-PSFMessage -Message "Started removing database images" -Level Verbose
 
-        # Get the configurations for the program database
-        $ecDatabaseName = Get-PSFConfigValue -FullName easyclone.database.name
-        $ecDatabaseServer = Get-PSFConfigValue -FullName easyclone.database.server
-
         # Test the module database setup
-        $result = Test-PdcConfiguration -SqlInstance $ecDatabaseServer -SqlCredential $SqlCredential -Database $ecDatabaseName
+        $result = Test-PdcConfiguration
 
         if(-not $result.Check){
             Stop-PSFFunction -Message $result.Message -Target $result -Continue

internal/functions/Test-PdcConfiguration.ps1

@@ -55,7 +55,7 @@ function Test-PdcConfiguration {
 
     $errorOccured = $false
 
-    # Check if the values for the EasyClone database are set
+    # Check if the values for the PSDatabaseClone database are set
     if (($SqlInstance -eq $null) -or ($Database -eq $null)) {
         # Get the configurations for the program database
         $Database = Get-PSFConfigValue -FullName psdatabaseclone.database.name -Fallback "NotConfigured"
@@ -95,7 +95,7 @@ function Test-PdcConfiguration {
         }
     }
 
-    # Check if the easyclone database is present
+    # Check if the PSDatabaseClone database is present
     if ($ecServer.Databases.Name -notcontains $Database) {
         $errorOccured = $true
         $result.Check = $false