Update CmdletBinding to include ConfirmImpact - closes ConfirmImpact of destructive functions should be high #46

SQLDBAWithABeard · SQLDBAWithABeard · commit a34d18e92b71 · 2025-05-19T18:16:12.000Z
This change enhances the safety of the following functions by setting the ConfirmImpact to 'High':
- Remove-FabricDomainWorkspaceRoleAssignment
- Remove-FabricEnvironment
- Remove-FabricEventhouse
- Remove-FabricEventstream
- Revoke-FabricExternalDataShares
- Remove-FabricItem
- Remove-FabricMLModel
- Remove-FabricReflex
- Remove-FabricSQLDatabase
- Remove-FabricSparkJobDefinition
- Remove-FabricSparkCustomPool
- Revoke-FabricCapacityTenantSettingOverrides
- Remove-FabricWarehouse

This ensures that users are prompted for confirmation before executing potentially destructive actions.

Thank you!
diff --git a/source/Public/Domain/Remove-FabricDomainWorkspaceRoleAssignment.ps1 b/source/Public/Domain/Remove-FabricDomainWorkspaceRoleAssignment.ps1
@@ -32,7 +32,7 @@ Author: Tiago Balabuch
 #>
 
 function Remove-FabricDomainWorkspaceRoleAssignment {
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     [Alias("Unassign-FabricDomainWorkspaceRoleAssignment")]
     param (
         [Parameter(Mandatory = $true)]
diff --git a/source/Public/Environment/Remove-FabricEnvironment.ps1 b/source/Public/Environment/Remove-FabricEnvironment.ps1
@@ -26,7 +26,7 @@ Author: Tiago Balabuch
 
 function Remove-FabricEnvironment
 {
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
diff --git a/source/Public/Eventhouse/Remove-FabricEventhouse.ps1 b/source/Public/Eventhouse/Remove-FabricEventhouse.ps1
@@ -38,7 +38,7 @@ function Remove-FabricEventhouse
 
     #>
 
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
diff --git a/source/Public/Eventstream/Remove-FabricEventstream.ps1 b/source/Public/Eventstream/Remove-FabricEventstream.ps1
@@ -30,7 +30,7 @@ Deletes the Eventstream with ID "67890" from workspace "12345".
 Author: Tiago Balabuch
 
     #>
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
diff --git a/source/Public/External Data Share/Revoke-FabricExternalDataShares.ps1 b/source/Public/External Data Share/Revoke-FabricExternalDataShares.ps1
@@ -27,7 +27,7 @@ function Revoke-FabricExternalDataShares {
     Author: Tiago Balabuch
     #>
 
-    [CmdletBinding()]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
@@ -67,4 +67,4 @@ function Revoke-FabricExternalDataShares {
         Write-Message -Message "Failed to retrieve External Data Shares. Error: $errorDetails" -Level Error
     }
 
-}
+}
diff --git a/source/Public/Item/Remove-FabricItem.ps1 b/source/Public/Item/Remove-FabricItem.ps1
@@ -31,7 +31,7 @@
 #>
 
 Function Remove-FabricItem {
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param
     (
         [Parameter(Mandatory = $true)]
@@ -67,4 +67,4 @@ Function Remove-FabricItem {
             }
         }
     }
-}
+}
diff --git a/source/Public/ML Model/Remove-FabricMLModel.ps1 b/source/Public/ML Model/Remove-FabricMLModel.ps1
@@ -25,7 +25,7 @@
 #>
 function Remove-FabricMLModel
 {
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
diff --git a/source/Public/Reflex/Remove-FabricReflex.ps1 b/source/Public/Reflex/Remove-FabricReflex.ps1
@@ -25,7 +25,7 @@
 #>
 function Remove-FabricReflex
 {
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
diff --git a/source/Public/SQL Database/Remove-FabricSQLDatabase.ps1 b/source/Public/SQL Database/Remove-FabricSQLDatabase.ps1
@@ -26,7 +26,7 @@ Author: Kamil Nowinski
 
 function Remove-FabricSQLDatabase
 {
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
diff --git a/source/Public/Spark Job Definition/Remove-FabricSparkJobDefinition.ps1 b/source/Public/Spark Job Definition/Remove-FabricSparkJobDefinition.ps1
@@ -24,7 +24,7 @@
 #>
 function Remove-FabricSparkJobDefinition
 {
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
diff --git a/source/Public/Spark/Remove-FabricSparkCustomPool.ps1 b/source/Public/Spark/Remove-FabricSparkCustomPool.ps1
@@ -25,7 +25,7 @@
 #>
 function Remove-FabricSparkCustomPool
 {
-    [CmdletBinding(supportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
diff --git a/source/Public/Tenant/Revoke-FabricCapacityTenantSettingOverrides.ps1 b/source/Public/Tenant/Revoke-FabricCapacityTenantSettingOverrides.ps1
@@ -23,7 +23,7 @@ Removes the tenant setting override named "ExampleSetting" from the capacity wit
 Author: Tiago Balabuch
 #>
 function Revoke-FabricCapacityTenantSettingOverrides {
-    [CmdletBinding()]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]
@@ -56,4 +56,4 @@ function Revoke-FabricCapacityTenantSettingOverrides {
         $errorDetails = $_.Exception.Message
         Write-Message -Message "Error retrieving capacity tenant setting overrides: $errorDetails" -Level Error
     }
-}
+}
diff --git a/source/Public/Warehouse/Remove-FabricWarehouse.ps1 b/source/Public/Warehouse/Remove-FabricWarehouse.ps1
@@ -24,7 +24,7 @@
 #>
 function Remove-FabricWarehouse
 {
-    [CmdletBinding(SupportsShouldProcess)]
+    [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]
     param (
         [Parameter(Mandatory = $true)]
         [ValidateNotNullOrEmpty()]

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ Author: Tiago Balabuch`
`26`	`26`
`27`	`27`	`function Remove-FabricEnvironment`
`28`	`28`	`{`
`29`		`- [CmdletBinding(SupportsShouldProcess)]`
	`29`	`+ [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]`
`30`	`30`	`param (`
`31`	`31`	`[Parameter(Mandatory = $true)]`
`32`	`32`	`[ValidateNotNullOrEmpty()]`
Original file line number	Diff line number	Diff line change
`@@ -31,7 +31,7 @@`
`31`	`31`	`#>`
`32`	`32`
`33`	`33`	`Function Remove-FabricItem {`
`34`		`- [CmdletBinding(SupportsShouldProcess)]`
	`34`	`+ [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]`
`35`	`35`	`param`
`36`	`36`	`(`
`37`	`37`	`[Parameter(Mandatory = $true)]`
`@@ -67,4 +67,4 @@ Function Remove-FabricItem {`
`67`	`67`	`}`
`68`	`68`	`}`
`69`	`69`	`}`
`70`		`-}`
	`70`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@`
`25`	`25`	`#>`
`26`	`26`	`function Remove-FabricMLModel`
`27`	`27`	`{`
`28`		`- [CmdletBinding(SupportsShouldProcess)]`
	`28`	`+ [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]`
`29`	`29`	`param (`
`30`	`30`	`[Parameter(Mandatory = $true)]`
`31`	`31`	`[ValidateNotNullOrEmpty()]`
Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ Author: Kamil Nowinski`
`26`	`26`
`27`	`27`	`function Remove-FabricSQLDatabase`
`28`	`28`	`{`
`29`		`- [CmdletBinding(SupportsShouldProcess)]`
	`29`	`+ [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]`
`30`	`30`	`param (`
`31`	`31`	`[Parameter(Mandatory = $true)]`
`32`	`32`	`[ValidateNotNullOrEmpty()]`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@`
`24`	`24`	`#>`
`25`	`25`	`function Remove-FabricSparkJobDefinition`
`26`	`26`	`{`
`27`		`- [CmdletBinding(SupportsShouldProcess)]`
	`27`	`+ [CmdletBinding(SupportsShouldProcess, ConfirmImpact = 'High')]`
`28`	`28`	`param (`
`29`	`29`	`[Parameter(Mandatory = $true)]`
`30`	`30`	`[ValidateNotNullOrEmpty()]`