From 02d0e31c5beaa9ac1d4836efffb710366a1645c2 Mon Sep 17 00:00:00 2001 From: Quantum Explorer Date: Fri, 14 Aug 2026 21:31:49 +0700 Subject: [PATCH 1/2] fix(tests): tolerate vanished files in get_files_size to deflake WAL/SST overhead test RocksDB background compaction can delete a WAL/SST file between the read_dir listing and the metadata() call, causing test_wal_and_sst_storage_overhead to fail on CI with Os { code: 2, kind: NotFound }. Skip entries whose metadata can no longer be read instead of unwrapping. Co-Authored-By: Claude Fable 5 --- grovedb/src/tests/test_compaction_sizes.rs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/grovedb/src/tests/test_compaction_sizes.rs b/grovedb/src/tests/test_compaction_sizes.rs index 5f83e81ca..e10d47f3f 100644 --- a/grovedb/src/tests/test_compaction_sizes.rs +++ b/grovedb/src/tests/test_compaction_sizes.rs @@ -21,7 +21,10 @@ mod tests { .expect("cannot read dir") .filter_map(|entry| entry.ok()) .filter(|entry| entry.path().extension().is_some_and(|ext| ext == extension)) - .map(|entry| entry.metadata().unwrap().len()) + // Background compaction can delete a file between the read_dir + // listing and the metadata() call; skip vanished files. + .filter_map(|entry| entry.metadata().ok()) + .map(|metadata| metadata.len()) .sum() } From 7d673775f8543d85bd57e06469ab50120eb357ce Mon Sep 17 00:00:00 2001 From: Quantum Explorer Date: Fri, 14 Aug 2026 21:36:25 +0700 Subject: [PATCH 2/2] fix(tests): only tolerate NotFound metadata errors, panic on others Addresses CodeRabbit review: skipping every metadata error could silently undercount WAL/SST sizes on permission or filesystem errors. Co-Authored-By: Claude Fable 5 --- grovedb/src/tests/test_compaction_sizes.rs | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/grovedb/src/tests/test_compaction_sizes.rs b/grovedb/src/tests/test_compaction_sizes.rs index e10d47f3f..722d64395 100644 --- a/grovedb/src/tests/test_compaction_sizes.rs +++ b/grovedb/src/tests/test_compaction_sizes.rs @@ -23,7 +23,14 @@ mod tests { .filter(|entry| entry.path().extension().is_some_and(|ext| ext == extension)) // Background compaction can delete a file between the read_dir // listing and the metadata() call; skip vanished files. - .filter_map(|entry| entry.metadata().ok()) + .filter_map(|entry| match entry.metadata() { + Ok(metadata) => Some(metadata), + Err(error) if error.kind() == std::io::ErrorKind::NotFound => None, + Err(error) => panic!( + "cannot read metadata for {}: {error}", + entry.path().display() + ), + }) .map(|metadata| metadata.len()) .sum() }