From 4dd5eff0df44a68a7842137b6b4d5ec5eedfddb5 Mon Sep 17 00:00:00 2001 From: Quantum Explorer Date: Thu, 27 Aug 2026 14:06:16 +0200 Subject: [PATCH] fix(l10n): ship Localizable.stringsdict for every locale the app bundles MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Localizable.stringsdict PBXVariantGroup had only four children — en, sk, cs, uk — so `find -name '*.stringsdict'` returned 4 even though all 43 catalogs exist on disk and are actively maintained (#945 added 15 plurals, #1076 added `%d words`). Every pluralised string therefore fell back to English in the other locales. `%d words` is the clearest case: it lives only in stringsdict and in no `.strings` catalog, so the 12/24 recovery-phrase-length picker rendered "12 words / 24 words" in English on a Russian device. Add the 18 remaining locales the app actually ships (bg de el es fr id it ja ko nl pl pt ru th tr vi zh-Hans zh-Hant-TW) as children of the variant group. Both the dashwallet and dashpay targets already reference that one group via build files 2ADC722923B5547000D9DD37 and C9D2C91C2A320AA000D15901, so no build-phase change is needed. Bundled stringsdict count: 4 -> 22, one for each shipping locale. Note: 21 further locales (ar ca da eo et fa fi fil hr hu mk ms nb ro sl sl_SI sq sr sv zh zh_TW) have complete translations on disk but are absent from knownRegions and from the Localizable.strings group, so they ship nothing at all today. Wiring those up adds 21 new advertised languages (including RTL) and needs a product decision on the sl/sl_SI, zh/zh-Hans and zh_TW/zh-Hant-TW duplicates — tracked separately, deliberately out of scope here. Co-Authored-By: Claude Opus 5 --- DashWallet.xcodeproj/project.pbxproj | 36 ++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/DashWallet.xcodeproj/project.pbxproj b/DashWallet.xcodeproj/project.pbxproj index d54ece2141..ddad6deb6a 100644 --- a/DashWallet.xcodeproj/project.pbxproj +++ b/DashWallet.xcodeproj/project.pbxproj @@ -2720,6 +2720,24 @@ 47A5145F2848F75B005A8E3E /* TxDetailViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TxDetailViewController.swift; sourceTree = ""; }; 47A514612848FEAD005A8E3E /* Tx.storyboard */ = {isa = PBXFileReference; lastKnownFileType = file.storyboard; path = Tx.storyboard; sourceTree = ""; }; 47A5146328491C60005A8E3E /* TxDetailCells.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = TxDetailCells.swift; sourceTree = ""; }; + 51D1C700000D10CA1E000000 /* fr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = fr; path = fr.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000001 /* ja */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = ja; path = ja.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000002 /* ko */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = ko; path = ko.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000003 /* nl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = nl; path = nl.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000004 /* de */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = de; path = de.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000005 /* zh-Hans */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = "zh-Hans"; path = "zh-Hans.lproj/Localizable.stringsdict"; sourceTree = ""; }; + 51D1C700000D10CA1E000006 /* es */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = es; path = es.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000007 /* it */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = it; path = it.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000008 /* tr */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = tr; path = tr.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000009 /* pl */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = pl; path = pl.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E00000A /* ru */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = ru; path = ru.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E00000B /* el */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = el; path = el.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E00000C /* pt */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = pt; path = pt.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E00000D /* bg */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = bg; path = bg.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E00000E /* vi */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = vi; path = vi.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E00000F /* th */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = th; path = th.lproj/Localizable.stringsdict; sourceTree = ""; }; + 51D1C700000D10CA1E000010 /* zh-Hant-TW */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = "zh-Hant-TW"; path = "zh-Hant-TW.lproj/Localizable.stringsdict"; sourceTree = ""; }; + 51D1C700000D10CA1E000011 /* id */ = {isa = PBXFileReference; lastKnownFileType = text.plist.stringsdict; name = id; path = id.lproj/Localizable.stringsdict; sourceTree = ""; }; A1C0DE0000000000000BADA1 /* TxDetailContactViews.swift */ = {isa = PBXFileReference; includeInIndex = 1; lastKnownFileType = sourcecode.swift; path = TxDetailContactViews.swift; sourceTree = ""; }; 47AC8412297822E000BD1B49 /* SpecifyAmountViewController.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = SpecifyAmountViewController.swift; sourceTree = ""; }; 47AE8B9428BFACA100490F5E /* ExploreDash.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = ExploreDash.swift; sourceTree = ""; }; @@ -11423,6 +11441,24 @@ 2A8E79B9240676D400AA7C3D /* sk */, 2A8E79BD2406772900AA7C3D /* cs */, 477A963C292BA4B90013605B /* uk */, + 51D1C700000D10CA1E000000 /* fr */, + 51D1C700000D10CA1E000001 /* ja */, + 51D1C700000D10CA1E000002 /* ko */, + 51D1C700000D10CA1E000003 /* nl */, + 51D1C700000D10CA1E000004 /* de */, + 51D1C700000D10CA1E000005 /* zh-Hans */, + 51D1C700000D10CA1E000006 /* es */, + 51D1C700000D10CA1E000007 /* it */, + 51D1C700000D10CA1E000008 /* tr */, + 51D1C700000D10CA1E000009 /* pl */, + 51D1C700000D10CA1E00000A /* ru */, + 51D1C700000D10CA1E00000B /* el */, + 51D1C700000D10CA1E00000C /* pt */, + 51D1C700000D10CA1E00000D /* bg */, + 51D1C700000D10CA1E00000E /* vi */, + 51D1C700000D10CA1E00000F /* th */, + 51D1C700000D10CA1E000010 /* zh-Hant-TW */, + 51D1C700000D10CA1E000011 /* id */, ); name = Localizable.stringsdict; sourceTree = "";