From d6902fa29c9d44d1449e078c9a53b4ac1240e373 Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Mon, 16 Oct 2023 13:29:06 +0100 Subject: [PATCH 1/9] Merge bitcoin-core/gui#765: Fix wallet list hover crash on shutdown 8b6470a90652fcffc45b8d7998af7c8ad6251332 gui: disable top bar menu actions during shutdown (furszy) 7066e8996d0ac090535cc97cdcb54a219986460f gui: provide wallet controller context to wallet actions (furszy) Pull request description: Small follow-up to #751. Fixes another crash cause during shutdown. Which occurs when the user hovers over the wallets list. Future Note: This surely happen in other places as well, we should re-work the way we connect signals. Register lambas without any precaution can leave dangling pointers. ACKs for top commit: hebasto: ACK 8b6470a90652fcffc45b8d7998af7c8ad6251332, I've tested each commit separately on macOS Sonoma 14.0 (Apple M1). Tree-SHA512: 6fbd1bcd6717a8c1633beb9371463ed22422f929cccf9b791ee292c5364134c501e099329cf77a06b74a84c64c1c3d22539199ec49ccd74b3950036316c0dab3 Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> (cherry picked from commit eefd3ace71de5a38d472ef2fb5f436b41de14e8d) --- src/qt/bitcoingui.cpp | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp index 0ad815bd8bcf..6b963ba49624 100644 --- a/src/qt/bitcoingui.cpp +++ b/src/qt/bitcoingui.cpp @@ -557,7 +557,7 @@ void BitcoinGUI::createActions() connect(usedSendingAddressesAction, &QAction::triggered, walletFrame, &WalletFrame::usedSendingAddresses); connect(usedReceivingAddressesAction, &QAction::triggered, walletFrame, &WalletFrame::usedReceivingAddresses); connect(openAction, &QAction::triggered, this, &BitcoinGUI::openClicked); - connect(m_open_wallet_menu, &QMenu::aboutToShow, [this] { + connect(m_open_wallet_menu, &QMenu::aboutToShow, m_wallet_controller, [this] { m_open_wallet_menu->clear(); for (const std::pair& i : m_wallet_controller->listWalletDir()) { const std::string& path = i.first; @@ -573,7 +573,7 @@ void BitcoinGUI::createActions() continue; } - connect(action, &QAction::triggered, [this, path] { + connect(action, &QAction::triggered, m_wallet_controller, [this, path] { auto activity = new OpenWalletActivity(m_wallet_controller, this); connect(activity, &OpenWalletActivity::opened, this, &BitcoinGUI::setCurrentWallet, Qt::QueuedConnection); connect(activity, &OpenWalletActivity::opened, rpcConsole, &RPCConsole::setCurrentWallet, Qt::QueuedConnection); @@ -585,7 +585,7 @@ void BitcoinGUI::createActions() action->setEnabled(false); } }); - connect(m_restore_wallet_action, &QAction::triggered, [this] { + connect(m_restore_wallet_action, &QAction::triggered, m_wallet_controller, [this] { //: Name of the wallet data file format. QString name_data_file = tr("Wallet Data"); @@ -611,19 +611,19 @@ void BitcoinGUI::createActions() auto backup_file_path = fs::PathFromString(backup_file.toStdString()); activity->restore(backup_file_path, wallet_name.toStdString()); }); - connect(m_close_wallet_action, &QAction::triggered, [this] { + connect(m_close_wallet_action, &QAction::triggered, m_wallet_controller, [this] { m_wallet_controller->closeWallet(walletFrame->currentWalletModel(), this); }); - connect(m_create_wallet_action, &QAction::triggered, [this] { + connect(m_create_wallet_action, &QAction::triggered, m_wallet_controller, [this] { auto activity = new CreateWalletActivity(m_wallet_controller, this); connect(activity, &CreateWalletActivity::created, this, &BitcoinGUI::setCurrentWallet); connect(activity, &CreateWalletActivity::created, rpcConsole, &RPCConsole::setCurrentWallet); activity->create(); }); - connect(m_close_all_wallets_action, &QAction::triggered, [this] { + connect(m_close_all_wallets_action, &QAction::triggered, m_wallet_controller, [this] { m_wallet_controller->closeAllWallets(this); }); - connect(m_migrate_wallet_action, &QAction::triggered, [this] { + connect(m_migrate_wallet_action, &QAction::triggered, m_wallet_controller, [this] { auto activity = new MigrateWalletActivity(m_wallet_controller, this); connect(activity, &MigrateWalletActivity::migrated, this, &BitcoinGUI::setCurrentWallet); activity->migrate(walletFrame->currentWalletModel()); @@ -941,7 +941,8 @@ void BitcoinGUI::setClientModel(ClientModel *_clientModel, interfaces::BlockAndH } } } else { - if(trayIconMenu) + // Shutdown requested, disable menus + if (trayIconMenu) { // Disable context menu on tray icon trayIconMenu->clear(); @@ -963,6 +964,8 @@ void BitcoinGUI::setClientModel(ClientModel *_clientModel, interfaces::BlockAndH dockIconMenu->clear(); } #endif + // Disable top bar menu actions + appMenuBar->clear(); } updateCoinJoinVisibility(); From 578b914223fec53a4d42665fa8ae32aa7b8663eb Mon Sep 17 00:00:00 2001 From: Konstantin Akimov Date: Mon, 23 Oct 2023 15:09:52 +0100 Subject: [PATCH 2/9] Merge bitcoin-core/gui#770: Revert "gui: provide wallet controller context to wallet actions" f09bfab4aff04a9cc1ea157b94bfdae19f3465b1 Revert "gui: provide wallet controller context to wallet actions" (Hennadii Stepanov) Pull request description: The commit 7066e8996d0ac090535cc97cdcb54a219986460f from https://github.com/bitcoin-core/gui/pull/765 breaks "Open Wallet", "Close Wallet" and "Close All Wallets" items in the File menu (at least on Ubuntu 23.10 + Wayland). Reverting it to avoid this regression in the 26.0 release. ACKs for top commit: furszy: ACK f09bfab4 for including it in v26. jarolrod: ACK f09bfab4aff04a9cc1ea157b94bfdae19f3465b1 Tree-SHA512: fedc621c8e9bf84a263b0c28da53225febe0267d0123830a6192297f38e40726e1613e003b634215e7d16791ba6eab52fb4baab3da9637f6660b6ae1ae98462b Co-authored-by: Hennadii Stepanov <32963518+hebasto@users.noreply.github.com> (cherry picked from commit 89531800f46c9ae4b0d01efebca88347a31bf37a) --- src/qt/bitcoingui.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/qt/bitcoingui.cpp b/src/qt/bitcoingui.cpp index 6b963ba49624..85148671647b 100644 --- a/src/qt/bitcoingui.cpp +++ b/src/qt/bitcoingui.cpp @@ -557,7 +557,7 @@ void BitcoinGUI::createActions() connect(usedSendingAddressesAction, &QAction::triggered, walletFrame, &WalletFrame::usedSendingAddresses); connect(usedReceivingAddressesAction, &QAction::triggered, walletFrame, &WalletFrame::usedReceivingAddresses); connect(openAction, &QAction::triggered, this, &BitcoinGUI::openClicked); - connect(m_open_wallet_menu, &QMenu::aboutToShow, m_wallet_controller, [this] { + connect(m_open_wallet_menu, &QMenu::aboutToShow, [this] { m_open_wallet_menu->clear(); for (const std::pair& i : m_wallet_controller->listWalletDir()) { const std::string& path = i.first; @@ -573,7 +573,7 @@ void BitcoinGUI::createActions() continue; } - connect(action, &QAction::triggered, m_wallet_controller, [this, path] { + connect(action, &QAction::triggered, [this, path] { auto activity = new OpenWalletActivity(m_wallet_controller, this); connect(activity, &OpenWalletActivity::opened, this, &BitcoinGUI::setCurrentWallet, Qt::QueuedConnection); connect(activity, &OpenWalletActivity::opened, rpcConsole, &RPCConsole::setCurrentWallet, Qt::QueuedConnection); @@ -585,7 +585,7 @@ void BitcoinGUI::createActions() action->setEnabled(false); } }); - connect(m_restore_wallet_action, &QAction::triggered, m_wallet_controller, [this] { + connect(m_restore_wallet_action, &QAction::triggered, [this] { //: Name of the wallet data file format. QString name_data_file = tr("Wallet Data"); @@ -611,19 +611,19 @@ void BitcoinGUI::createActions() auto backup_file_path = fs::PathFromString(backup_file.toStdString()); activity->restore(backup_file_path, wallet_name.toStdString()); }); - connect(m_close_wallet_action, &QAction::triggered, m_wallet_controller, [this] { + connect(m_close_wallet_action, &QAction::triggered, [this] { m_wallet_controller->closeWallet(walletFrame->currentWalletModel(), this); }); - connect(m_create_wallet_action, &QAction::triggered, m_wallet_controller, [this] { + connect(m_create_wallet_action, &QAction::triggered, [this] { auto activity = new CreateWalletActivity(m_wallet_controller, this); connect(activity, &CreateWalletActivity::created, this, &BitcoinGUI::setCurrentWallet); connect(activity, &CreateWalletActivity::created, rpcConsole, &RPCConsole::setCurrentWallet); activity->create(); }); - connect(m_close_all_wallets_action, &QAction::triggered, m_wallet_controller, [this] { + connect(m_close_all_wallets_action, &QAction::triggered, [this] { m_wallet_controller->closeAllWallets(this); }); - connect(m_migrate_wallet_action, &QAction::triggered, m_wallet_controller, [this] { + connect(m_migrate_wallet_action, &QAction::triggered, [this] { auto activity = new MigrateWalletActivity(m_wallet_controller, this); connect(activity, &MigrateWalletActivity::migrated, this, &BitcoinGUI::setCurrentWallet); activity->migrate(walletFrame->currentWalletModel()); From 28d571141602ac03e673331f053553a655e282b3 Mon Sep 17 00:00:00 2001 From: merge-script Date: Wed, 11 Nov 2026 21:54:50 -0600 Subject: [PATCH 3/9] Merge dashpay/dash#8120: fix(utils): accept -printcrashinfo in dash-cli and dash-tx MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 11c2f73d88fe3babc1f4b0276eec9d2c51952a3c fix(cli): accept -printcrashinfo in dash-cli and dash-tx (pasta) Pull request description: ## Issue being fixed or feature implemented Crash handlers suggest rerunning the executable with `-printcrashinfo`, but dash-cli and dash-tx reject that argument. Their existing decoder paths also return 1 after printing, which signals failure. ## What was done? Register the hidden argument in both tools and return `EXIT_SUCCESS` after decoding. Add coverage to the existing CLI functional test and dash-tx utility cases. ## How Has This Been Tested? On macOS arm64 with a debug/werror build: - On unchanged develop, the new utility case fails because dash-tx rejects `-printcrashinfo=invalid` and exits 1. Both descriptor and legacy variants of `interface_bitcoin_cli.py` also fail at the new check because dash-cli rejects the option. - `make -j4`; `src/test/test_dash --run_test=getarg_tests`; `python test/util/test_runner.py -v`. - RAM-disk functional runner: `-j1 --timeout-factor=2 interface_bitcoin_cli.py`, covering both wallet variants. The CLI check requires exit 0 and the expected decoder error text for malformed crash data. - Repository-enabled Python flake8 checks, whitespace lint and `git diff --check`. The Python lint mypy step reports three existing errors in unchanged files with mypy 2.4.1. ## Breaking Changes None. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: f4e6dcfe395c384a2ecc4e57daaeb9c442ac97b1224af621330a93538183a22743897783db08f1b12a0fdda4e61d8f4207c4db48c42bd93749a31e5ce4273ce4 (cherry picked from commit 5c9aa9fcf365029d51e1ccf264469629da15d1ec) --- src/bitcoin-cli.cpp | 3 ++- src/bitcoin-tx.cpp | 3 ++- test/functional/interface_bitcoin_cli.py | 3 +++ test/util/data/bitcoin-util-test.json | 5 +++++ 4 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/bitcoin-cli.cpp b/src/bitcoin-cli.cpp index 24a7f446ece6..be4b86816f3c 100644 --- a/src/bitcoin-cli.cpp +++ b/src/bitcoin-cli.cpp @@ -102,6 +102,7 @@ static void SetupCliArgs(ArgsManager& argsman) argsman.AddArg("-stdin", "Read extra arguments from standard input, one per line until EOF/Ctrl-D (recommended for sensitive information such as passphrases). When combined with -stdinrpcpass, the first line from standard input is used for the RPC password.", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS); argsman.AddArg("-stdinrpcpass", "Read RPC password from standard input as a single line. When combined with -stdin, the first line from standard input is used for the RPC password. When combined with -stdinwalletpassphrase, -stdinrpcpass consumes the first line, and -stdinwalletpassphrase consumes the second.", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS); argsman.AddArg("-stdinwalletpassphrase", "Read wallet passphrase from standard input as a single line. When combined with -stdin, the first line from standard input is used for the wallet passphrase.", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS); + argsman.AddHiddenArgs({"-printcrashinfo"}); SetupChainParamsBaseOptions(argsman); } @@ -144,7 +145,7 @@ static int AppInitRPC(int argc, char* argv[]) if (gArgs.IsArgSet("-printcrashinfo")) { std::cout << GetCrashInfoStrFromSerializedStr(gArgs.GetArg("-printcrashinfo", "")) << std::endl; - return true; + return EXIT_SUCCESS; } if (argc < 2 || HelpRequested(gArgs) || gArgs.IsArgSet("-version")) { diff --git a/src/bitcoin-tx.cpp b/src/bitcoin-tx.cpp index e61539db3383..f8f530e10b24 100644 --- a/src/bitcoin-tx.cpp +++ b/src/bitcoin-tx.cpp @@ -47,6 +47,7 @@ static void SetupBitcoinTxArgs(ArgsManager &argsman) argsman.AddArg("-create", "Create new, empty TX.", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS); argsman.AddArg("-json", "Select JSON output", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS); argsman.AddArg("-txid", "Output only the hex-encoded transaction id of the resultant transaction.", ArgsManager::ALLOW_ANY, OptionsCategory::OPTIONS); + argsman.AddHiddenArgs({"-printcrashinfo"}); SetupChainParamsBaseOptions(argsman); argsman.AddArg("delin=N", "Delete input N from TX", ArgsManager::ALLOW_ANY, OptionsCategory::COMMANDS); @@ -87,7 +88,7 @@ static int AppInitRawTx(int argc, char* argv[]) if (gArgs.IsArgSet("-printcrashinfo")) { std::cout << GetCrashInfoStrFromSerializedStr(gArgs.GetArg("-printcrashinfo", "")) << std::endl; - return true; + return EXIT_SUCCESS; } // Check for chain settings (Params() calls are only valid after this clause) diff --git a/test/functional/interface_bitcoin_cli.py b/test/functional/interface_bitcoin_cli.py index c1afe72b50b7..32dd0b083ddd 100755 --- a/test/functional/interface_bitcoin_cli.py +++ b/test/functional/interface_bitcoin_cli.py @@ -78,6 +78,9 @@ def skip_test_if_missing_module(self): def run_test(self): """Main test logic""" + self.log.info("Test -printcrashinfo") + assert_equal(self.nodes[0].cli('-printcrashinfo=invalid').send_cli(), 'Error while deserializing crash info') + self.generate(self.nodes[0], BLOCKS) self.log.info("Compare responses from getblockchaininfo RPC and `dash-cli getblockchaininfo`") diff --git a/test/util/data/bitcoin-util-test.json b/test/util/data/bitcoin-util-test.json index 404ad247e66a..feddb6252c9a 100644 --- a/test/util/data/bitcoin-util-test.json +++ b/test/util/data/bitcoin-util-test.json @@ -1,4 +1,9 @@ [ + { "exec": "./dash-tx", + "args": ["-printcrashinfo=invalid"], + "return_code": 0, + "description": "Print crash information and exit successfully" + }, { "exec": "./dash-util", "args": ["foo"], "return_code": 1, From 484ec63af3c4d2afeb15e23faaca8b0e477ed96c Mon Sep 17 00:00:00 2001 From: merge-script Date: Wed, 11 Nov 2026 22:04:46 -0600 Subject: [PATCH 4/9] Merge dashpay/dash#8119: fix(stats): wrong inputValue gauge, counter data race, and null-tip crash MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 419cbb699718648827b98355c20a9e67354f4c70 fix(stats): wrong inputValue gauge, counter data race, and null-tip crash (pasta) Pull request description: ## Issue being fixed or feature implemented The `transactions.inputValue` metric subtracts modified fees from outputs, producing an incorrect input total. Immediate stats sends can also race while updating plain counters, and periodic collection can dereference an absent chain tip during startup or reindexing. Transaction and block statistics additionally perform unnecessary work when collection is disabled. ## What was done? Compute input value as outputs plus the actual base fee, reuse the mempool entry's sigop count, and gate transaction and ConnectTip statistics on an active client. Make RawSender success/failure counters atomic and load them explicitly for logging. Guard the periodic collector's tip before flushing or collecting UTXO statistics, and protect its chain-state calculations with `cs_main`. The existing DisconnectTip statistics behavior is unchanged. ## How Has This Been Tested? On macOS arm64, with a debug/werror build and functional-test datadirs on a RAM disk: - Extended the existing `feature_stats.py` connection scenario to reindex with periodic statistics and check an emitted difficulty metric, then spend a known MiniWallet input after fee prioritization and compare the actual UDP inputValue packet with its value. On unchanged develop, the packet is `transactions.inputValue:49999948000|c` instead of `transactions.inputValue:50000000000|c`. - `make -j4`; `src/test/test_dash --run_test=mempool_tests,validation_tests`. - RAM-disk functional runner: `-j1 --timeout-factor=2 feature_stats.py`. - Repository-enabled Python flake8 checks, whitespace lint and `git diff --check`. The Python lint mypy step reports three existing errors in unchanged files with mypy 2.4.1. The null-tip startup condition is not deterministically reproduced; reindex with periodic statistics provides smoke coverage. Counter safety and disabled-client guards were checked by source inspection; no TSAN run was performed. ## Breaking Changes None. The emitted inputValue metric now reflects the actual spent input value. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation - [ ] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: 72e0fff72cee1bb7177184f3ce5cfce86e7a4858d71f5d13122e70584b20e2c1f6b33163a01f037f354be809d040d33ca2fd410a9f81d55ee2714f68c7be360c (cherry picked from commit f9c3e7d579c9207e27d3c66cc58b5263965ec61e) --- src/init.cpp | 89 +++++++++++++++++--------------- src/stats/rawsender.cpp | 2 +- src/stats/rawsender.h | 5 +- src/validation.cpp | 36 +++++++------ test/functional/feature_stats.py | 14 ++++- 5 files changed, 81 insertions(+), 65 deletions(-) diff --git a/src/init.cpp b/src/init.cpp index cb6620cbcf7c..0aae2c198c64 100644 --- a/src/init.cpp +++ b/src/init.cpp @@ -928,50 +928,53 @@ static void PeriodicStats(NodeContext& node) ChainstateManager& chainman = *Assert(node.chainman); const CTxMemPool& mempool = *Assert(node.mempool); const llmq::CInstantSendManager& isman = *Assert(node.isman); - chainman.ActiveChainstate().ForceFlushStateToDisk(); - const auto maybe_stats = WITH_LOCK(::cs_main, return GetUTXOStats(&chainman.ActiveChainstate().CoinsDB(), chainman.m_blockman, /*hash_type=*/CoinStatsHashType::NONE, node.rpc_interruption_point, chainman.ActiveChain().Tip(), /*index_requested=*/true)); - if (maybe_stats.has_value()) { - ::g_stats_client->gauge("utxoset.tx", maybe_stats->nTransactions, 1.0f); - ::g_stats_client->gauge("utxoset.txOutputs", maybe_stats->nTransactionOutputs, 1.0f); - ::g_stats_client->gauge("utxoset.dbSizeBytes", maybe_stats->nDiskSize, 1.0f); - ::g_stats_client->gauge("utxoset.blockHeight", maybe_stats->nHeight, 1.0f); - if (maybe_stats->total_amount.has_value()) { - ::g_stats_client->gauge("utxoset.totalAmount", (double)maybe_stats->total_amount.value() / (double)COIN, 1.0f); + { + LOCK(::cs_main); + const CBlockIndex* tip = chainman.ActiveChain().Tip(); + if (!tip) return; + chainman.ActiveChainstate().ForceFlushStateToDisk(); + const auto maybe_stats = GetUTXOStats(&chainman.ActiveChainstate().CoinsDB(), chainman.m_blockman, /*hash_type=*/CoinStatsHashType::NONE, node.rpc_interruption_point, chainman.ActiveChain().Tip(), /*index_requested=*/true); + if (maybe_stats.has_value()) { + ::g_stats_client->gauge("utxoset.tx", maybe_stats->nTransactions, 1.0f); + ::g_stats_client->gauge("utxoset.txOutputs", maybe_stats->nTransactionOutputs, 1.0f); + ::g_stats_client->gauge("utxoset.dbSizeBytes", maybe_stats->nDiskSize, 1.0f); + ::g_stats_client->gauge("utxoset.blockHeight", maybe_stats->nHeight, 1.0f); + if (maybe_stats->total_amount.has_value()) { + ::g_stats_client->gauge("utxoset.totalAmount", (double)maybe_stats->total_amount.value() / (double)COIN, 1.0f); + } + } else { + // something went wrong + LogPrintf("%s: GetUTXOStats failed\n", __func__); + } + + double nNetworkHashPS = [&]() { + // Short version of GetNetworkHashPS(120, -1); + const CBlockIndex* pindex = tip; + int64_t minTime = pindex->GetBlockTime(); + int64_t maxTime = minTime; + for (int i = 0; i < 120 && pindex->pprev != nullptr; i++) { + pindex = pindex->pprev; + int64_t time = pindex->GetBlockTime(); + minTime = std::min(time, minTime); + maxTime = std::max(time, maxTime); + } + if (minTime == maxTime) return 0.0; + arith_uint256 workDiff = tip->nChainWork - pindex->nChainWork; + int64_t timeDiff = maxTime - minTime; + return workDiff.getdouble() / timeDiff; + }(); + + if (nNetworkHashPS > 0.0) { + ::g_stats_client->gaugeDouble("network.hashesPerSecond", nNetworkHashPS); + ::g_stats_client->gaugeDouble("network.terahashesPerSecond", nNetworkHashPS / 1e12); + ::g_stats_client->gaugeDouble("network.petahashesPerSecond", nNetworkHashPS / 1e15); + ::g_stats_client->gaugeDouble("network.exahashesPerSecond", nNetworkHashPS / 1e18); } - } else { - // something went wrong - LogPrintf("%s: GetUTXOStats failed\n", __func__); - } - - CBlockIndex *tip = WITH_LOCK(::cs_main, return chainman.ActiveChain().Tip()); - double nNetworkHashPS = [&]() { - // Short version of GetNetworkHashPS(120, -1); - CBlockIndex *pindex = tip; - int64_t minTime = pindex->GetBlockTime(); - int64_t maxTime = minTime; - for (int i = 0; i < 120 && pindex->pprev != nullptr; i++) { - pindex = pindex->pprev; - int64_t time = pindex->GetBlockTime(); - minTime = std::min(time, minTime); - maxTime = std::max(time, maxTime); - } - if (minTime == maxTime) return 0.0; - arith_uint256 workDiff = tip->nChainWork - pindex->nChainWork; - int64_t timeDiff = maxTime - minTime; - return workDiff.getdouble() / timeDiff; - }(); - - if (nNetworkHashPS > 0.0) { - ::g_stats_client->gaugeDouble("network.hashesPerSecond", nNetworkHashPS); - ::g_stats_client->gaugeDouble("network.terahashesPerSecond", nNetworkHashPS / 1e12); - ::g_stats_client->gaugeDouble("network.petahashesPerSecond", nNetworkHashPS / 1e15); - ::g_stats_client->gaugeDouble("network.exahashesPerSecond", nNetworkHashPS / 1e18); - } - // No need for cs_main, we never use null tip here - ::g_stats_client->gaugeDouble("network.difficulty", (double)GetDifficulty(tip)); - - ::g_stats_client->gauge("transactions.txCacheSize", WITH_LOCK(cs_main, return chainman.ActiveChainstate().CoinsTip().GetCacheSize()), 1.0f); - ::g_stats_client->gauge("transactions.totalTransactions", tip->nChainTx, 1.0f); + ::g_stats_client->gaugeDouble("network.difficulty", (double)GetDifficulty(tip)); + + ::g_stats_client->gauge("transactions.txCacheSize", chainman.ActiveChainstate().CoinsTip().GetCacheSize(), 1.0f); + ::g_stats_client->gauge("transactions.totalTransactions", tip->nChainTx, 1.0f); + } { LOCK(mempool.cs); diff --git a/src/stats/rawsender.cpp b/src/stats/rawsender.cpp index b0e7fc3c7df7..e69e9d3ca1eb 100644 --- a/src/stats/rawsender.cpp +++ b/src/stats/rawsender.cpp @@ -65,7 +65,7 @@ RawSender::~RawSender() QueueFlush(); LogPrintf("Stopped RawSender instance sending messages to %s:%d. %d successes, %d failures.\n", - m_host, m_port, m_successes, m_failures); + m_host, m_port, m_successes.load(), m_failures.load()); } std::optional RawSender::Send(const RawMessage& msg) diff --git a/src/stats/rawsender.h b/src/stats/rawsender.h index be332ff14efb..1f13eb6bd9ae 100644 --- a/src/stats/rawsender.h +++ b/src/stats/rawsender.h @@ -11,6 +11,7 @@ #include #include +#include #include #include #include @@ -111,9 +112,9 @@ class RawSender const uint64_t m_interval_ms; /* Number of messages sent */ - uint64_t m_successes{0}; + std::atomic m_successes{0}; /* Number of messages not sent */ - uint64_t m_failures{0}; + std::atomic m_failures{0}; }; #endif // BITCOIN_STATS_RAWSENDER_H diff --git a/src/validation.cpp b/src/validation.cpp index 7813be6921b9..45894e6b68cd 100644 --- a/src/validation.cpp +++ b/src/validation.cpp @@ -1261,14 +1261,14 @@ bool MemPoolAccept::Finalize(const ATMPArgs& args, Workspace& ws) // Store transaction in memory m_pool.addUnchecked(*entry, ws.m_ancestors, validForFeeEstimation); - CAmount nValueOut = tx.GetValueOut(); - unsigned int nSigOps = GetTransactionSigOpCount(tx, m_view, STANDARD_SCRIPT_VERIFY_FLAGS); - - ::g_stats_client->count("transactions.sizeBytes", entry->GetTxSize(), 1.0f); - ::g_stats_client->count("transactions.fees", ws.m_modified_fees, 1.0f); - ::g_stats_client->count("transactions.inputValue", nValueOut - ws.m_modified_fees, 1.0f); - ::g_stats_client->count("transactions.outputValue", nValueOut, 1.0f); - ::g_stats_client->count("transactions.sigOps", nSigOps, 1.0f); + if (::g_stats_client->active()) { + const CAmount nValueOut = tx.GetValueOut(); + ::g_stats_client->count("transactions.sizeBytes", entry->GetTxSize(), 1.0f); + ::g_stats_client->count("transactions.fees", ws.m_modified_fees, 1.0f); + ::g_stats_client->count("transactions.inputValue", nValueOut + ws.m_base_fees, 1.0f); + ::g_stats_client->count("transactions.outputValue", nValueOut, 1.0f); + ::g_stats_client->count("transactions.sigOps", entry->GetSigOpCount(), 1.0f); + } // Add memory address index m_pool.addAddressIndex(*entry, m_view); @@ -3501,16 +3501,18 @@ bool Chainstate::ConnectTip(BlockValidationState& state, CBlockIndex* pindexNew, Ticks(time_total), Ticks(time_total) / num_blocks_total); - unsigned int nSigOps = 0; - for (const auto& tx : blockConnecting.vtx) { - nSigOps += GetLegacySigOpCount(*tx); + if (::g_stats_client->active()) { + unsigned int nSigOps = 0; + for (const auto& tx : blockConnecting.vtx) { + nSigOps += GetLegacySigOpCount(*tx); + } + ::g_stats_client->timing("ConnectTip_ms", Ticks(time_6 - time_1), 1.0f); + ::g_stats_client->gauge("blocks.tip.SizeBytes", ::GetSerializeSize(blockConnecting, PROTOCOL_VERSION), 1.0f); + ::g_stats_client->gauge("blocks.tip.Height", m_chain.Height(), 1.0f); + ::g_stats_client->gauge("blocks.tip.Version", blockConnecting.nVersion, 1.0f); + ::g_stats_client->gauge("blocks.tip.NumTransactions", blockConnecting.vtx.size(), 1.0f); + ::g_stats_client->gauge("blocks.tip.SigOps", nSigOps, 1.0f); } - ::g_stats_client->timing("ConnectTip_ms", Ticks(time_6 - time_1), 1.0f); - ::g_stats_client->gauge("blocks.tip.SizeBytes", ::GetSerializeSize(blockConnecting, PROTOCOL_VERSION), 1.0f); - ::g_stats_client->gauge("blocks.tip.Height", m_chain.Height(), 1.0f); - ::g_stats_client->gauge("blocks.tip.Version", blockConnecting.nVersion, 1.0f); - ::g_stats_client->gauge("blocks.tip.NumTransactions", blockConnecting.vtx.size(), 1.0f); - ::g_stats_client->gauge("blocks.tip.SigOps", nSigOps, 1.0f); // If we are the background validation chainstate, check to see if we are done // validating the snapshot (i.e. our tip has reached the snapshot's base block). diff --git a/test/functional/feature_stats.py b/test/functional/feature_stats.py index 64b4674b102c..7cafd7fb6a6c 100755 --- a/test/functional/feature_stats.py +++ b/test/functional/feature_stats.py @@ -10,8 +10,11 @@ import time import threading +from test_framework.messages import COIN from test_framework.netutil import test_ipv6_local from test_framework.test_framework import BitcoinTestFramework +from test_framework.util import assert_equal +from test_framework.wallet import MiniWallet from queue import Queue ONION_ADDR = "pg6mmjiyjmcrsslvykfwnntlaru7p5svn6y2ymmju6nubxndf4pscryd.onion" @@ -64,7 +67,7 @@ def assert_msg_received(self, expected_msg: str, timeout: int = 30): try: msg = self.queue.get(timeout=5) if expected_msg in msg: - return + return msg except queue.Empty: continue raise AssertionError(f"Did not receive message containing '{expected_msg}' within {timeout} seconds") @@ -133,8 +136,15 @@ def test_command_behavior(self): def test_conn(self, host: str): server = StatsServer(host, 8125) server.start() - self.restart_node(0, extra_args=[f'-statshost=udp://{host}', '-statsbatchsize=0', '-statsduration=0']) + self.restart_node(0, extra_args=[f'-statshost=udp://{host}', '-statsbatchsize=0', '-statsduration=0', '-statsperiod=5', '-reindex']) server.assert_msg_received("CheckBlock_us") + server.assert_msg_received("network.difficulty:") + wallet = MiniWallet(self.nodes[0]) + utxo = wallet.get_utxo() + tx = wallet.create_self_transfer(utxo_to_spend=utxo) + self.nodes[0].prioritisetransaction(tx["txid"], 1000) + wallet.sendrawtransaction(from_node=self.nodes[0], tx_hex=tx["hex"]) + assert_equal(server.assert_msg_received("transactions.inputValue:"), f"transactions.inputValue:{int(utxo['value'] * COIN)}|c") server.stop() if __name__ == '__main__': From 068529f7f7c04746d9cfe4470477bd323c55af5e Mon Sep 17 00:00:00 2001 From: merge-script Date: Wed, 11 Nov 2026 22:06:25 -0600 Subject: [PATCH 5/9] Merge dashpay/dash#8112: fix: answer govsync only to the requesting peer and index replayed orphan votes MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fe6664997a7db47d061c86407110e37ad70271f2 fix(governance): answer govsync only to the requesting peer and index replayed orphan votes (pasta) Pull request description: ## Issue being fixed or feature implemented A peer requesting governance sync broadcasts the response inventories to every relay peer. Votes accepted after their parent arrives are also missing from the vote-to-object index, so the node announces votes that it cannot serve on GETDATA and continues treating their hashes as unknown. ## What was done? Send object and vote sync inventories only to the requesting peer. Index accepted orphan votes against their stored parent object before relaying them, matching normal vote processing. Extend the existing governance functional test with fresh requester/bystander P2P peers for both object and vote sync. Extend the existing orphan-vote unit scenario to require hash lookup and serialization, then deserialize and validate the served vote. ## How Has This Been Tested? - Debug build with warnings treated as errors: `make -C src -j4 dashd test/test_dash`. - On unchanged develop (`34f990e8701e`), the updated orphan scenario failed both `HaveVoteForHash` and `SerializeVoteForHash`; the functional regression failed because the bystander received all three proposal inventories. - With the fixes, `./src/test/test_dash --run_test='governance*' --log_level=message` passed all 36 cases. - The full `feature_governance.py --descriptors` passed using the RAM-disk helper with `-j1 --timeout-factor=3`. An initial fixed-code attempt hit an occupied RPC port during startup; the successful run used an isolated port range. - Repository-selected Python lint, whitespace lint and `git diff --check` passed. Self-review covered pointer ownership, vote-index locking and inventory routing. ## Breaking Changes None. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation (not needed for these internal fixes) - [x] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: 74bea701ed517bd40462938615a330a18e9eefd540913c4ebeaed2bbfb970c24169613fbda87eaee9675b51220f7b1940010a935e60e3e010ac1f962a2742a4c (cherry picked from commit 1c08908ec52cd5295e5dbbf807882bce2d3d8129) --- src/governance/governance.cpp | 12 +++-- src/governance/governance.h | 2 +- src/governance/net_governance.cpp | 4 +- src/test/governance_vote_processing_tests.cpp | 15 ++++-- test/functional/feature_governance.py | 49 ++++++++++++++++++- 5 files changed, 68 insertions(+), 14 deletions(-) diff --git a/src/governance/governance.cpp b/src/governance/governance.cpp index 3ec521886f34..675d2ee8d5b2 100644 --- a/src/governance/governance.cpp +++ b/src/governance/governance.cpp @@ -277,12 +277,12 @@ bool CGovernanceManager::ProcessObject(const std::string& peer_str, const uint25 return true; } -void CGovernanceManager::CheckOrphanVotes(CGovernanceObject& govobj) +void CGovernanceManager::CheckOrphanVotes(const std::shared_ptr& govobj) { AssertLockHeld(cs_store); AssertLockNotHeld(cs_relay); - uint256 nHash = govobj.GetHash(); + uint256 nHash = Assert(govobj)->GetHash(); std::vector orphan_votes; cmmapOrphanVotes.GetAll(nHash, orphan_votes); @@ -296,8 +296,10 @@ void CGovernanceManager::CheckOrphanVotes(CGovernanceObject& govobj) CGovernanceException e; if (orphan_vote.expiration < now) { fRemove = true; - } else if (govobj.ProcessVote(m_mn_metaman, fRateChecksEnabled, tip_mn_list, vote, e)) { - RelayVote(vote); + } else if (govobj->ProcessVote(m_mn_metaman, fRateChecksEnabled, tip_mn_list, vote, e)) { + if (cmapVoteToObject.Insert(vote.GetHash(), govobj)) { + RelayVote(vote); + } fRemove = true; } if (fRemove) { @@ -371,7 +373,7 @@ void CGovernanceManager::AddGovernanceObjectInternal(CGovernanceObject& insert_o // WE MIGHT HAVE PENDING/ORPHAN VOTES FOR THIS OBJECT - CheckOrphanVotes(*govobj); + CheckOrphanVotes(govobj); // SEND NOTIFICATION TO SCRIPT/ZMQ GetMainSignals().NotifyGovernanceObject(std::make_shared(govobj->Object()), nHash.ToString()); diff --git a/src/governance/governance.h b/src/governance/governance.h index 481fc8875ebb..e4ba2e421be3 100644 --- a/src/governance/governance.h +++ b/src/governance/governance.h @@ -419,7 +419,7 @@ class CGovernanceManager : public GovernanceStore void InitOnLoad() EXCLUSIVE_LOCKS_REQUIRED(!cs_store); - void CheckOrphanVotes(CGovernanceObject& govobj) + void CheckOrphanVotes(const std::shared_ptr& govobj) EXCLUSIVE_LOCKS_REQUIRED(cs_store, !cs_relay); void RebuildIndexes() diff --git a/src/governance/net_governance.cpp b/src/governance/net_governance.cpp index 56d193d9ad62..1bd152512a0d 100644 --- a/src/governance/net_governance.cpp +++ b/src/governance/net_governance.cpp @@ -151,7 +151,7 @@ void NetGovernance::ProcessMessage(CNode& peer, const std::string& msg_type, CDa m_connman.PushMessage(&peer, msgMaker.Make(NetMsgType::SYNCSTATUSCOUNT, MASTERNODE_SYNC_GOVOBJ, static_cast(invs.size()))); for (const auto& inv : invs) { - m_peer_manager->PeerRelayInv(inv); + m_peer_manager->PeerPushInventory(peer.GetId(), inv); } } else { // Sync votes for a specific governance object @@ -163,7 +163,7 @@ void NetGovernance::ProcessMessage(CNode& peer, const std::string& msg_type, CDa m_connman.PushMessage(&peer, msgMaker.Make(NetMsgType::SYNCSTATUSCOUNT, MASTERNODE_SYNC_GOVOBJ_VOTE, static_cast(invs.size()))); for (const auto& inv : invs) { - m_peer_manager->PeerRelayInv(inv); + m_peer_manager->PeerPushInventory(peer.GetId(), inv); } } } diff --git a/src/test/governance_vote_processing_tests.cpp b/src/test/governance_vote_processing_tests.cpp index 1b87452778ff..d1ac437e7e76 100644 --- a/src/test/governance_vote_processing_tests.cpp +++ b/src/test/governance_vote_processing_tests.cpp @@ -28,6 +28,7 @@ #include #include #include +#include #include #include @@ -339,10 +340,16 @@ BOOST_AUTO_TEST_CASE(orphan_vote_is_cached_and_applied_when_parent_arrives) BOOST_CHECK_EQUAL(stored->GetAbsoluteYesCount(tip_mn_list(), VOTE_SIGNAL_FUNDING), 1); BOOST_CHECK_EQUAL(govman.GetCurrentVotes(parent_hash, mn_collateral).size(), 1U); BOOST_CHECK(govman.GetOrphanVoteObjectHashes().empty()); - // Known gap, pinned here so a fix has to update this test: CheckOrphanVotes() applies the - // vote to the object but never indexes it in cmapVoteToObject, so the vote inv it relays - // during the replay cannot be served to a peer that requests it. - BOOST_CHECK(!govman.HaveVoteForHash(vote.GetHash())); + BOOST_CHECK(govman.HaveVoteForHash(vote.GetHash())); + CDataStream serialized_vote{SER_NETWORK, PROTOCOL_VERSION}; + BOOST_CHECK(govman.SerializeVoteForHash(vote.GetHash(), serialized_vote)); + if (!serialized_vote.empty()) { + CGovernanceVote served_vote; + serialized_vote >> served_vote; + BOOST_CHECK_EQUAL(served_vote.GetHash(), vote.GetHash()); + BOOST_CHECK(served_vote.IsValid(tip_mn_list(), /*useVotingKey=*/true)); + BOOST_CHECK(serialized_vote.empty()); + } // A peer re-sending the same vote must not be punished for it. CGovernanceException replay_exception; diff --git a/test/functional/feature_governance.py b/test/functional/feature_governance.py index 6a6ff64beade..1bcde1f46f1d 100755 --- a/test/functional/feature_governance.py +++ b/test/functional/feature_governance.py @@ -5,8 +5,17 @@ """Tests around dash governance.""" import json - -from test_framework.messages import uint256_to_string +import struct + +from test_framework.messages import ( + MSG_GOVERNANCE_OBJECT, + MSG_GOVERNANCE_OBJECT_VOTE, + msg_generic, + ser_string, + ser_uint256, + uint256_to_string, +) +from test_framework.p2p import P2PInterface, p2p_lock from test_framework.test_framework import ( DashTestFramework, MasternodeInfo, @@ -16,6 +25,18 @@ GOVERNANCE_UPDATE_MIN = 60 * 60 # src/governance/object.h + +class GovernanceSyncPeer(P2PInterface): + def __init__(self): + super().__init__() + self.governance_invs = set() + + def on_inv(self, message): + for inv in message.inv: + if inv.type in (MSG_GOVERNANCE_OBJECT, MSG_GOVERNANCE_OBJECT_VOTE): + self.governance_invs.add((inv.type, inv.hash)) + + class DashGovernanceTest (DashTestFramework): def add_options(self, parser): self.add_wallet_options(parser) @@ -58,6 +79,28 @@ def check_superblock(self): assert_equal(payments_found, 2) + def check_govsync_is_peer_local(self): + node = self.nodes[0] + self.log.info("Governance sync inventories go only to the requesting peer") + # Flush ordinary announcements before connecting peers that have never seen these inventories. + self.bump_mocktime(1) + for object_hash, inv_type, expected_hashes in ( + (0, MSG_GOVERNANCE_OBJECT, {int(h, 16) for h in node.gobject("list")}), + (int(self.p0_hash, 16), MSG_GOVERNANCE_OBJECT_VOTE, + {int(h, 16) for h in node.gobject("getcurrentvotes", self.p0_hash)}), + ): + assert expected_hashes + requester = node.add_p2p_connection(GovernanceSyncPeer()) + bystander = node.add_p2p_connection(GovernanceSyncPeer()) + # A one-byte, all-zero bloom filter requests every vote and is distinct from an object fetch. + bloom_filter = ser_string(b"\x00") + struct.pack(" Date: Fri, 13 Nov 2026 13:28:20 -0600 Subject: [PATCH 6/9] Merge dashpay/dash#8113: fix(wallet): schedule CoinJoin auto-denomination per wallet and guard an empty round list MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 51134ab743fa07ee5ac3a48c093308eda56f4a75 fix(coinjoin): don't dereference an empty round list in SubmitDenominate (pasta) 7dc17f60545291500ae711788f9695cf663aec08 fix(coinjoin): schedule auto-denomination per wallet (pasta) Pull request description: ## Issue being fixed or feature implemented `CCoinJoinClientManager::DoMaintenance` keeps its tick counter and next-run tick in function statics, so every wallet's client manager shares them. With several mixing wallets loaded, the shared counter advances once per wallet per scheduler tick. Only the wallet whose call happens to land on the scheduled tick runs `DoAutomaticDenominating`. Which wallet mixes is effectively arbitrary, a wallet can skip many cycles, and the configured interval is divided by the number of wallets. A second, smaller bug in the same file: `SubmitDenominate` reads `vecInputsByRounds.begin()->first` without checking that the vector has an entry. Input selection excludes fully mixed coins using the rounds setting at selection time, while the dry-run loop that fills the vector reads `GetRounds()` again. `SetRounds` (the `setcoinjoinrounds` RPC or the GUI) does not take `cs_wallet`, so lowering the target between the two can leave every selected input outside the loop's range. The vector then stays empty and the dereference is undefined behaviour. ## What was done? Two commits: - Keep the maintenance tick and next-run tick as members of each `CCoinJoinClientManager`. Initial values and trigger logic are unchanged. `DoMaintenance` is only called from the scheduler, so the members need no lock. - Skip the per-round attempt when no round count prepared, so the existing all-rounds fallback runs and fails cleanly. ## How Has This Been Tested? On macOS arm64: - A debug build with warnings as errors. - `./src/test/test_dash --run_test='coinjoin_*'`. - `rpc_coinjoin.py --legacy-wallet` and `--descriptors` (on the earlier revision; the CoinJoin code paths they exercise are unchanged since). The new `coinjoin_tests/coinjoin_maintenance_runs_for_every_wallet` test uses the existing wallet fixture and public client methods. With automatic backups disabled, each wallet must stop mixing at its first automatic attempt after five maintenance calls. Applied to unmodified develop, it fails: one wallet runs early and the other misses its deadline. It passes with the fix. The empty-vector guard has no test: reaching it needs a rounds change racing with `SubmitDenominate`, which can't be made deterministic. It was checked by reading the selection and dry-run paths. ## Breaking Changes None. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation (no options or interfaces changed) - [x] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: 3d98748396b8348044b63aac4d0a21602659e8d9104719f679e09f1c81325057c7bfb9a2a6e5d9703857c95c4454a85798b54e81228ad902c00f4b4fc9692836 (cherry picked from commit f464016cb7c2ced0031eaf73377a7c7db4005665) --- src/coinjoin/client.cpp | 19 ++++++++--------- src/coinjoin/client.h | 3 +++ src/wallet/test/coinjoin_tests.cpp | 33 ++++++++++++++++++++++++++++++ 3 files changed, 45 insertions(+), 10 deletions(-) diff --git a/src/coinjoin/client.cpp b/src/coinjoin/client.cpp index 8f4cf4b4e558..e260f837ab65 100644 --- a/src/coinjoin/client.cpp +++ b/src/coinjoin/client.cpp @@ -1793,10 +1793,12 @@ bool CCoinJoinClientSession::SubmitDenominate(CConnman& connman) WalletCJLogPrint(m_wallet, "vecInputsByRounds: rounds: %d, inputs: %d\n", pair.first, pair.second); } - int nRounds = vecInputsByRounds.begin()->first; - if (PrepareDenominate(nRounds, nRounds, strError, vecTxDSIn, vecPSInOutPairsTmp)) { - WalletCJLogPrint(m_wallet, "CCoinJoinClientSession::SubmitDenominate -- Running CoinJoin denominate for %d rounds, success\n", nRounds); - return SendDenominate(vecPSInOutPairsTmp, connman); + if (!vecInputsByRounds.empty()) { + int nRounds = vecInputsByRounds.begin()->first; + if (PrepareDenominate(nRounds, nRounds, strError, vecTxDSIn, vecPSInOutPairsTmp)) { + WalletCJLogPrint(m_wallet, "CCoinJoinClientSession::SubmitDenominate -- Running CoinJoin denominate for %d rounds, success\n", nRounds); + return SendDenominate(vecPSInOutPairsTmp, connman); + } } // We failed? That's strange but let's just make final attempt and try to mix everything @@ -2442,15 +2444,12 @@ void CCoinJoinClientManager::DoMaintenance(ChainstateManager& chainman, CConnman if (!m_mn_sync.IsBlockchainSynced() || ShutdownRequested()) return; - static int nTick = 0; - static int nDoAutoNextRun = nTick + COINJOIN_AUTO_TIMEOUT_MIN; - - nTick++; + m_tick++; CheckTimeout(); ProcessPendingDsaRequest(connman); - if (nDoAutoNextRun == nTick) { + if (m_do_auto_next_run == m_tick) { DoAutomaticDenominating(chainman, connman, mempool); - nDoAutoNextRun = nTick + COINJOIN_AUTO_TIMEOUT_MIN + GetRand(/*nMax=*/COINJOIN_AUTO_TIMEOUT_MAX - COINJOIN_AUTO_TIMEOUT_MIN); + m_do_auto_next_run = m_tick + COINJOIN_AUTO_TIMEOUT_MIN + GetRand(/*nMax=*/COINJOIN_AUTO_TIMEOUT_MAX - COINJOIN_AUTO_TIMEOUT_MIN); } } diff --git a/src/coinjoin/client.h b/src/coinjoin/client.h index 124dbc8aa93b..7eebf4433e34 100644 --- a/src/coinjoin/client.h +++ b/src/coinjoin/client.h @@ -227,6 +227,9 @@ class CCoinJoinClientManager : public interfaces::CoinJoin::Client // Keep track of current block height int nCachedBlockHeight{0}; + int m_tick{0}; + int m_do_auto_next_run{COINJOIN_AUTO_TIMEOUT_MIN}; + bool fCreateAutoBackups{true}; // builtin support for automatic backups bool WaitForAnotherBlock() const; diff --git a/src/wallet/test/coinjoin_tests.cpp b/src/wallet/test/coinjoin_tests.cpp index 01963c3f8e93..fcfc8f28b472 100644 --- a/src/wallet/test/coinjoin_tests.cpp +++ b/src/wallet/test/coinjoin_tests.cpp @@ -236,6 +236,39 @@ class CTransactionBuilderTestSetup : public TestChain100Setup } }; +BOOST_FIXTURE_TEST_CASE(coinjoin_maintenance_runs_for_every_wallet, CTransactionBuilderTestSetup) +{ + struct RestoreOptions { + const bool enabled{CCoinJoinClientOptions::IsEnabled()}; + const int backups{nWalletBackups}; + ~RestoreOptions() + { + CCoinJoinClientOptions::SetEnabled(enabled); + nWalletBackups = backups; + } + } restore_options; + CCoinJoinClientOptions::SetEnabled(true); + nWalletBackups = 0; + m_node.mn_sync->SwitchToNextAsset(); + BOOST_REQUIRE(m_node.mn_sync->IsBlockchainSynced()); + + auto other_wallet{std::make_shared(m_node.chain.get(), m_node.coinjoin_loader.get(), "other", m_args, CreateMockWalletDatabase())}; + other_wallet->SetupLegacyScriptPubKeyMan(); + CCoinJoinClientManager first(wallet, *m_node.dmnman, *m_node.mn_metaman, *m_node.mn_sync, *m_node.isman, nullptr); + CCoinJoinClientManager second(other_wallet, *m_node.dmnman, *m_node.mn_metaman, *m_node.mn_sync, *m_node.isman, nullptr); + BOOST_REQUIRE(first.startMixing()); + BOOST_REQUIRE(second.startMixing()); + for (int tick{0}; tick < COINJOIN_AUTO_TIMEOUT_MIN; ++tick) { + BOOST_CHECK(first.isMixing()); + BOOST_CHECK(second.isMixing()); + first.DoMaintenance(*m_node.chainman, *m_node.connman, *m_node.mempool); + second.DoMaintenance(*m_node.chainman, *m_node.connman, *m_node.mempool); + } + // Each wallet's first automatic attempt stops mixing when automatic backups are disabled. + BOOST_CHECK(!first.isMixing()); + BOOST_CHECK(!second.isMixing()); +} + BOOST_FIXTURE_TEST_CASE(coinjoin_pending_observation_tests, CTransactionBuilderTestSetup) { // 0.100001 DASH, a valid CoinJoin denomination From d50ea3478ceb7d21d71ee3b9020db8fec4cf87bc Mon Sep 17 00:00:00 2001 From: merge-script Date: Fri, 13 Nov 2026 13:32:05 -0600 Subject: [PATCH 7/9] Merge dashpay/dash#8115: fix: free pooled secure allocations with their allocated size MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit fe26212f74690e7859627184a0d6831526046658 fix: free pooled secure allocations with their allocated size (pasta) Pull request description: ## Issue being fixed or feature implemented `mt_pooled_secure_allocator` and the BLS `secure_allocate` wrapper each prepend a `size_t` header to the allocation, but their deallocation paths pass the size without that header. The underlying pool rounds sizes up to whole chunks, so when the header pushes an allocation across a chunk boundary, fewer chunks are freed and cleansed than were allocated, and each allocate/free cycle strands a chunk of locked memory. This is a latent asymmetry, not an observed leak: the pool chunk is 304 bytes, and current BLS callers request 32, 144 or 288 bytes, which round to one chunk on both the allocation and the free side. Only a request of 289..296 bytes (mod 304) through the BLS wrapper would hit it. The generic allocator is exposed for any size that crosses a chunk boundary once its own header is added. ## What was done? - Include each layer's header in its deallocation size, so it matches what the same layer requested on allocation. - Add an allocator unit test that repeats a boundary-crossing allocate/free cycle and checks that locked-pool usage stays flat. An earlier revision of this PR also cleansed the serialized ECDH key in `bls_ies.cpp` and the PBKDF2 temporaries. That was dropped: it wiped only some copies of the secrets involved (the DH point and the plaintext share buffers stayed uncleansed) and no test can observe it, so it does not belong with this fix. ## How Has This Been Tested? On macOS arm64 with depends, `--enable-debug --enable-werror`: - `./src/test/test_dash --run_test=allocator_tests,bls_tests` passes. - With the `mt_pooled_secure.h` change reverted, `allocator_tests/mt_pooled_secure_allocator_reuses_all_chunks` fails: locked-pool usage grows from 384 to 82,288 bytes over 1,000 cycles of a 33-byte allocation (two 40-byte chunks allocated, one freed). The `secure_free` change in `bls.cpp` has no test of its own; it is the same one-line symmetry fix one layer up, and no current caller reaches the affected sizes. ## Breaking Changes None. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation (not needed) - [x] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: 0539c70a4d421207b0aded68f6a1b0a37a3a7df78c74327effa78270ea0981bf5162ffd7c591780b148f48636c81f03d7e00dccb7c34defac95e27e38554e314 (cherry picked from commit ec0c1cd8f56dcf75fc50820f9c5f9256e7922355) --- src/bls/bls.cpp | 2 +- src/support/allocators/mt_pooled_secure.h | 2 +- src/test/allocator_tests.cpp | 22 ++++++++++++++++++++++ 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/src/bls/bls.cpp b/src/bls/bls.cpp index 96a188e2ae93..d1f222109995 100644 --- a/src/bls/bls.cpp +++ b/src/bls/bls.cpp @@ -440,7 +440,7 @@ static void secure_free(void* p) uint8_t* ptr = reinterpret_cast(p) - sizeof(size_t); size_t n = *reinterpret_cast(ptr); - return get_secure_allocator().deallocate(ptr, n); + return get_secure_allocator().deallocate(ptr, n + sizeof(size_t)); } #endif diff --git a/src/support/allocators/mt_pooled_secure.h b/src/support/allocators/mt_pooled_secure.h index 813d40f1ed40..65978eb6a0dd 100644 --- a/src/support/allocators/mt_pooled_secure.h +++ b/src/support/allocators/mt_pooled_secure.h @@ -58,7 +58,7 @@ struct mt_pooled_secure_allocator : public std::allocator { uint8_t* ptr = (uint8_t*)p - sizeof(size_t); size_t bucket = *(size_t*)ptr; std::lock_guard lock(pools[bucket]->mutex); - pools[bucket]->deallocate(ptr, n * sizeof(T)); + pools[bucket]->deallocate(ptr, n * sizeof(T) + sizeof(size_t)); } private: diff --git a/src/test/allocator_tests.cpp b/src/test/allocator_tests.cpp index 53978764e1f0..e903741d0e96 100644 --- a/src/test/allocator_tests.cpp +++ b/src/test/allocator_tests.cpp @@ -250,4 +250,26 @@ BOOST_AUTO_TEST_CASE(mt_pooled_secure_allocator_zero_pool_count) allocator.deallocate(p, 1); } +BOOST_AUTO_TEST_CASE(mt_pooled_secure_allocator_reuses_all_chunks) +{ + mt_pooled_secure_allocator allocator{/*nrequested_size=*/32, + /*nnext_size=*/1, + /*nmax_size=*/0, + /*pools_count=*/1}; + auto& pool = LockedPoolManager::Instance(); + + auto* p = allocator.allocate(33); + BOOST_REQUIRE(p != nullptr); + allocator.deallocate(p, 33); + const auto used = pool.stats().used; + + for (int i = 0; i < 1000; ++i) { + p = allocator.allocate(33); + BOOST_REQUIRE(p != nullptr); + allocator.deallocate(p, 33); + } + + BOOST_CHECK_EQUAL(pool.stats().used, used); +} + BOOST_AUTO_TEST_SUITE_END() From 70e06ae431ed928807110234776183a444cd3982 Mon Sep 17 00:00:00 2001 From: merge-script Date: Fri, 13 Nov 2026 13:38:15 -0600 Subject: [PATCH 8/9] Merge dashpay/dash#8117: fix: races in watch-connection seed, partial sig-share batches, and ChainLock shutdown MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 9707616dad9bca31df444646d3bc0f53966a4373 fix(chainlock): join the scheduler thread in ChainlockHandler::Stop() (pasta) 547392c6aa327383e2bfc0ad8fafcb27601bd8fc fix(llmq): drop the whole sig-share batch when a quorum lookup fails (pasta) 5e524df7adeed48c798f51097b85704439a0420f fix(llmq): initialize the watch-connection seed with a function-local static (pasta) Pull request description: ## Issue being fixed or feature implemented Concurrent first calls can regenerate the watch-connection seed while another caller reads it. A missing quorum during signature-share collection leaves a partial batch that the caller dispatches to code using `quorums.at()`. ChainLock shutdown also returns before its scheduler thread exits. The thread was only joined when the node context was destroyed, so a task already running could continue after `mn_sync` and the mempool were destroyed, or block shutdown in `ActivateBestChain` waiting on the validation queue of the already stopped main scheduler. ## What was done? - Initialize the immutable watch-connection seed with thread-safe function-local static initialization. - Clear both batch outputs when quorum lookup fails, so the caller cannot dispatch an incomplete batch. - Join the ChainLock scheduler thread in `Stop()` and reuse that method from the destructor, guarding repeated joins with `joinable()`. Each fix is its own commit. Reviewed every handler stop/destruction path: production shutdown joins before stopping the main scheduler, with no chain or handler lock held; the full unit fixture calls `Stop()` before later destruction; reindex resets the handler without those locks while the main scheduler runs. The simpler base fixture leaves the handler dormant. No stop/destructor runs on the handler's own scheduler thread. ## How Has This Been Tested? - Debug build with warnings treated as errors: `make -C src -j4 dashd test/test_dash`. - `./src/test/test_dash --run_test='llmq*' --log_level=message`: all 84 cases passed. - `./src/test/test_dash --run_test='validation_chainstatemanager_tests/chainstatemanager,chainstatemanager_snapshot_discarded_on_reindex' --log_level=message`: both cases passed, covering base-fixture teardown and reindex destruction/recreation. - RAM-disk functional runner with an isolated port range and `-j1 --timeout-factor=3`: `feature_llmq_chainlocks.py`, `feature_llmq_signing.py`, and its `--spork21` variant all passed. - Whitespace lint, `git diff --check`, and self-review passed. The seed and partial-batch failure paths were verified by code inspection. No TSAN run or deterministic forced-race reproducer is claimed. ## Breaking Changes None. ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have made corresponding changes to the documentation (not needed for these internal fixes) - [x] I have assigned this pull request to a milestone 🤖 Generated with [Claude Code](https://claude.com/claude-code) Top commit has no ACKs. Tree-SHA512: 0d518624c79f2cdee35b2daa341a5905de3e0a27b63105ca06941baa6e620f53ba1f26a0eebe0c843a5118c4615f680b0da7e4f5798eb22c1aefadd717c02baa (cherry picked from commit 92ed0258e6a4360f54c732858e01f8a56059e93d) --- src/chainlock/handler.cpp | 11 ++++++++--- src/llmq/signing_shares.cpp | 2 ++ src/llmq/utils.cpp | 10 +--------- 3 files changed, 11 insertions(+), 12 deletions(-) diff --git a/src/chainlock/handler.cpp b/src/chainlock/handler.cpp index 7dacdd7b0fa5..9422b67a32cc 100644 --- a/src/chainlock/handler.cpp +++ b/src/chainlock/handler.cpp @@ -56,8 +56,7 @@ ChainlockHandler::ChainlockHandler(chainlock::Chainlocks& chainlocks, Chainstate ChainlockHandler::~ChainlockHandler() { - scheduler->stop(); - scheduler_thread->join(); + Stop(); } void ChainlockHandler::Start() @@ -71,7 +70,13 @@ void ChainlockHandler::Start() std::chrono::seconds{5}); } -void ChainlockHandler::Stop() { scheduler->stop(); } +void ChainlockHandler::Stop() +{ + scheduler->stop(); + if (scheduler_thread->joinable()) { + scheduler_thread->join(); + } +} bool ChainlockHandler::AlreadyHave(const CInv& inv) const { diff --git a/src/llmq/signing_shares.cpp b/src/llmq/signing_shares.cpp index cf9f62e02d1b..31f6c67c025c 100644 --- a/src/llmq/signing_shares.cpp +++ b/src/llmq/signing_shares.cpp @@ -596,6 +596,8 @@ bool CSigSharesManager::CollectPendingSigSharesToVerify( if (!quorum) { LogPrintf("%s: ERROR! Unexpected missing quorum with llmqType=%d, quorumHash=%s\n", __func__, std23::to_underlying(llmqType), sigShare.getQuorumHash().ToString()); + retSigShares.clear(); + retQuorums.clear(); return false; } retQuorums.try_emplace(k, quorum); diff --git a/src/llmq/utils.cpp b/src/llmq/utils.cpp index 195a050375a1..fee5541cc397 100644 --- a/src/llmq/utils.cpp +++ b/src/llmq/utils.cpp @@ -20,7 +20,6 @@ #include #include -#include #include #include @@ -834,14 +833,7 @@ std::unordered_set CalcDeterministicWatchConnections(Consensus::LLMQType gsl::not_null pQuorumBaseBlockIndex, size_t memberCount, size_t connectionCount) { - static uint256 qwatchConnectionSeed; - static std::atomic qwatchConnectionSeedGenerated{false}; - static RecursiveMutex qwatchConnectionSeedCs; - if (!qwatchConnectionSeedGenerated) { - LOCK(qwatchConnectionSeedCs); - qwatchConnectionSeed = GetRandHash(); - qwatchConnectionSeedGenerated = true; - } + static const uint256 qwatchConnectionSeed = GetRandHash(); std::unordered_set result; uint256 rnd = qwatchConnectionSeed; From b534385519035b588ac5187206f6220537d32845 Mon Sep 17 00:00:00 2001 From: pasta Date: Fri, 13 Nov 2026 20:06:13 +0000 Subject: [PATCH 9/9] chore: prepare v24.0.2 release Bump the build version to 2, add the v24.0.2 release notes, archive the v24.0.1 notes, add the flatpak release entry and bump the version string in the man pages (no option shown in the help changed since v24.0.1). Co-Authored-By: Claude Fable 5.2 --- configure.ac | 2 +- .../flatpak/org.dash.dash-core.metainfo.xml | 1 + doc/man/dash-cli.1 | 6 +- doc/man/dash-qt.1 | 6 +- doc/man/dash-tx.1 | 6 +- doc/man/dash-util.1 | 6 +- doc/man/dash-wallet.1 | 6 +- doc/man/dashd.1 | 6 +- doc/release-notes.md | 184 +++++++-------- .../dash/release-notes-24.0.1.md | 219 ++++++++++++++++++ 10 files changed, 318 insertions(+), 124 deletions(-) create mode 100644 doc/release-notes/dash/release-notes-24.0.1.md diff --git a/configure.ac b/configure.ac index d5d2b0651c14..3fb384760dd0 100644 --- a/configure.ac +++ b/configure.ac @@ -2,7 +2,7 @@ AC_PREREQ([2.69]) dnl Don't forget to push a corresponding tag when updating any of _CLIENT_VERSION_* numbers define(_CLIENT_VERSION_MAJOR, 24) define(_CLIENT_VERSION_MINOR, 0) -define(_CLIENT_VERSION_BUILD, 1) +define(_CLIENT_VERSION_BUILD, 2) define(_CLIENT_VERSION_IS_RELEASE, true) define(_COPYRIGHT_YEAR, 2026) define(_COPYRIGHT_HOLDERS,[The %s developers]) diff --git a/contrib/flatpak/org.dash.dash-core.metainfo.xml b/contrib/flatpak/org.dash.dash-core.metainfo.xml index 4ac5f311efbf..d329859ad191 100644 --- a/contrib/flatpak/org.dash.dash-core.metainfo.xml +++ b/contrib/flatpak/org.dash.dash-core.metainfo.xml @@ -21,6 +21,7 @@ + diff --git a/doc/man/dash-cli.1 b/doc/man/dash-cli.1 index d7149d0f0286..ff0fd123ccdf 100644 --- a/doc/man/dash-cli.1 +++ b/doc/man/dash-cli.1 @@ -1,7 +1,7 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3. -.TH DASH-CLI "1" "November 2026" "dash-cli v24.0.1" "User Commands" +.TH DASH-CLI "1" "November 2026" "dash-cli v24.0.2" "User Commands" .SH NAME -dash-cli \- manual page for dash-cli v24.0.1 +dash-cli \- manual page for dash-cli v24.0.2 .SH SYNOPSIS .B dash-cli [\fI\,options\/\fR] \fI\, \/\fR[\fI\,params\/\fR] \fI\,Send command to Dash Core\/\fR @@ -15,7 +15,7 @@ dash-cli \- manual page for dash-cli v24.0.1 .B dash-cli [\fI\,options\/\fR] \fI\,help Get help for a command\/\fR .SH DESCRIPTION -Dash Core RPC client version v24.0.1 +Dash Core RPC client version v24.0.2 .SH OPTIONS .HP \-? diff --git a/doc/man/dash-qt.1 b/doc/man/dash-qt.1 index bb5400952946..5a75964ed1a6 100644 --- a/doc/man/dash-qt.1 +++ b/doc/man/dash-qt.1 @@ -1,12 +1,12 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3. -.TH DASH-QT "1" "November 2026" "dash-qt v24.0.1" "User Commands" +.TH DASH-QT "1" "November 2026" "dash-qt v24.0.2" "User Commands" .SH NAME -dash-qt \- manual page for dash-qt v24.0.1 +dash-qt \- manual page for dash-qt v24.0.2 .SH SYNOPSIS .B dash-qt [\fI\,command-line options\/\fR] [\fI\,URI\/\fR] .SH DESCRIPTION -Dash Core version v24.0.1 +Dash Core version v24.0.2 .PP Optional URI is a Dash address in BIP21 URI format. .SH OPTIONS diff --git a/doc/man/dash-tx.1 b/doc/man/dash-tx.1 index 128aac1217d0..13cdd5f1e5e1 100644 --- a/doc/man/dash-tx.1 +++ b/doc/man/dash-tx.1 @@ -1,7 +1,7 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3. -.TH DASH-TX "1" "November 2026" "dash-tx v24.0.1" "User Commands" +.TH DASH-TX "1" "November 2026" "dash-tx v24.0.2" "User Commands" .SH NAME -dash-tx \- manual page for dash-tx v24.0.1 +dash-tx \- manual page for dash-tx v24.0.2 .SH SYNOPSIS .B dash-tx [\fI\,options\/\fR] \fI\, \/\fR[\fI\,commands\/\fR] \fI\,Update hex-encoded dash transaction\/\fR @@ -9,7 +9,7 @@ dash-tx \- manual page for dash-tx v24.0.1 .B dash-tx [\fI\,options\/\fR] \fI\,-create \/\fR[\fI\,commands\/\fR] \fI\,Create hex-encoded dash transaction\/\fR .SH DESCRIPTION -Dash Core dash\-tx utility version v24.0.1 +Dash Core dash\-tx utility version v24.0.2 .SH OPTIONS .HP \-? diff --git a/doc/man/dash-util.1 b/doc/man/dash-util.1 index 35e3f5290f68..41d95b0b1cd4 100644 --- a/doc/man/dash-util.1 +++ b/doc/man/dash-util.1 @@ -1,12 +1,12 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3. -.TH DASH-UTIL "1" "November 2026" "dash-util v24.0.1" "User Commands" +.TH DASH-UTIL "1" "November 2026" "dash-util v24.0.2" "User Commands" .SH NAME -dash-util \- manual page for dash-util v24.0.1 +dash-util \- manual page for dash-util v24.0.2 .SH SYNOPSIS .B dash-util [\fI\,options\/\fR] [\fI\,commands\/\fR] \fI\,Do stuff\/\fR .SH DESCRIPTION -Dash Core dash\-util utility version v24.0.1 +Dash Core dash\-util utility version v24.0.2 .SH OPTIONS .HP \-? diff --git a/doc/man/dash-wallet.1 b/doc/man/dash-wallet.1 index 6034d6b58b37..66a16959469d 100644 --- a/doc/man/dash-wallet.1 +++ b/doc/man/dash-wallet.1 @@ -1,9 +1,9 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3. -.TH DASH-WALLET "1" "November 2026" "dash-wallet v24.0.1" "User Commands" +.TH DASH-WALLET "1" "November 2026" "dash-wallet v24.0.2" "User Commands" .SH NAME -dash-wallet \- manual page for dash-wallet v24.0.1 +dash-wallet \- manual page for dash-wallet v24.0.2 .SH DESCRIPTION -Dash Core dash\-wallet version v24.0.1 +Dash Core dash\-wallet version v24.0.2 .PP dash\-wallet is an offline tool for creating and interacting with Dash Core wallet files. By default dash\-wallet will act on wallets in the default mainnet wallet directory in the datadir. diff --git a/doc/man/dashd.1 b/doc/man/dashd.1 index 8095630417fd..b6f06dd76c32 100644 --- a/doc/man/dashd.1 +++ b/doc/man/dashd.1 @@ -1,12 +1,12 @@ .\" DO NOT MODIFY THIS FILE! It was generated by help2man 1.49.3. -.TH DASHD "1" "November 2026" "dashd v24.0.1" "User Commands" +.TH DASHD "1" "November 2026" "dashd v24.0.2" "User Commands" .SH NAME -dashd \- manual page for dashd v24.0.1 +dashd \- manual page for dashd v24.0.2 .SH SYNOPSIS .B dashd [\fI\,options\/\fR] \fI\,Start Dash Core\/\fR .SH DESCRIPTION -Dash Core version v24.0.1 +Dash Core version v24.0.2 .SH OPTIONS .HP \-? diff --git a/doc/release-notes.md b/doc/release-notes.md index 0797c39d0da6..8122ff97eee9 100644 --- a/doc/release-notes.md +++ b/doc/release-notes.md @@ -1,19 +1,17 @@ -# Dash Core version v24.0.1 - -This is a new patch version release. It fixes a problem that has delayed the -`v24` network upgrade on mainnet: `LLMQ_400_85` quorums were failing to form -because slower masternodes could not finish the last step of the DKG in time, -and the `v24` EHF signal is only attempted again once a different quorum is -selected for it. It also changes how masternodes vote on superblock triggers -so that a superblock cannot be left unpaid by a change in the approved -proposals, and fixes several other bugs. - -Like v24.0.0, this release carries the `v24` network upgrade (hard fork) and is -**mandatory** for all nodes. Masternodes should upgrade to v24.0.1 as soon as -possible. All other nodes must run v24.0.0 or later before the hard fork -activates, and upgrading to v24.0.1 is strongly recommended. The upgrade itself -and everything else introduced in v24 are described in the -[v24.0.0 release notes](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.0.md). +# Dash Core version v24.0.2 + +This is a new patch version release. It fixes a memory leak introduced in +v24.0.0 that makes a node's memory use grow until the node is restarted, a +crash of the macOS GUI during shutdown, and several other bugs. + +Like v24.0.0 and v24.0.1, this release carries the `v24` network upgrade (hard +fork), which is **mandatory** for all nodes: every node must run v24.0.0 or +later before the hard fork activates. Masternodes should upgrade to v24.0.2 as +soon as possible, and upgrading is strongly recommended for all other nodes. +The upgrade itself and everything else introduced in v24 are described in the +[v24.0.0 release notes](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.0.md), +and the fixes for `v24` activation in the +[v24.0.1 release notes](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.1.md). Please report bugs using the issue tracker at GitHub: @@ -28,17 +26,17 @@ shut down (which might take a few minutes for older versions), then run the installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or dashd/dash-qt (on Linux). -Upgrading from v24.0.0 needs no further steps. If you are upgrading from -v23.1.x or older, read "How to Upgrade" in the +Upgrading from v24.0.0 or v24.0.1 needs no further steps. If you are upgrading +from v23.1.x or older, read "How to Upgrade" in the [v24.0.0 release notes](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.0.md) first: the first start migrates the address, spent and timestamp indexes, and some settings changed. ## Downgrade warning -### Downgrade to v24.0.0 +### Downgrade to v24.0.0 or v24.0.1 -Downgrading to v24.0.0 is possible and needs no special steps. +Downgrading to v24.0.0 or v24.0.1 is possible and needs no special steps. ### Downgrade to a version < v24.0.0 @@ -48,88 +46,64 @@ activation has caveats. See "Downgrade warning" in the # Release Notes -## v24 activation - -Activation of `v24` starts with masternodes signing an EHF signal with the -`LLMQ_400_85` quorum, which needs 340 of a quorum's 400 members. On mainnet -that signal has not been signed yet. When the signal window opened, too few -members of the selected quorum had upgraded, and a masternode signs the signal -only once per quorum. The signal is attempted again when a different quorum is -selected for it, but no `LLMQ_400_85` round on mainnet has formed a quorum -since then, so the selected quorum has not changed. - -- **DKG members no longer reload every verification vector at the commit - step.** To build its commitment, and to verify each commitment it received, - a member read every other member's verification vector back from disk. For a - 400-member quorum that took even the fastest masternodes 20 to 30 seconds - and slower ones minutes, while the commit phase lasts only four blocks. When - those blocks came quickly, too few members finished in time and the quorum - did not form. The vectors are now kept in memory for the duration of the DKG - session, and a masternode handles its own DKG messages before queued - messages from peers. - A masternode benefits as soon as it is upgraded, including in quorums whose - other members still run v24.0.0. (#8135, #8130) -- A quorum commitment is no longer dropped from a node's pool when the block - that carried it is rejected for an unrelated reason. Previously the - commitment was lost on every node that had validated that block and the - quorum was not mined in that DKG cycle. (#8104) - -An `LLMQ_400_85` DKG runs once a day. Each time a different quorum is selected -for the signal, its members sign it, including members that run v24.0.0, and -the signal is completed if 340 of the quorum's 400 members run v24.0.0 or -later and are online. The selected quorum changes at the latest once four new -quorums have formed. - -The parameters of the `v24` deployment are unchanged from v24.0.0. Miner -signaling still starts at the first 4032-block window boundary after the EHF -signal is mined, so the earliest possible activation date given in the v24.0.0 -release notes moves back by about a week for every window boundary that passes -before the signal is mined. - -## Governance - -- A masternode now waits until a superblock trigger for its own candidate - exists before it votes NO-FUNDING on other triggers, and casts those NO - votes at the latest three blocks before the superblock. Previously it voted - NO on every trigger that did not match its candidate at that block and never - revisited the vote. If the set of approved proposals changed while triggers - were being created, masternodes could end up having voted NO on the trigger - that matched their final candidate, and the superblock could pay no - proposals. (#8131) -- After a cycle that ended without a funded trigger, a masternode that had - voted YES in that cycle no longer votes NO on the next cycle's trigger. - (#8131) -- On test networks, a node restarted inside the maturity window no longer - drops its stored triggers and then rejects the superblock. Mainnet was not - affected. (#8097) - -Masternodes running older versions keep the old voting behaviour, so this -protection becomes effective as masternodes upgrade. Masternode operators -should upgrade before a superblock's maturity window opens, which is 1662 -blocks before the superblock. For the superblock at block 2575480 the window -opens at block 2573818 (around November 17). - -## Other fixes - -- Fixed an assertion failure in governance that could stop a node after a - reorg that changed the block in which a masternode registration was mined. - The failure repeated on every start until `governance.dat` was deleted. - (#8100) -- The network thread no longer spins at full CPU while a peer's send buffer is - full. (#8094) -- `GET /rest/block/.json` no longer terminates the node when the block - contains a provider transaction whose payload can't be decoded. (#8099) -- GUI: a shared masternode contribution can be reserved again after it was - released. (#8052) - -## Build and tests - -- The depends build fetches the miniupnpc sources from a location that still - serves them. (#8088) -- `test_dash-qt` no longer hangs or crashes when built against a distribution - Qt that uses the GLib event loop. (#8080) - -# v24.0.1 Change log +## Memory leak + +- Fixed a memory leak introduced in v24.0.0. A node's memory use grew + steadily with normal network activity and the memory was not returned until + the node was restarted. Masternodes were affected the most, but every node + was affected. (#8115) + +## GUI + +- macOS: fixed a crash when a wallet item of the File menu was used while the + application was shutting down. The menu bar stays available on macOS after + the main window closes; the menus are now removed when shutdown starts. + (#8073) + +## Network + +- A node now answers a governance sync request only to the peer that sent it. + Previously it announced every governance object, or every vote of the + requested object, to all of its peers each time one peer asked. (#8112) +- A governance vote that arrived before its governance object can be served to + peers once the object arrives. Previously the node announced such a vote but + could not send it when a peer requested it. (#8112) + +## Shutdown and masternodes + +- The ChainLocks thread is now stopped before the rest of the node shuts + down. Previously it could still be running during shutdown, which could + crash or stall the shutdown. (#8117) +- Masternodes: a batch of signature shares is no longer processed partially + when the quorum of one of its shares can't be found. (#8117) + +## Wallet + +- CoinJoin: with more than one wallet loaded, automatic mixing used one + schedule shared by all wallets, so a wallet could miss many of its turns. + Each wallet now has its own schedule. (#8113) +- CoinJoin: fixed undefined behaviour in a mixing session when the number of + rounds was lowered while inputs were being selected. (#8113) + +## Statistics + +These apply to nodes started with `-statshost`. + +- The `transactions.inputValue` metric reported the output value minus the + fee. It now reports the value of the inputs spent. (#8119) +- Fixed a possible crash when statistics were collected before the node had a + chain tip, for example at startup or during a reindex, and a data race on + the counters of sent messages. (#8119) + +Nodes that don't use `-statshost` no longer compute these statistics for every +transaction and block. (#8119) + +## Command-line tools + +- `dash-cli` and `dash-tx` accept `-printcrashinfo`, which their own crash + message asks the user to run. Previously they rejected the option. (#8120) + +# v24.0.2 Change log See detailed [set of changes][set-of-changes]. @@ -140,13 +114,13 @@ Thanks to everyone who directly contributed to this release: - Konstantin Akimov - PastaPastaPasta -As well as everyone that submitted issues, reviewed pull requests and helped -debug the release candidates. +As well as everyone that submitted issues and reviewed pull requests. # Older releases These releases are considered obsolete. Old release notes can be found here: +- [v24.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.1.md) released Nov/13/2026 - [v24.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.0.md) released Nov/5/2026 - [v23.1.10](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.10.md) released Nov/2/2026 - [v23.1.9](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.9.md) released Oct/29/2026 @@ -216,4 +190,4 @@ These releases are considered obsolete. Old release notes can be found here: - [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014 - [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014 -[set-of-changes]: https://github.com/dashpay/dash/compare/v24.0.0...dashpay:v24.0.1 +[set-of-changes]: https://github.com/dashpay/dash/compare/v24.0.1...dashpay:v24.0.2 diff --git a/doc/release-notes/dash/release-notes-24.0.1.md b/doc/release-notes/dash/release-notes-24.0.1.md new file mode 100644 index 000000000000..0797c39d0da6 --- /dev/null +++ b/doc/release-notes/dash/release-notes-24.0.1.md @@ -0,0 +1,219 @@ +# Dash Core version v24.0.1 + +This is a new patch version release. It fixes a problem that has delayed the +`v24` network upgrade on mainnet: `LLMQ_400_85` quorums were failing to form +because slower masternodes could not finish the last step of the DKG in time, +and the `v24` EHF signal is only attempted again once a different quorum is +selected for it. It also changes how masternodes vote on superblock triggers +so that a superblock cannot be left unpaid by a change in the approved +proposals, and fixes several other bugs. + +Like v24.0.0, this release carries the `v24` network upgrade (hard fork) and is +**mandatory** for all nodes. Masternodes should upgrade to v24.0.1 as soon as +possible. All other nodes must run v24.0.0 or later before the hard fork +activates, and upgrading to v24.0.1 is strongly recommended. The upgrade itself +and everything else introduced in v24 are described in the +[v24.0.0 release notes](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.0.md). + +Please report bugs using the issue tracker at GitHub: + + + +# Upgrading and downgrading + +## How to Upgrade + +If you are running an older version, shut it down. Wait until it has completely +shut down (which might take a few minutes for older versions), then run the +installer (on Windows) or just copy over /Applications/Dash-Qt (on Mac) or +dashd/dash-qt (on Linux). + +Upgrading from v24.0.0 needs no further steps. If you are upgrading from +v23.1.x or older, read "How to Upgrade" in the +[v24.0.0 release notes](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.0.md) +first: the first start migrates the address, spent and timestamp indexes, and +some settings changed. + +## Downgrade warning + +### Downgrade to v24.0.0 + +Downgrading to v24.0.0 is possible and needs no special steps. + +### Downgrade to a version < v24.0.0 + +There is no supported downgrade after `v24` activation, and downgrading before +activation has caveats. See "Downgrade warning" in the +[v24.0.0 release notes](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.0.md). + +# Release Notes + +## v24 activation + +Activation of `v24` starts with masternodes signing an EHF signal with the +`LLMQ_400_85` quorum, which needs 340 of a quorum's 400 members. On mainnet +that signal has not been signed yet. When the signal window opened, too few +members of the selected quorum had upgraded, and a masternode signs the signal +only once per quorum. The signal is attempted again when a different quorum is +selected for it, but no `LLMQ_400_85` round on mainnet has formed a quorum +since then, so the selected quorum has not changed. + +- **DKG members no longer reload every verification vector at the commit + step.** To build its commitment, and to verify each commitment it received, + a member read every other member's verification vector back from disk. For a + 400-member quorum that took even the fastest masternodes 20 to 30 seconds + and slower ones minutes, while the commit phase lasts only four blocks. When + those blocks came quickly, too few members finished in time and the quorum + did not form. The vectors are now kept in memory for the duration of the DKG + session, and a masternode handles its own DKG messages before queued + messages from peers. + A masternode benefits as soon as it is upgraded, including in quorums whose + other members still run v24.0.0. (#8135, #8130) +- A quorum commitment is no longer dropped from a node's pool when the block + that carried it is rejected for an unrelated reason. Previously the + commitment was lost on every node that had validated that block and the + quorum was not mined in that DKG cycle. (#8104) + +An `LLMQ_400_85` DKG runs once a day. Each time a different quorum is selected +for the signal, its members sign it, including members that run v24.0.0, and +the signal is completed if 340 of the quorum's 400 members run v24.0.0 or +later and are online. The selected quorum changes at the latest once four new +quorums have formed. + +The parameters of the `v24` deployment are unchanged from v24.0.0. Miner +signaling still starts at the first 4032-block window boundary after the EHF +signal is mined, so the earliest possible activation date given in the v24.0.0 +release notes moves back by about a week for every window boundary that passes +before the signal is mined. + +## Governance + +- A masternode now waits until a superblock trigger for its own candidate + exists before it votes NO-FUNDING on other triggers, and casts those NO + votes at the latest three blocks before the superblock. Previously it voted + NO on every trigger that did not match its candidate at that block and never + revisited the vote. If the set of approved proposals changed while triggers + were being created, masternodes could end up having voted NO on the trigger + that matched their final candidate, and the superblock could pay no + proposals. (#8131) +- After a cycle that ended without a funded trigger, a masternode that had + voted YES in that cycle no longer votes NO on the next cycle's trigger. + (#8131) +- On test networks, a node restarted inside the maturity window no longer + drops its stored triggers and then rejects the superblock. Mainnet was not + affected. (#8097) + +Masternodes running older versions keep the old voting behaviour, so this +protection becomes effective as masternodes upgrade. Masternode operators +should upgrade before a superblock's maturity window opens, which is 1662 +blocks before the superblock. For the superblock at block 2575480 the window +opens at block 2573818 (around November 17). + +## Other fixes + +- Fixed an assertion failure in governance that could stop a node after a + reorg that changed the block in which a masternode registration was mined. + The failure repeated on every start until `governance.dat` was deleted. + (#8100) +- The network thread no longer spins at full CPU while a peer's send buffer is + full. (#8094) +- `GET /rest/block/.json` no longer terminates the node when the block + contains a provider transaction whose payload can't be decoded. (#8099) +- GUI: a shared masternode contribution can be reserved again after it was + released. (#8052) + +## Build and tests + +- The depends build fetches the miniupnpc sources from a location that still + serves them. (#8088) +- `test_dash-qt` no longer hangs or crashes when built against a distribution + Qt that uses the GLib event loop. (#8080) + +# v24.0.1 Change log + +See detailed [set of changes][set-of-changes]. + +# Credits + +Thanks to everyone who directly contributed to this release: + +- Konstantin Akimov +- PastaPastaPasta + +As well as everyone that submitted issues, reviewed pull requests and helped +debug the release candidates. + +# Older releases + +These releases are considered obsolete. Old release notes can be found here: + +- [v24.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-24.0.0.md) released Nov/5/2026 +- [v23.1.10](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.10.md) released Nov/2/2026 +- [v23.1.9](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.9.md) released Oct/29/2026 +- [v23.1.8](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.8.md) released Jul/29/2026 +- [v23.1.7](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.7.md) released Jun/30/2026 +- [v23.1.5](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.5.md) released Jun/19/2026 +- [v23.1.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.4.md) released Jun/18/2026 +- [v23.1.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.3.md) released May/28/2026 +- [v23.1.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.2.md) released Mar/12/2026 +- [v23.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.1.0.md) released Feb/15/2026 +- [v23.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.0.2.md) released Dec/4/2025 +- [v23.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-23.0.0.md) released Nov/10/2025 +- [v22.1.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-22.1.3.md) released Jul/15/2025 +- [v22.1.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-22.1.2.md) released Apr/15/2025 +- [v22.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-22.1.1.md) released Feb/17/2025 +- [v22.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-22.1.0.md) released Feb/10/2025 +- [v22.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-22.0.0.md) released Dec/12/2024 +- [v21.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-21.1.1.md) released Oct/22/2024 +- [v21.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-21.1.0.md) released Aug/8/2024 +- [v21.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-21.0.2.md) released Aug/1/2024 +- [v21.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-21.0.0.md) released Jul/25/2024 +- [v20.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.1.1.md) released April/3/2024 +- [v20.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.1.0.md) released March/5/2024 +- [v20.0.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.4.md) released Jan/13/2024 +- [v20.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.3.md) released December/26/2023 +- [v20.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.2.md) released December/06/2023 +- [v20.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.1.md) released November/18/2023 +- [v20.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-20.0.0.md) released November/15/2023 +- [v19.3.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.3.0.md) released July/31/2023 +- [v19.2.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.2.0.md) released June/19/2023 +- [v19.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.1.0.md) released May/22/2023 +- [v19.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-19.0.0.md) released Apr/14/2023 +- [v18.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.2.md) released Mar/21/2023 +- [v18.2.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.1.md) released Jan/17/2023 +- [v18.2.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.2.0.md) released Jan/01/2023 +- [v18.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.1.1.md) released January/08/2023 +- [v18.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.1.0.md) released October/09/2022 +- [v18.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.0.2.md) released October/09/2022 +- [v18.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-18.0.1.md) released August/17/2022 +- [v0.17.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.17.0.3.md) released June/07/2021 +- [v0.17.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.17.0.2.md) released May/19/2021 +- [v0.16.1.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.1.1.md) released November/17/2020 +- [v0.16.1.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.1.0.md) released November/14/2020 +- [v0.16.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.16.0.1.md) released September/30/2020 +- [v0.15.0.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.15.0.md) released February/18/2020 +- [v0.14.0.5](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.5.md) released December/08/2019 +- [v0.14.0.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.4.md) released November/22/2019 +- [v0.14.0.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.3.md) released August/15/2019 +- [v0.14.0.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.2.md) released July/4/2019 +- [v0.14.0.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.1.md) released May/31/2019 +- [v0.14.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.14.0.md) released May/22/2019 +- [v0.13.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.3.md) released Apr/04/2019 +- [v0.13.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.2.md) released Mar/15/2019 +- [v0.13.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.1.md) released Feb/9/2019 +- [v0.13.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.13.0.md) released Jan/14/2019 +- [v0.12.3.4](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.4.md) released Dec/14/2018 +- [v0.12.3.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.3.md) released Sep/19/2018 +- [v0.12.3.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.2.md) released Jul/09/2018 +- [v0.12.3.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.3.1.md) released Jul/03/2018 +- [v0.12.2.3](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.3.md) released Jan/12/2018 +- [v0.12.2.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.2.md) released Dec/17/2017 +- [v0.12.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.2.md) released Nov/08/2017 +- [v0.12.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.12.0.md) released Aug/15/2015 +- [v0.11.2](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.2.md) released Mar/04/2015 +- [v0.11.1](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.1.md) released Feb/10/2015 +- [v0.11.0](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.11.0.md) released Jan/15/2015 +- [v0.10.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.10.0.md) released Sep/25/2014 +- [v0.9.x](https://github.com/dashpay/dash/blob/master/doc/release-notes/dash/release-notes-0.9.0.md) released Mar/13/2014 + +[set-of-changes]: https://github.com/dashpay/dash/compare/v24.0.0...dashpay:v24.0.1