From be46a17416e7b3ba7548bf408db987870723e5cc Mon Sep 17 00:00:00 2001 From: Lukasz Klimek <842586+lklimek@users.noreply.github.com> Date: Fri, 31 Jul 2026 16:55:47 +0000 Subject: [PATCH] chore(deps): bump platform pin to PR #3968 tip (fix empty-script UTXO wallet-brick) Moves all four dashpay/platform git dependencies -- dash-sdk, rs-sdk-trusted-context-provider, platform-wallet, platform-wallet-storage -- from a18bd158 to 762c66cf, the tip of PR #3968 (feat/platform-wallet-storage-rehydration). The four share one rev by necessity: splitting them would resolve two git sources for one repo and duplicate every shared platform type. 762c66cf is "fix(platform-wallet-storage): stop one bad script row from bricking a wallet file", a direct child of the previous pin touching only rs-platform-wallet-storage (core_state.rs, core_pool.rs, and a test). A single core_utxos row with an empty script made an entire persisted wallet file unloadable -- one fabricated row out of 668 locked 12 wallets in a real user database. Upstream stops manufacturing the row on write and makes both reuse-guard readers of load_used_addresses skip-and-warn per row. load_state stays fail-hard by design: it reads only spent = 0 rows and is the balance source, so a corrupt balance-bearing row still aborts loudly rather than under-report a balance. No DET-side change is required. load_used_addresses and AddressDecode appear nowhere in this repository, and all seven Address::from_script call sites here decode asset-lock credit outputs or withdrawal documents, already tolerate a decode failure, and never touch the persisted-UTXO path. The user-facing string this fix stops triggering is TaskError's "Saved wallet data appears damaged", which is a Display message rather than a behavioural dependency. Cargo.lock carries only the 28 platform source lines. A plain cargo update -p also re-pointed prost-build, prost-derive and winapi-util onto already-present older copies of itertools and windows-sys; the package version set was identical either way, so that churn was dropped in favour of a rev rewrite verified by building with --locked. Co-Authored-By: Claude Opus 5 --- CHANGELOG.md | 11 +++++++++++ Cargo.lock | 56 ++++++++++++++++++++++++++-------------------------- Cargo.toml | 8 ++++---- 3 files changed, 43 insertions(+), 32 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1e90d48a8..7ed1b4fd2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -101,6 +101,17 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/). ### Fixed +- **One damaged payment record no longer makes every wallet unopenable**: all + wallets are kept in a single file, and one unreadable payment record in it + stopped that whole file from opening — every wallet it held, funded ones + included, reported "Saved wallet data appears damaged and cannot be loaded." + Such a record is now skipped so the remaining wallets open normally, and the + records that caused it are no longer written in the first place. Wallets + already affected open again after updating, with their funds intact and no + need to restore from a recovery phrase. Amounts are still checked strictly: + a damaged record that carries a balance continues to stop the file from + opening rather than show a total that is quietly too low. + - **"Max" now matches what your Core wallet can actually send**: pressing "Max" when shielding DASH, funding a Platform address through the Simple builder-driven form, sending directly to an identity, or funding an identity diff --git a/Cargo.lock b/Cargo.lock index d89ffe9ad..8f5225dc4 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1877,7 +1877,7 @@ dependencies = [ [[package]] name = "dapi-grpc" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "dash-platform-macros", "futures-core", @@ -1979,7 +1979,7 @@ dependencies = [ [[package]] name = "dash-async" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "thiserror 2.0.18", "tokio", @@ -1989,7 +1989,7 @@ dependencies = [ [[package]] name = "dash-context-provider" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "dash-async", "dpp", @@ -2100,7 +2100,7 @@ dependencies = [ [[package]] name = "dash-platform-macros" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "heck", "quote", @@ -2110,7 +2110,7 @@ dependencies = [ [[package]] name = "dash-sdk" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "arc-swap", "async-trait", @@ -2247,7 +2247,7 @@ dependencies = [ [[package]] name = "dashpay-contract" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "platform-value", "platform-version", @@ -2258,7 +2258,7 @@ dependencies = [ [[package]] name = "data-contracts" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "dashpay-contract", "document-history-contract", @@ -2527,7 +2527,7 @@ dependencies = [ [[package]] name = "document-history-contract" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "platform-value", "platform-version", @@ -2556,7 +2556,7 @@ checksum = "d8b14ccef22fc6f5a8f4d7d768562a182c04ce9a3b3157b91390b52ddfdf1a76" [[package]] name = "dpns-contract" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "platform-value", "platform-version", @@ -2567,7 +2567,7 @@ dependencies = [ [[package]] name = "dpp" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "anyhow", "async-trait", @@ -2617,7 +2617,7 @@ dependencies = [ [[package]] name = "dpp-json-convertible-derive" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "proc-macro2", "quote", @@ -2627,7 +2627,7 @@ dependencies = [ [[package]] name = "drive" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "bincode 2.0.1", "byteorder", @@ -2652,7 +2652,7 @@ dependencies = [ [[package]] name = "drive-proof-verifier" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "bincode 2.0.1", "dapi-grpc", @@ -5046,7 +5046,7 @@ dependencies = [ [[package]] name = "keyword-search-contract" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "platform-value", "platform-version", @@ -5259,7 +5259,7 @@ dependencies = [ [[package]] name = "masternode-reward-shares-contract" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "platform-value", "platform-version", @@ -6471,7 +6471,7 @@ checksum = "b4596b6d070b27117e987119b4dac604f3c58cfb0b191112e24771b2faeac1a6" [[package]] name = "platform-encryption" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "aes", "cbc", @@ -6484,7 +6484,7 @@ dependencies = [ [[package]] name = "platform-serialization" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "bincode 2.0.1", "platform-version", @@ -6493,7 +6493,7 @@ dependencies = [ [[package]] name = "platform-serialization-derive" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "proc-macro2", "quote", @@ -6504,7 +6504,7 @@ dependencies = [ [[package]] name = "platform-value" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "base64 0.22.1", "bincode 2.0.1", @@ -6524,7 +6524,7 @@ dependencies = [ [[package]] name = "platform-version" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "bincode 2.0.1", "grovedb-version 5.0.1", @@ -6535,7 +6535,7 @@ dependencies = [ [[package]] name = "platform-versioning" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "proc-macro2", "quote", @@ -6545,7 +6545,7 @@ dependencies = [ [[package]] name = "platform-wallet" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "arc-swap", "async-trait", @@ -6577,7 +6577,7 @@ dependencies = [ [[package]] name = "platform-wallet-storage" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "apple-native-keyring-store", "argon2", @@ -7574,7 +7574,7 @@ dependencies = [ [[package]] name = "rs-dapi-client" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "backon", "chrono", @@ -7600,7 +7600,7 @@ dependencies = [ [[package]] name = "rs-sdk-trusted-context-provider" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "arc-swap", "dash-async", @@ -8842,7 +8842,7 @@ checksum = "1f3ccbac311fea05f86f61904b462b55fb3df8837a366dfc601a0161d0532f20" [[package]] name = "token-history-contract" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "platform-value", "platform-version", @@ -9687,7 +9687,7 @@ dependencies = [ [[package]] name = "wallet-utils-contract" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "platform-value", "platform-version", @@ -10943,7 +10943,7 @@ dependencies = [ [[package]] name = "withdrawals-contract" version = "4.1.0" -source = "git+https://github.com/dashpay/platform?rev=a18bd1586858ef680124e150caad6a7dc21d0b64#a18bd1586858ef680124e150caad6a7dc21d0b64" +source = "git+https://github.com/dashpay/platform?rev=762c66cf7716b9b3264868a49e8d29991c643c7e#762c66cf7716b9b3264868a49e8d29991c643c7e" dependencies = [ "num_enum 0.5.11", "platform-value", diff --git a/Cargo.toml b/Cargo.toml index 694b5fedf..5b0271230 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -20,7 +20,7 @@ eframe = { version = "0.35.0", features = ["persistence", "wgpu"] } base64 = "0.22.1" # TODO: GHSA-7gcf-g7xr-8hxj (serde_with <3.21.0) is unfixable from here — the 2.x pin lives in # dashcore-rpc-json (dashpay/rust-dashcore, rpc-json/Cargo.toml). Re-check when these pins move. -dash-sdk = { git = "https://github.com/dashpay/platform", rev = "a18bd1586858ef680124e150caad6a7dc21d0b64", features = [ +dash-sdk = { git = "https://github.com/dashpay/platform", rev = "762c66cf7716b9b3264868a49e8d29991c643c7e", features = [ "core_key_wallet", "core_key_wallet_manager", "core_bincode", @@ -30,12 +30,12 @@ dash-sdk = { git = "https://github.com/dashpay/platform", rev = "a18bd1586858ef6 "core_spv", "shielded", ] } -rs-sdk-trusted-context-provider = { git = "https://github.com/dashpay/platform", rev = "a18bd1586858ef680124e150caad6a7dc21d0b64" } -platform-wallet = { git = "https://github.com/dashpay/platform", rev = "a18bd1586858ef680124e150caad6a7dc21d0b64", features = [ +rs-sdk-trusted-context-provider = { git = "https://github.com/dashpay/platform", rev = "762c66cf7716b9b3264868a49e8d29991c643c7e" } +platform-wallet = { git = "https://github.com/dashpay/platform", rev = "762c66cf7716b9b3264868a49e8d29991c643c7e", features = [ "serde", "shielded", ] } -platform-wallet-storage = { git = "https://github.com/dashpay/platform", rev = "a18bd1586858ef680124e150caad6a7dc21d0b64", features = [ +platform-wallet-storage = { git = "https://github.com/dashpay/platform", rev = "762c66cf7716b9b3264868a49e8d29991c643c7e", features = [ "shielded", ] } zip32 = "0.2.0"