Skip to content

Add context.Context support to all HTTP methods #7

@dank

Description

@dank

All methods that make HTTP requests currently lack context.Context support, making it impossible for callers to cancel in-flight requests or propagate deadlines.

WaitForDeviceAuthorization is the most acute case, it blocks for up to ExpiresIn seconds with no way for callers to cancel early, making it unfit for use in any context-aware application without wrapping it in a goroutine.

This is a breaking API change for all callers, it should be released as a major version.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions