diff --git a/apps/workspace-engine/pkg/jobagents/argo/argoapp_test.go b/apps/workspace-engine/pkg/jobagents/argo/argoapp_test.go index d4fdb76c7..18381c955 100644 --- a/apps/workspace-engine/pkg/jobagents/argo/argoapp_test.go +++ b/apps/workspace-engine/pkg/jobagents/argo/argoapp_test.go @@ -286,7 +286,11 @@ func TestVerifications_ValidConfig(t *testing.T) { require.Len(t, specs, 1) assert.Equal(t, "argocd-application-health", specs[0].Name) assert.Equal(t, int32(60), specs[0].IntervalSeconds) - assert.Equal(t, 10, specs[0].Count) + assert.Equal(t, 15, specs[0].Count) + require.NotNil(t, specs[0].SuccessThreshold) + assert.Equal(t, 2, *specs[0].SuccessThreshold) + require.NotNil(t, specs[0].FailureThreshold) + assert.Equal(t, 10, *specs[0].FailureThreshold) } func TestVerifications_MissingServerUrl(t *testing.T) { diff --git a/apps/workspace-engine/pkg/jobagents/argo/argocd_verification.go b/apps/workspace-engine/pkg/jobagents/argo/argocd_verification.go index e84fd7ce9..bc2b46244 100644 --- a/apps/workspace-engine/pkg/jobagents/argo/argocd_verification.go +++ b/apps/workspace-engine/pkg/jobagents/argo/argocd_verification.go @@ -59,13 +59,15 @@ func (a *ArgoApplication) Verifications( return nil, fmt.Errorf("build argocd health check provider: %w", err) } - successThreshold := 1 + successThreshold := 2 + failureThreshold := 10 failureCondition := "result.statusCode != 200 || result.json.status.health.status == 'Degraded' || result.json.status.health.status == 'Missing'" spec := oapi.VerificationMetricSpec{ Name: "argocd-application-health", IntervalSeconds: 60, - Count: 10, + Count: 15, SuccessThreshold: &successThreshold, + FailureThreshold: &failureThreshold, SuccessCondition: "result.statusCode == 200 && result.json.status.sync.status == 'Synced' && result.json.status.health.status == 'Healthy'", FailureCondition: &failureCondition, Provider: provider,