From 28c61fffbce824e10b7215b688763cc7d9ede511 Mon Sep 17 00:00:00 2001 From: Schnuartz AI Date: Mon, 16 Nov 2026 08:18:00 +0100 Subject: [PATCH 1/5] Use Standard SeedQR for BIP-85 mnemonic export --- src/apps/bip85.py | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/apps/bip85.py b/src/apps/bip85.py index dcfe514e..f12ade49 100644 --- a/src/apps/bip85.py +++ b/src/apps/bip85.py @@ -3,7 +3,7 @@ from io import BytesIO from app import BaseApp, AppError -from embit import bip85 +from embit import bip39, bip85 from gui.common import add_button, add_button_pair, align_button_pair from gui.decorators import on_release from gui.screens import Menu, NumericScreen, QRAlert, Alert, Prompt @@ -112,8 +112,15 @@ async def menu(self, show_screen): Bip85MnemonicScreen(mnemonic=mnemonic, title=title, note=note) ) if action == Bip85MnemonicScreen.QR: + nums = [bip39.WORDLIST.index(w) for w in mnemonic.split()] + seedqr = "".join([("000" + str(n))[-4:] for n in nums]) await show_screen( - QRAlert(title=title, message=mnemonic, note=note) + QRAlert( + title="Derived mnemonic as Standard SeedQR", + message=seedqr, + qr_message=seedqr, + note=note, + ) ) elif action == Bip85MnemonicScreen.SD: fname = "bip85-%s-mnemonic-%d-%d.txt" % ( From 60e05d2aecdb7578234a7fb9873f8515e62738f6 Mon Sep 17 00:00:00 2001 From: Schnuartz AI Date: Mon, 16 Nov 2026 08:30:36 +0100 Subject: [PATCH 2/5] Simplify Standard SeedQR encoding --- src/apps/bip85.py | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/apps/bip85.py b/src/apps/bip85.py index f12ade49..76759344 100644 --- a/src/apps/bip85.py +++ b/src/apps/bip85.py @@ -112,15 +112,12 @@ async def menu(self, show_screen): Bip85MnemonicScreen(mnemonic=mnemonic, title=title, note=note) ) if action == Bip85MnemonicScreen.QR: - nums = [bip39.WORDLIST.index(w) for w in mnemonic.split()] - seedqr = "".join([("000" + str(n))[-4:] for n in nums]) + seedqr = "".join( + "%04d" % bip39.WORDLIST.index(word) + for word in mnemonic.split() + ) await show_screen( - QRAlert( - title="Derived mnemonic as Standard SeedQR", - message=seedqr, - qr_message=seedqr, - note=note, - ) + QRAlert("Derived mnemonic as Standard SeedQR", seedqr, note=note) ) elif action == Bip85MnemonicScreen.SD: fname = "bip85-%s-mnemonic-%d-%d.txt" % ( From bc556df180537b30f94831fb5b50651cf06a8e3c Mon Sep 17 00:00:00 2001 From: Schnuartz AI Date: Mon, 16 Nov 2026 09:41:52 +0100 Subject: [PATCH 3/5] Harden Standard SeedQR export and CI --- .github/workflows/test.yml | 3 ++- src/apps/bip85.py | 12 ++++++------ src/helpers.py | 7 +++++++ src/keystore/ram.py | 5 ++--- test/tests_native/__init__.py | 1 + test/tests_native/test_seedqr.py | 23 +++++++++++++++++++++++ 6 files changed, 41 insertions(+), 10 deletions(-) create mode 100644 test/tests_native/test_seedqr.py diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cd90576f..7aa4aef5 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,7 +27,8 @@ jobs: python3 -m compileall ../src ../test tests: - runs-on: ubuntu-latest + # Frozen imports segfault on 26.04, including on master. + runs-on: ubuntu-24.04 steps: - name: Checkout uses: actions/checkout@v4 diff --git a/src/apps/bip85.py b/src/apps/bip85.py index 76759344..624e93e7 100644 --- a/src/apps/bip85.py +++ b/src/apps/bip85.py @@ -3,11 +3,12 @@ from io import BytesIO from app import BaseApp, AppError -from embit import bip39, bip85 +from embit import bip85 from gui.common import add_button, add_button_pair, align_button_pair from gui.decorators import on_release from gui.screens import Menu, NumericScreen, QRAlert, Alert, Prompt from gui.screens.mnemonic import MnemonicScreen +from helpers import mnemonic_to_seedqr import platform class QRWithSD(QRAlert): @@ -112,12 +113,11 @@ async def menu(self, show_screen): Bip85MnemonicScreen(mnemonic=mnemonic, title=title, note=note) ) if action == Bip85MnemonicScreen.QR: - seedqr = "".join( - "%04d" % bip39.WORDLIST.index(word) - for word in mnemonic.split() - ) + seedqr = mnemonic_to_seedqr(mnemonic) + if num_words == 18: + note += "\nSeedSigner supports only 12/24-word SeedQRs." await show_screen( - QRAlert("Derived mnemonic as Standard SeedQR", seedqr, note=note) + QRAlert("%s as Standard SeedQR" % title, seedqr, note=note) ) elif action == Bip85MnemonicScreen.SD: fname = "bip85-%s-mnemonic-%d-%d.txt" % ( diff --git a/src/helpers.py b/src/helpers.py index 3f4f134e..09b3072a 100644 --- a/src/helpers.py +++ b/src/helpers.py @@ -30,6 +30,13 @@ def fix_mnemonic(phrase): return bip39.mnemonic_from_bytes(entropy) +def mnemonic_to_seedqr(mnemonic): + """Encode a BIP39 mnemonic as a Standard SeedQR digit string.""" + return "".join( + "%04d" % bip39.WORDLIST.index(word) for word in mnemonic.split() + ) + + def tagged_hash(tag: str, data: bytes) -> bytes: """BIP-Schnorr tag-specific key derivation""" hashtag = hashlib.sha256(tag.encode()).digest() diff --git a/src/keystore/ram.py b/src/keystore/ram.py index 1806da5f..c6d30b82 100644 --- a/src/keystore/ram.py +++ b/src/keystore/ram.py @@ -6,7 +6,7 @@ from embit import ec, bip39, bip32 from embit.liquid import slip77 from embit.transaction import SIGHASH -from helpers import aead_encrypt, aead_decrypt, tagged_hash +from helpers import aead_encrypt, aead_decrypt, mnemonic_to_seedqr, tagged_hash import secp256k1 from gui.screens import Alert, PinScreen, Prompt, Menu, QRAlert from gui.screens.mnemonic import ExportMnemonicScreen @@ -384,8 +384,7 @@ async def show_mnemonic(self): if v == 255: return elif v == 1: - nums = [bip39.WORDLIST.index(w) for w in self.mnemonic.split()] - qr_msg = "".join([("000"+str(n))[-4:] for n in nums]) + qr_msg = mnemonic_to_seedqr(self.mnemonic) msg = qr_msg elif v == 2: qr_msg = bip39.mnemonic_to_bytes(self.mnemonic) diff --git a/test/tests_native/__init__.py b/test/tests_native/__init__.py index dd0f719f..b9d9dc54 100644 --- a/test/tests_native/__init__.py +++ b/test/tests_native/__init__.py @@ -6,3 +6,4 @@ from .test_transaction_confirmation import * from .test_change_security import * from .test_embed_git_info import * +from .test_seedqr import * diff --git a/test/tests_native/test_seedqr.py b/test/tests_native/test_seedqr.py new file mode 100644 index 00000000..e8e917d3 --- /dev/null +++ b/test/tests_native/test_seedqr.py @@ -0,0 +1,23 @@ +from unittest import TestCase + +from embit import bip39 +from helpers import mnemonic_to_seedqr + + +class SeedQRTest(TestCase): + def test_seedqr_uses_zero_based_four_digit_indices(self): + mnemonic = "abandon abuse access zoo" + self.assertEqual(mnemonic_to_seedqr(mnemonic), "0000000900102047") + + def test_seedqr_round_trips_bip39_word_counts(self): + for word_count in (12, 18, 24): + entropy = bytes(word_count * 4 // 3) + mnemonic = bip39.mnemonic_from_bytes(entropy) + seedqr = mnemonic_to_seedqr(mnemonic) + decoded = " ".join( + bip39.WORDLIST[int(seedqr[i:i + 4])] + for i in range(0, len(seedqr), 4) + ) + self.assertEqual(len(seedqr), word_count * 4) + self.assertEqual(decoded, mnemonic) + self.assertEqual(bip39.mnemonic_to_bytes(decoded), entropy) From 92e9462b62ddc5649d2e0881db215549c7b883b6 Mon Sep 17 00:00:00 2001 From: Schnuartz AI Date: Mon, 16 Nov 2026 12:43:32 +0100 Subject: [PATCH 4/5] Name mnemonic QR encoders by format --- src/apps/bip85.py | 4 ++-- src/helpers.py | 7 ++++++- src/keystore/ram.py | 12 +++++++++--- test/tests_native/test_seedqr.py | 12 +++++++----- 4 files changed, 24 insertions(+), 11 deletions(-) diff --git a/src/apps/bip85.py b/src/apps/bip85.py index 624e93e7..caa61cfa 100644 --- a/src/apps/bip85.py +++ b/src/apps/bip85.py @@ -8,7 +8,7 @@ from gui.decorators import on_release from gui.screens import Menu, NumericScreen, QRAlert, Alert, Prompt from gui.screens.mnemonic import MnemonicScreen -from helpers import mnemonic_to_seedqr +from helpers import mnemonic_to_standard_seedqr import platform class QRWithSD(QRAlert): @@ -113,7 +113,7 @@ async def menu(self, show_screen): Bip85MnemonicScreen(mnemonic=mnemonic, title=title, note=note) ) if action == Bip85MnemonicScreen.QR: - seedqr = mnemonic_to_seedqr(mnemonic) + seedqr = mnemonic_to_standard_seedqr(mnemonic) if num_words == 18: note += "\nSeedSigner supports only 12/24-word SeedQRs." await show_screen( diff --git a/src/helpers.py b/src/helpers.py index 09b3072a..506d213d 100644 --- a/src/helpers.py +++ b/src/helpers.py @@ -30,13 +30,18 @@ def fix_mnemonic(phrase): return bip39.mnemonic_from_bytes(entropy) -def mnemonic_to_seedqr(mnemonic): +def mnemonic_to_standard_seedqr(mnemonic): """Encode a BIP39 mnemonic as a Standard SeedQR digit string.""" return "".join( "%04d" % bip39.WORDLIST.index(word) for word in mnemonic.split() ) +def mnemonic_to_compact_seedqr(mnemonic): + """Return BIP39 entropy bytes for a Compact SeedQR.""" + return bip39.mnemonic_to_bytes(mnemonic) + + def tagged_hash(tag: str, data: bytes) -> bytes: """BIP-Schnorr tag-specific key derivation""" hashtag = hashlib.sha256(tag.encode()).digest() diff --git a/src/keystore/ram.py b/src/keystore/ram.py index c6d30b82..6b05b37d 100644 --- a/src/keystore/ram.py +++ b/src/keystore/ram.py @@ -6,7 +6,13 @@ from embit import ec, bip39, bip32 from embit.liquid import slip77 from embit.transaction import SIGHASH -from helpers import aead_encrypt, aead_decrypt, mnemonic_to_seedqr, tagged_hash +from helpers import ( + aead_encrypt, + aead_decrypt, + mnemonic_to_compact_seedqr, + mnemonic_to_standard_seedqr, + tagged_hash, +) import secp256k1 from gui.screens import Alert, PinScreen, Prompt, Menu, QRAlert from gui.screens.mnemonic import ExportMnemonicScreen @@ -384,10 +390,10 @@ async def show_mnemonic(self): if v == 255: return elif v == 1: - qr_msg = mnemonic_to_seedqr(self.mnemonic) + qr_msg = mnemonic_to_standard_seedqr(self.mnemonic) msg = qr_msg elif v == 2: - qr_msg = bip39.mnemonic_to_bytes(self.mnemonic) + qr_msg = mnemonic_to_compact_seedqr(self.mnemonic) msg = hexlify(qr_msg).decode() elif v == 3: qr_msg = self.mnemonic diff --git a/test/tests_native/test_seedqr.py b/test/tests_native/test_seedqr.py index e8e917d3..abf32e62 100644 --- a/test/tests_native/test_seedqr.py +++ b/test/tests_native/test_seedqr.py @@ -1,19 +1,20 @@ from unittest import TestCase from embit import bip39 -from helpers import mnemonic_to_seedqr +from helpers import mnemonic_to_compact_seedqr, mnemonic_to_standard_seedqr class SeedQRTest(TestCase): - def test_seedqr_uses_zero_based_four_digit_indices(self): + def test_standard_seedqr_uses_zero_based_four_digit_indices(self): mnemonic = "abandon abuse access zoo" - self.assertEqual(mnemonic_to_seedqr(mnemonic), "0000000900102047") + self.assertEqual(mnemonic_to_standard_seedqr(mnemonic), "0000000900102047") - def test_seedqr_round_trips_bip39_word_counts(self): + def test_standard_and_compact_seedqr_preserve_bip39_entropy(self): for word_count in (12, 18, 24): entropy = bytes(word_count * 4 // 3) mnemonic = bip39.mnemonic_from_bytes(entropy) - seedqr = mnemonic_to_seedqr(mnemonic) + seedqr = mnemonic_to_standard_seedqr(mnemonic) + compact_seedqr = mnemonic_to_compact_seedqr(mnemonic) decoded = " ".join( bip39.WORDLIST[int(seedqr[i:i + 4])] for i in range(0, len(seedqr), 4) @@ -21,3 +22,4 @@ def test_seedqr_round_trips_bip39_word_counts(self): self.assertEqual(len(seedqr), word_count * 4) self.assertEqual(decoded, mnemonic) self.assertEqual(bip39.mnemonic_to_bytes(decoded), entropy) + self.assertEqual(compact_seedqr, entropy) From a307fd7db27abe7352d0229502b7699f9a6cfb52 Mon Sep 17 00:00:00 2001 From: Schnuartz AI Date: Mon, 16 Nov 2026 13:48:15 +0100 Subject: [PATCH 5/5] Remove misleading SeedSigner QR warning --- src/apps/bip85.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/apps/bip85.py b/src/apps/bip85.py index caa61cfa..2d6c8125 100644 --- a/src/apps/bip85.py +++ b/src/apps/bip85.py @@ -114,8 +114,6 @@ async def menu(self, show_screen): ) if action == Bip85MnemonicScreen.QR: seedqr = mnemonic_to_standard_seedqr(mnemonic) - if num_words == 18: - note += "\nSeedSigner supports only 12/24-word SeedQRs." await show_screen( QRAlert("%s as Standard SeedQR" % title, seedqr, note=note) )