From 51b957ad800ad0f3be122bcdde33f662c97c0118 Mon Sep 17 00:00:00 2001 From: Xianpeng Shen Date: Wed, 30 Sep 2026 13:01:47 +0300 Subject: [PATCH] docs: drop the note that thread comments are disabled on private repositories The `thread-comments` input said the feature is disabled on private repositories. cpp-linter has no such check any more: its requests ask for `application/vnd.github.raw+json`, which addressed #142, and nothing in `rest_api` looks at the repository's visibility. Following @2bndy5's suggestion on cpp-linter/cpp-linter.github.io#62, I ran the action on a private repository in the organization, cpp-linter/test-cpp-linter-action-private, with `thread-comments: update`: | Round | Push | Result | | --- | --- | --- | | 1 | code with one clang-format issue and two clang-tidy findings | github-actions[bot] posted one "Cpp-Linter Report" comment (run 36699441415) | | 2 | another function with findings | the same comment was edited (3 concerns); no second comment (run 36699583265) | | 3 | every finding fixed | the comment was deleted, as `no-lgtm: true` asks (run 36699719604) | All three runs passed, and their logs show no error from posting, editing or deleting the comment (the `##[warning]` lines are the file annotations for the findings). The workflow sets `permissions: pull-requests: write`; a repository whose default `GITHUB_TOKEN` is read-only needs that, as [documented](https://github.com/cpp-linter/cpp-linter-action/blob/main/docs/permissions.md). So the note is removed. The permissions note in `docs/permissions.md` (supply `GITHUB_TOKEN` on private repositories) stays; it is still true. --- action.yml | 3 --- 1 file changed, 3 deletions(-) diff --git a/action.yml b/action.yml index 7ef45600..6c9289e0 100644 --- a/action.yml +++ b/action.yml @@ -121,9 +121,6 @@ inputs: !!! info "Important" This feature requires special permissions to perform successfully. See our [documented permissions](permissions.md) - - > [!NOTE] - > If run on a private repository, then this feature is disabled because the GitHub REST API behaves differently for thread comments on a private repository. required: false default: 'false' no-lgtm: