Summary
Two leftovers that do not break anything but cost attention on every read:
PythonEnvironmentException::missingDependencies(string $details) is never called from src/. Its only reference is the unit test that asserts its message (tests/Unit/Exceptions/ExceptionHierarchyTest.php:66). AetherInstallCommand reports missing Braket dependencies through console output instead.composer.json allows orchestra/testbench: ^10.0|^11.0, but testbench 10.x requires laravel/framework ^12 while this package requires illuminate/* ^13.0. Composer can never select the ^10.0 branch, so the constraint documents a compatibility that does not exist.
Where
src/Exceptions/PythonEnvironmentException.php:23-26tests/Unit/Exceptions/ExceptionHierarchyTest.php:66composer.json:28
Why it is a problem
Dead factories on an exception class suggest a code path that a reader will look for and not find. A dead version range misleads anyone checking which Laravel versions the package supports. Neither is a defect, both are noise in a package that aims to be a reference implementation.
Suggested fix
Either wire missingDependencies() into AetherInstallCommand::checkDependencies() (throwing it in non-interactive mode when Braket is absent would give scripted installs a real failure signal) or delete it together with its test. Narrow the testbench constraint to ^11.0.
Severity: low
Summary
Two leftovers that do not break anything but cost attention on every read:
PythonEnvironmentException::missingDependencies(string $details)is never called fromsrc/. Its only reference is the unit test that asserts its message (tests/Unit/Exceptions/ExceptionHierarchyTest.php:66).AetherInstallCommandreports missing Braket dependencies through console output instead.composer.jsonallowsorchestra/testbench: ^10.0|^11.0, but testbench 10.x requireslaravel/framework ^12while this package requiresilluminate/* ^13.0. Composer can never select the^10.0branch, so the constraint documents a compatibility that does not exist.Where
src/Exceptions/PythonEnvironmentException.php:23-26tests/Unit/Exceptions/ExceptionHierarchyTest.php:66composer.json:28Why it is a problem
Dead factories on an exception class suggest a code path that a reader will look for and not find. A dead version range misleads anyone checking which Laravel versions the package supports. Neither is a defect, both are noise in a package that aims to be a reference implementation.
Suggested fix
Either wire
missingDependencies()intoAetherInstallCommand::checkDependencies()(throwing it in non-interactive mode when Braket is absent would give scripted installs a real failure signal) or delete it together with its test. Narrow the testbench constraint to^11.0.Severity: low