Skip to content

Added new option tabAutocomplete#142

Closed
Artistan wants to merge 1 commit into
corejavascript:masterfrom
Artistan:tabAutocompleteOptional
Closed

Added new option tabAutocomplete#142
Artistan wants to merge 1 commit into
corejavascript:masterfrom
Artistan:tabAutocompleteOptional

Conversation

@Artistan

Copy link
Copy Markdown

same update as #77 but without conflicts.
credit --> @Darnokk https://github.com/Darnokk

  - The default behaviour of the TAB-key is to select the top suggestion
  - We introduced a new option called 'tabAutocomplete' which is NOT mandatory and defaults to true.
  - If the option 'tabAutocomplete' is true, the TAB-key will select the top suggestion as usual
  - If the option 'tabAutocomplete' is NOT set, the TAB-key will select the top suggestion as usual
  - Only if you set the option 'tabAutocomplete' to false pressing the TAB key will change the focus on the html-element with the next tabindex.
  - Added option 'tabAutocomplete' to doc
  - Added two methods for tabAutocomplete = true resp. false to the unit-test typeahead_spec.js

@jlbooker jlbooker added this to the v1.2.0 milestone Jun 1, 2017
@Artistan

Artistan commented Jun 5, 2017

Copy link
Copy Markdown
Author

here is a bit of a work-around for anyone looking to allow for "not autocompleting".

https://codepen.io/Artistan/pen/LywrXj

@jcrben

jcrben commented Jul 21, 2017

Copy link
Copy Markdown
Contributor

Seems cool, but why the changes to the minified files and the stuff like typeof exports === "object"?

Also, are you interested in becoming a maintainer? I no longer use this library.

@Darnokk

Darnokk commented Jul 21, 2017

Copy link
Copy Markdown

I tested your dist/typeahead.bundle.js and saw no difference in the behaviour, when tabAutocomplete = true/false,
maybe there is a slightly mistake in there?

@Artistan

Copy link
Copy Markdown
Author

no longer using... on to other things.

@Artistan Artistan closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants