From d20414e154db50c615c318e9c91fa3a0f919f1e9 Mon Sep 17 00:00:00 2001 From: Brandon McAnsh Date: Thu, 3 Sep 2026 22:47:26 -0400 Subject: [PATCH] fix(userflags): give the message window overrides their test cases Making the edit and delete windows overridable (#1403) added messageEditWindow and messageDeleteWindow to Overrides without adding matching entries to OverrideCases. The guard test that exists to catch exactly that has failed on code/cash since the merge, taking the userflags module's test task down on every PR. Adding the two cases restores the guard and puts the fields under the resolve() checks the rest of the list gets. Both override values differ from the server baseline, per the note above the list, so a field reading the wrong override cannot pass by coincidence. --- .../flipcash/app/userflags/ResolvedUserFlagsTest.kt | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/apps/flipcash/shared/userflags/src/test/kotlin/com/flipcash/app/userflags/ResolvedUserFlagsTest.kt b/apps/flipcash/shared/userflags/src/test/kotlin/com/flipcash/app/userflags/ResolvedUserFlagsTest.kt index 3c6441187..aecab23cb 100644 --- a/apps/flipcash/shared/userflags/src/test/kotlin/com/flipcash/app/userflags/ResolvedUserFlagsTest.kt +++ b/apps/flipcash/shared/userflags/src/test/kotlin/com/flipcash/app/userflags/ResolvedUserFlagsTest.kt @@ -211,4 +211,16 @@ private val OverrideCases: List> = listOf( set = { copy(requireCoinbaseEmailVerification = it) }, select = { it.requireCoinbaseEmailVerification }, ), + OverrideCase( + name = "messageEditWindow", + overrideValue = 45.seconds, + set = { copy(messageEditWindow = it) }, + select = { it.messageEditWindow }, + ), + OverrideCase( + name = "messageDeleteWindow", + overrideValue = 120.seconds, + set = { copy(messageDeleteWindow = it) }, + select = { it.messageDeleteWindow }, + ), )