Skip to content

Commit b0ce919

Browse files
cmcWebCode40claude
andcommitted
fix: resolve dark theme toggle and add delete button for individual logs
Fix dark theme toggle not working due to incorrect theme state logic - the toggle now properly uses internalTheme state instead of the prop. Add delete button (✕ icon) to each network log item header, allowing users to remove individual requests without additional dependencies like gesture handlers. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 4b1944a commit b0ce919

4 files changed

Lines changed: 57 additions & 5 deletions

File tree

‎src/NetworkInterceptor.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -314,6 +314,11 @@ class NetworkLogger {
314314
this.listeners.forEach((listener: LogListener) => listener([]));
315315
}
316316

317+
public deleteLog(logId: number): void {
318+
this.logs = this.logs.filter((log) => log.id !== logId);
319+
this.listeners.forEach((listener: LogListener) => listener([...this.logs]));
320+
}
321+
317322
public enable(): void {
318323
this.isEnabled = true;
319324
}

‎src/NetworkLogItem.tsx‎

Lines changed: 37 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,7 @@ interface NetworkLogItemProps {
3232
showResponseHeader?: boolean;
3333
useCopyToClipboard?: boolean;
3434
theme?: ThemeMode;
35+
onDelete?: (logId: number) => void;
3536
}
3637

3738
const NetworkLogItem: React.FC<NetworkLogItemProps> = ({
@@ -40,6 +41,7 @@ const NetworkLogItem: React.FC<NetworkLogItemProps> = ({
4041
showResponseHeader = false,
4142
showRequestHeader = false,
4243
theme = 'light',
44+
onDelete,
4345
}) => {
4446
const [expanded, setExpanded] = useState<boolean>(false);
4547
const [isReplaying, setIsReplaying] = useState<boolean>(false);
@@ -111,6 +113,10 @@ const NetworkLogItem: React.FC<NetworkLogItemProps> = ({
111113
}
112114
}, [log]);
113115

116+
const handleDelete = useCallback(() => {
117+
onDelete?.(log.id);
118+
}, [log.id, onDelete]);
119+
114120
const formatHeaders = (headers?: NetworkRequestHeaders): string => {
115121
if (!headers || typeof headers !== 'object') return 'No headers';
116122
return Object.entries(headers)
@@ -185,7 +191,19 @@ const NetworkLogItem: React.FC<NetworkLogItemProps> = ({
185191
)}
186192
</View>
187193
</View>
188-
<Icon type={expanded ? 'chevronDown' : 'chevronUp'} />
194+
<View style={staticStyles.headerActions}>
195+
{onDelete && (
196+
<TouchableOpacity
197+
style={staticStyles.deleteButton}
198+
onPress={handleDelete}
199+
activeOpacity={0.7}
200+
hitSlop={{ top: 8, bottom: 8, left: 8, right: 8 }}
201+
>
202+
<Text style={staticStyles.deleteButtonText}>✕</Text>
203+
</TouchableOpacity>
204+
)}
205+
<Icon type={expanded ? 'chevronDown' : 'chevronUp'} />
206+
</View>
189207
</TouchableOpacity>
190208

191209
{expanded && (
@@ -389,6 +407,24 @@ const staticStyles = {
389407
fontSize: 14,
390408
fontWeight: '600',
391409
} as TextStyle,
410+
headerActions: {
411+
flexDirection: 'row',
412+
alignItems: 'center',
413+
gap: 8,
414+
} as ViewStyle,
415+
deleteButton: {
416+
width: 24,
417+
height: 24,
418+
borderRadius: 12,
419+
backgroundColor: colors.error,
420+
justifyContent: 'center',
421+
alignItems: 'center',
422+
} as ViewStyle,
423+
deleteButtonText: {
424+
color: '#fff',
425+
fontSize: 12,
426+
fontWeight: 'bold',
427+
} as TextStyle,
392428
statusContainer: {
393429
flexDirection: 'row',
394430
alignItems: 'center',

‎src/NetworkLoggerOverlay.tsx‎

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -65,24 +65,26 @@ export const NetworkLoggerOverlay: React.FC<NetworkLoggerOverlayProps> = ({
6565
showRequestHeader,
6666
showResponseHeader,
6767
useCopyToClipboard,
68-
theme: themeProp = 'light',
68+
theme: themeProp,
6969
onThemeChange,
7070
}) => {
7171
const [visible, setVisible] = useState<boolean>(false);
7272
const [logs, setLogs] = useState<NetworkLog[]>([]);
7373
const [filters, setFilters] = useState<FilterState>(defaultFilterState);
7474
const [showButton, setShowButton] = useState<boolean>(!enableDeviceShake);
75-
const [internalTheme, setInternalTheme] = useState<ThemeMode>(themeProp);
75+
const [internalTheme, setInternalTheme] = useState<ThemeMode>(
76+
themeProp ?? 'light'
77+
);
7678
const [exportModalVisible, setExportModalVisible] = useState<boolean>(false);
7779

7880
const theme = themeProp ?? internalTheme;
7981
const themeColors = useMemo(() => getThemeColors(theme), [theme]);
8082

8183
const toggleTheme = useCallback(() => {
82-
const newTheme = theme === 'light' ? 'dark' : 'light';
84+
const newTheme = internalTheme === 'light' ? 'dark' : 'light';
8385
setInternalTheme(newTheme);
8486
onThemeChange?.(newTheme);
85-
}, [theme, onThemeChange]);
87+
}, [internalTheme, onThemeChange]);
8688

8789
const themedStyles = useMemo(
8890
() => createThemedStyles(themeColors),
@@ -165,6 +167,13 @@ export const NetworkLoggerOverlay: React.FC<NetworkLoggerOverlayProps> = ({
165167
);
166168
}, [networkLogger]);
167169

170+
const handleDeleteLog = useCallback(
171+
(logId: number): void => {
172+
networkLogger.deleteLog(logId);
173+
},
174+
[networkLogger]
175+
);
176+
168177
const handleModalOpen = useCallback((): void => {
169178
setVisible(true);
170179
}, []);
@@ -198,6 +207,7 @@ export const NetworkLoggerOverlay: React.FC<NetworkLoggerOverlayProps> = ({
198207
showResponseHeader={showResponseHeader}
199208
showRequestHeader={showRequestHeader}
200209
theme={theme}
210+
onDelete={handleDeleteLog}
201211
/>
202212
);
203213

‎src/types.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ export interface NetworkLoggerConfig {
4040
export interface NetworkLogger {
4141
subscribe: (listener: LogListener) => () => void;
4242
clearLogs: () => void;
43+
deleteLog: (logId: number) => void;
4344
enable: () => void;
4445
disable: () => void;
4546
getLogs?: () => NetworkLog[];

0 commit comments

Comments
 (0)