feat(admin): add Triggers API for webhook notification management#130
Open
NitriKx wants to merge 1 commit into
Open
feat(admin): add Triggers API for webhook notification management#130NitriKx wants to merge 1 commit into
NitriKx wants to merge 1 commit into
Conversation
Member
|
@NitriKx great PR! Would you mind adding a few specs for the newly added APIs? |
NitriKx
force-pushed
the
bsa/add-triggers-webhook-api
branch
from
1579cd8 to
abbd800
Compare
Adds typed bindings for the Cloudinary /triggers endpoint: ListTriggers, GetTrigger, CreateTrigger, UpdateTrigger, DeleteTrigger. Supports filter (JSONLogic), payload_template (Mustache), auth_scheme, and additive flag. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
NitriKx
force-pushed
the
bsa/add-triggers-webhook-api
branch
from
abbd800 to
06db2ef
Compare
Contributor
Author
|
Hello @const-cloudinary 👋 I've added few tests (inspired from what has been done for the folders) |
Contributor
Author
|
Heey 👋 Can we merge this? |
const-cloudinary
requested changes
May 24, 2026
Member
const-cloudinary
left a comment
const-cloudinary
left a comment
There was a problem hiding this comment.
@NitriKx Great PR overall!
Please drop GetTrigger (see comment) and we are good to merge and release it.
| // GetTrigger retrieves a single webhook notification trigger by its ID. | ||
| // Cloudinary does not expose a single-resource GET endpoint, so this is | ||
| // implemented as ListTriggers filtered to the matching ID. | ||
| func (a *API) GetTrigger(ctx context.Context, params GetTriggerParams) (*GetTriggerResult, error) { |
Member
There was a problem hiding this comment.
Let's drop this one. The API itself doesn't support it.
Current implementation is trivial, anyone can implement it in their code.
The real reason for dropping it, is if/when it will be implemented in the API side, it might have different structure and it will introduce a breaking change, which we would like to avoid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds full CRUD operations for the Cloudinary webhook notification triggers endpoint (
/v1_1/{cloud}/triggers)Tested against the live Cloudinary API via a Terraform provider integration (create + update + delete round-trip).