CLJS-2385: cljs.analyzer/infer-type pass infers tag with incorrect priority

Author: dnolen

src/main/clojure/cljs/analyzer.cljc

@@ -1198,11 +1198,11 @@
   {:op :constant :env env :form sym :tag 'cljs.core/Keyword})
 
 (defn get-tag [e]
-  (if-some [tag (-> e :tag)]
+  (if-some [tag (-> e :form meta :tag)]
+    tag
+    (if-some [tag (-> e :tag)]
       tag
-      (if-some [tag (-> e :info :tag)]
-          tag
-          (-> e :form meta :tag))))
+      (-> e :info :tag))))
 
 (defn find-matching-method [f params]
   ;; if local fn, need to look in :info

src/test/clojure/cljs/analyzer_tests.clj

@@ -1022,3 +1022,15 @@
                :warnings ws
                :with-core? true})]
     (is (zero? (count @ws)))))
+
+(deftest test-cljs-2385-infer-priority
+  (let [ws  (atom [])
+        res (infer-test-helper
+              {:forms '[(ns cjls-1918.core)
+                        (defn thing [{:as this}]
+                          (.componentDidUpdate ^js/Thing this))]
+               :externs ["src/test/externs/test.js"]
+               :warnings ws
+               :with-core? true})]
+    (is (string/includes? res "Thing.prototype.componentDidUpdate;"))
+    (is (zero? (count @ws)))))