Skip to content

Commit a29e19d

Browse files
committed
CLJS-2242: Lots of undeclared Var warns in cljs.spec.gen.alpha
Revert last commit. We must analyze deps before loading requires. Instead update c.a/analyze-deps to check js-module-exists?
1 parent 3cf960b commit a29e19d

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

src/main/clojure/cljs/analyzer.cljc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2103,6 +2103,7 @@
21032103
(when-not (or (not-empty (get-in compiler [::namespaces dep :defs]))
21042104
(contains? (:js-dependency-index compiler) (name dep))
21052105
(contains? (:node-module-index compiler) (name dep))
2106+
(js-module-exists? (name dep))
21062107
#?(:clj (deps/find-classpath-lib dep)))
21072108
#?(:clj (if-some [src (locate-src dep)]
21082109
(analyze-file src opts)

src/main/clojure/cljs/repl.cljc

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -493,9 +493,11 @@
493493
;; NOTE: means macros which expand to ns aren't supported for now
494494
;; when eval'ing individual forms at the REPL - David
495495
(when (#{:ns :ns*} (:op ast))
496-
(load-dependencies repl-env
497-
(into (vals (:requires ast)) (distinct (vals (:uses ast))))
498-
opts))
496+
(let [ast (ana/no-warn (ana/analyze env form nil opts))]
497+
(load-dependencies repl-env
498+
(into (vals (:requires ast))
499+
(distinct (vals (:uses ast))))
500+
opts)))
499501
(when *cljs-verbose*
500502
(err-out (println wrap-js)))
501503
(let [ret (-evaluate repl-env filename (:line (meta form)) wrap-js)]

0 commit comments

Comments
 (0)