CLJS-2708: Windows. ClojureScript fails to compile when node.js module is required

Author: mfikes

src/main/cljs/cljs/module_deps.js

@@ -1,3 +1,8 @@
+// NOTE: This code should only employ single quotes for strings.
+// If double quotes are used, then when the contents of this file
+// are passed to node via --eval on Windows, the double quotes
+// will be elided, leading to syntactically incorrect JavaScript.
+
 let fs = require('fs');
 let path = require('path');
 let mdeps = require('@cljs-oss/module-deps');
@@ -82,7 +87,7 @@ let md = mdeps({
     },
     filter: function (id) {
         return !(target === 'nodejs' && nodeResolve.isCore(id)) &&
-            !id.startsWith("goog:");
+            !id.startsWith('goog:');
     },
     detect: function (src) {
         let deps = getDeps(src);

src/main/clojure/cljs/closure.clj

@@ -2348,8 +2348,12 @@
      (when env/*compiler*
        (:options @env/*compiler*))))
   ([{:keys [file]} {:keys [target] :as opts}]
+   ;; NOTE: The code value should only employ single quotes for strings.
+   ;; If double quotes are used, then when the contents of this file
+   ;; are passed to node via --eval on Windows, the double quotes
+   ;; will be elided, leading to syntactically incorrect JavaScript.
    (let [main-entries (str "[" (->> (package-json-entries opts)
-                                    (map #(str "\"" % "\""))
+                                    (map #(str "'" % "'"))
                                     (string/join ",")) "]")
          code (-> (slurp (io/resource "cljs/module_deps.js"))
                 (string/replace "JS_FILE" (string/replace file "\\" "\\\\"))