Skip to content

Commit 88e1f39

Browse files
anmonteiroswannodette
authored andcommitted
CLJS-2333: module-deps.js doesn't correctly compute main if aliased in browser field
1 parent 98656d3 commit 88e1f39

2 files changed

Lines changed: 29 additions & 1 deletion

File tree

src/main/cljs/cljs/module_deps.js

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,12 @@ md.on('end', function () {
199199
const replacement = path.resolve(pkgJson.basedir, fieldValue[key]);
200200

201201
if (deps_files[replacement] != null) {
202-
deps_files[replacement].provides = depProvides(deps_files[replacement].provides, path.resolve(pkgJson.basedir, key));
202+
const file = path.resolve(pkgJson.basedir, key);
203+
deps_files[replacement].provides = depProvides(deps_files[replacement].provides, file);
204+
205+
if (file === pkgJson.mainEntry) {
206+
Array.prototype.push.apply(deps_files[replacement].provides, pkgJson.provides);
207+
}
203208
}
204209
}
205210
}

src/test/clojure/cljs/closure_tests.clj

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -387,3 +387,26 @@
387387
(.delete (io/file "package.json"))
388388
(test/delete-node-modules)
389389
(test/delete-out-files out)))
390+
391+
(deftest test-cljs-2333
392+
(spit (io/file "package.json") "{}")
393+
(let [opts {:npm-deps {"asap" "2.0.6"}}
394+
out (util/output-directory opts)]
395+
(test/delete-node-modules)
396+
(test/delete-out-files out)
397+
(closure/maybe-install-node-deps! opts)
398+
(let [modules (closure/index-node-modules ["asap"] opts)]
399+
(is (true? (some (fn [module]
400+
(= module {:module-type :es6
401+
:file (.getAbsolutePath (io/file "node_modules/asap/browser-asap.js"))
402+
:provides ["asap/asap",
403+
"asap/asap",
404+
"asap/asap.js",
405+
"asap/asap",
406+
"asap",
407+
"asap/browser-asap.js",
408+
"asap/browser-asap"]}))
409+
modules))))
410+
(.delete (io/file "package.json"))
411+
(test/delete-node-modules)
412+
(test/delete-out-files out)))

0 commit comments

Comments
 (0)