CLJS-3144: NPM Modules should have all their vars marked to avoid .call invokes

add new var information to vars resolved from Node or global foreign modules -
mark them as :foreign true.

In the compiler if a f is :foreign, then do not emit the .call convention.
By doing this we avoid issues when the library itself is a singleton
instance as .call convention breaks `this`.

Author: swannodette

src/main/clojure/cljs/analyzer.cljc

@@ -1071,21 +1071,22 @@
 
 (defmethod resolve* :node
   [env sym full-ns current-ns]
-  {:name (symbol (str current-ns) (str (munge-node-lib full-ns) "." (name sym)))
+  {:ns current-ns
+   :name (symbol (str current-ns) (str (munge-node-lib full-ns) "." (name sym)))
    :op :js-var
-   :ns current-ns
-   :tag 'js})
+   :foreign true})
 
 (defmethod resolve* :global
   [env sym full-ns current-ns]
   (let [pre (into '[Object] (->> (string/split (name sym) #"\.") (map symbol) vec))]
     (when-not (has-extern? pre)
       (swap! env/*compiler* update-in
         (into [::namespaces current-ns :externs] pre) merge {}))
-    {:name (symbol (str current-ns) (str (munge-global-export full-ns) "." (name sym)))
+    {:ns current-ns
+     :name (symbol (str current-ns) (str (munge-global-export full-ns) "." (name sym)))
      :op :js-var
-     :ns current-ns
-     :tag (with-meta 'js {:prefix pre})}))
+     :tag (with-meta 'js {:prefix pre})
+     :foreign true}))
 
 (def ^:private private-var-access-exceptions
   "Specially-treated symbols for which we don't trigger :private-var-access warnings."

src/main/clojure/cljs/compiler.cljc

@@ -1142,7 +1142,7 @@
         opt-count? (and (= (:name info) 'cljs.core/count)
                         (boolean ('#{string array} first-arg-tag)))
         ns (:ns info)
-        js? (or (= ns 'js) (= ns 'Math) (= tag 'js))
+        js? (or (= ns 'js) (= ns 'Math) (:foreign info)) ;; foreign - i.e. global / Node.js library
         goog? (when ns
                 (or (= ns 'goog)
                     (when-let [ns-str (str ns)]

src/test/clojure/cljs/build_api_tests.clj

@@ -286,6 +286,30 @@
   (.delete (io/file "package.json"))
   (test/delete-node-modules))
 
+(deftest test-npm-deps-invoke-cljs-3144
+  (test/delete-node-modules)
+  (spit (io/file "package.json") "{}")
+  (let [cenv (env/default-compiler-env)
+        out (.getPath (io/file "test-out" #_(test/tmp-dir) "npm-deps-test-out"))
+        {:keys [inputs opts]} {:inputs (str (io/file "src" "test" "cljs_build"))
+                               :opts {:main 'npm-deps-test.invoke
+                                      :output-dir out
+                                      :optimizations :none
+                                      :install-deps true
+                                      :npm-deps {:react "15.6.1"
+                                                 :react-dom "15.6.1"
+                                                 :lodash-es "4.17.4"
+                                                 :lodash "4.17.4"}
+                                      :closure-warnings {:check-types :off
+                                                         :non-standard-jsdoc :off}}}]
+    (test/delete-out-files out)
+    (testing "invoking fns from Node.js libraries should not emit .call convention"
+      (build/build (build/inputs (io/file inputs "npm_deps_test/invoke.cljs")) opts cenv)
+      (is (.exists (io/file out "node_modules/react/react.js")))
+      (is (not (string/includes? (slurp (io/file out "npm_deps_test/invoke.cljs")) "call")))))
+  (.delete (io/file "package.json"))
+  (test/delete-node-modules))
+
 (deftest test-preloads
   (let [out (.getPath (io/file (test/tmp-dir) "preloads-test-out"))
         {:keys [inputs opts]} {:inputs (str (io/file "src" "test" "cljs"))