CLJS-1779: keyword 2-arity constructor accepts anything for both parameters which leads to different hashing

Author: dnolen

src/main/cljs/cljs/core.cljs

@@ -3207,7 +3207,16 @@ reduces them without incurring seq initialization"
                              (if (== (alength parts) 2)
                                (Keyword. (aget parts 0) (aget parts 1) name nil)
                                (Keyword. nil (aget parts 0) name nil)))))
-  ([ns name] (Keyword. ns name (str (when ns (str ns "/")) name) nil)))
+  ([ns name]
+   (let [ns   (cond
+                (keyword? ns) (cljs.core/name ns)
+                (symbol? ns)  (cljs.core/name ns)
+                :else ns)
+         name (cond
+                (keyword? name) (cljs.core/name name)
+                (symbol? name) (cljs.core/name name)
+                :else name)]
+     (Keyword. ns name (str (when ns (str ns "/")) name) nil))))
 
 
 (deftype LazySeq [meta ^:mutable fn ^:mutable s ^:mutable __hash]

src/test/cljs/cljs/core_test.cljs

@@ -3241,6 +3241,10 @@
   (is (= foo-1274 42))
   (is (= cljs.core-test/foo-1274 42)))
 
+(deftest test-cljs-1779
+  (is (= (hash (keyword 'app "foo"))
+         (hash (keyword "app" "foo")))))
+
 (comment
   ;; ObjMap
   ;; (let [ks (map (partial str "foo") (range 500))