CLJS-2230: Double checked arrays

Root cause were macros that called out into the analyzer to determine
if further optimization was possible. These analysis calls are now
done with c.a/no-warn.

Added test case.

Author: swannodette

src/main/clojure/cljs/core.cljc

@@ -842,7 +842,7 @@
   ([x & next]
    (core/let [forms (concat [x] next)]
      (if (every? #(simple-test-expr? &env %)
-           (map #(cljs.analyzer/analyze &env %) forms))
+           (map #(cljs.analyzer/no-warn (cljs.analyzer/analyze &env %)) forms))
        (core/let [and-str (core/->> (repeat (count forms) "(~{})")
                             (interpose " && ")
                             (apply core/str))]
@@ -860,7 +860,7 @@
   ([x & next]
    (core/let [forms (concat [x] next)]
      (if (every? #(simple-test-expr? &env %)
-           (map #(cljs.analyzer/analyze &env %) forms))
+           (map #(cljs.analyzer/no-warn (cljs.analyzer/analyze &env %)) forms))
        (core/let [or-str (core/->> (repeat (count forms) "(~{})")
                            (interpose " || ")
                            (apply core/str))]
@@ -2477,7 +2477,7 @@
   ([]
    '(.-EMPTY cljs.core/List))
   ([x & xs]
-   (if (= :constant (:op (cljs.analyzer/analyze &env x)))
+   (if (= :constant (:op (cljs.analyzer/no-warn (cljs.analyzer/analyze &env x))))
      `(-conj (list ~@xs) ~x)
      `(let [x# ~x]
         (-conj (list ~@xs) x#)))))
@@ -2498,7 +2498,7 @@
   ([& kvs]
    (core/let [keys (map first (partition 2 kvs))]
      (if (core/and (every? #(= (:op %) :constant)
-                     (map #(cljs.analyzer/analyze &env %) keys))
+                     (map #(cljs.analyzer/no-warn (cljs.analyzer/analyze &env %)) keys))
            (= (count (into #{} keys)) (count keys)))
        `(cljs.core/PersistentArrayMap. nil ~(clojure.core// (count kvs) 2) (array ~@kvs) nil)
        `(.createAsIfByAssoc cljs.core/PersistentArrayMap (array ~@kvs))))))
@@ -2518,7 +2518,7 @@
   ([& xs]
     (if (core/and (core/<= (count xs) 8)
                   (every? #(= (:op %) :constant)
-                    (map #(cljs.analyzer/analyze &env %) xs))
+                    (map #(cljs.analyzer/no-warn (cljs.analyzer/analyze &env %)) xs))
                   (= (count (into #{} xs)) (count xs)))
       `(cljs.core/PersistentHashSet. nil
          (cljs.core/PersistentArrayMap. nil ~(count xs) (array ~@(interleave xs (repeat nil))) nil)

src/test/clojure/cljs/analyzer_tests.clj

@@ -745,39 +745,47 @@
 
 (deftest test-cljs-2148
   (binding [ana/*checked-arrays* :warn]
-    (let [ws   (atom [])]
+    (let [ws (atom [])]
       (try
         (a/with-warning-handlers [(collecting-warning-handler ws)]
           (e/with-compiler-env test-cenv
             (a/analyze (a/empty-env)
               '(aget (js-obj) "a"))))
         (catch Exception _))
       (is (= ["cljs.core/aget, arguments must be an array followed by numeric indices, got [object string] instead (consider goog.object/get for object access)"] @ws)))
-    (let [ws   (atom [])]
+    (let [ws (atom [])]
       (try
         (a/with-warning-handlers [(collecting-warning-handler ws)]
           (e/with-compiler-env test-cenv
             (a/analyze (a/empty-env)
               '(aget (js-obj) "foo" "bar"))))
         (catch Exception _))
       (is (= ["cljs.core/aget, arguments must be an array followed by numeric indices, got [object string string] instead (consider goog.object/getValueByKeys for object access)"] @ws)))
-    (let [ws   (atom [])]
+    (let [ws (atom [])]
       (try
         (a/with-warning-handlers [(collecting-warning-handler ws)]
           (e/with-compiler-env test-cenv
             (a/analyze (a/empty-env)
               '(aset (js-obj) "a" 2))))
         (catch Exception _))
       (is (= ["cljs.core/aset, arguments must be an array, followed by numeric indices, followed by a value, got [object string number] instead (consider goog.object/set for object access)"] @ws)))
-    (let [ws   (atom [])]
+    (let [ws (atom [])]
       (try
         (a/with-warning-handlers [(collecting-warning-handler ws)]
           (e/with-compiler-env test-cenv
             (a/analyze (a/empty-env)
               '(let [^objects arr (into-array [1 2 3])]
                  (aget arr 0)))))
         (catch Exception _))
-      (is (empty? @ws)))))
+      (is (empty? @ws)))
+    (let [ws (atom [])]
+      (try
+        (a/with-warning-handlers [(collecting-warning-handler ws)]
+          (e/with-compiler-env test-cenv
+            (a/analyze (a/empty-env)
+              '(and true (or (aget (js-obj "foo" 1) "foo") 2)))))
+        (catch Exception _))
+      (is (= 1 (count @ws))))))
 
 (deftest test-cljs-2037
   (let [test-env (assoc-in (a/empty-env) [:ns :name] 'cljs.user)]