Skip to content

Commit 3706313

Browse files
author
dnolen
committed
add test for CLJS-2392
1 parent b2d9e6b commit 3706313

1 file changed

Lines changed: 8 additions & 25 deletions

File tree

src/test/clojure/cljs/analyzer_tests.clj

Lines changed: 8 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -1040,32 +1040,15 @@
10401040
(is (string/includes? res "Thing.prototype.componentDidUpdate;"))
10411041
(is (zero? (count @ws)))))
10421042

1043-
(comment
1044-
1045-
;; this includes compiled - don't want that
1046-
(deftest test-cljs-2392-broken-inferred-externs
1047-
(let [ws (atom [])
1048-
res (infer-test-helper
1049-
{:forms '[(ns cjls-1918.core
1050-
(:require [cljs.nodejscli]))]
1051-
:warnings ws
1052-
:with-core? true})]
1053-
(println res)
1054-
(is (zero? (count @ws)))))
1055-
1056-
(let [ws (atom [])
1043+
(deftest test-cljs-2392-broken-inferred-externs
1044+
(let [ws (atom [])
10571045
res (infer-test-helper
10581046
{:forms '[(ns cjls-1918.core
1059-
(:require [cljs.nodejscli]))]
1047+
(:require [cljs.nodejs]
1048+
[cljs.nodejscli]))]
10601049
:warnings ws
10611050
:with-core? true
1062-
:opts {:target :nodejs}
1063-
})]
1064-
(println res))
1065-
1066-
(-> @(env/default-compiler-env
1067-
(closure/add-externs-sources {:infer-externs true}))
1068-
(get-in [::a/externs])
1069-
keys sort)
1070-
1071-
)
1051+
:opts {:target :nodejs}})]
1052+
(not (string/includes? res "COMPILED"))
1053+
(not (string/includes? res "goog"))
1054+
(is (zero? (count @ws)))))

0 commit comments

Comments
 (0)