CLJS-2251: Follow-up fix to CLJS-2249 and related commit

Author: anmonteiro

src/main/clojure/cljs/build/api.clj

@@ -193,8 +193,7 @@
      (if-not (nil? env/*compiler*)
        env/*compiler*
        (env/default-compiler-env
-         (closure/add-externs-sources
-           (closure/add-implicit-options opts))))))
+         (closure/add-externs-sources opts)))))
   ([source opts compiler-env]
    (doseq [[unknown-opt suggested-opt] (util/unknown-opts (set (keys opts)) closure/known-opts)]
      (when suggested-opt

src/main/clojure/cljs/closure.clj

@@ -2459,6 +2459,9 @@
            #(-> %
              (update-in [:options] merge all-opts)
              (assoc :target (:target opts))
+             ;; Save the current js-dependency index once we have computed all-opts
+             ;; or the analyzer won't be able to find upstream dependencies - Antonio
+             (assoc :js-dependency-index (deps/js-dependency-index all-opts))
              ;; Save list of sources for cljs.analyzer/locate-src - Juho Teperi
              (assoc :sources sources)))
          (binding [comp/*recompiled* (when-not (false? (:recompile-dependents opts))

src/test/clojure/cljs/build_api_tests.clj

@@ -16,7 +16,8 @@
             [cljs.env :as env]
             [cljs.analyzer :as ana]
             [cljs.test-util :as test]
-            [cljs.build.api :as build]))
+            [cljs.build.api :as build]
+            [cljs.closure :as closure]))
 
 (deftest test-target-file-for-cljs-ns
   (is (= (.getPath (build/target-file-for-cljs-ns 'example.core-lib nil))
@@ -409,4 +410,7 @@
               :target :nodejs}]
     (test/delete-out-files out)
     (build/build (build/inputs (io/file root "foreign_libs_cljs_2249")) opts)
+    (is (.exists (io/file out "calculator_global.js")))
+    (test/delete-out-files out)
+    (closure/build (build/inputs (io/file root "foreign_libs_cljs_2249")) opts)
     (is (.exists (io/file out "calculator_global.js")))))