From 80f4402277033ac65674e2f9831e66271a5fe6e5 Mon Sep 17 00:00:00 2001 From: tupe12334 Date: Mon, 19 Oct 2026 16:25:16 +0300 Subject: [PATCH] fix(version): stop reporting false version mismatch The CLI and the daemon ship with independent version numbers, so comparing them reported 'Version mismatch' on every healthy setup. Status now reports only whether the daemon is reachable: 'Running' or 'Not running'. Both versions are still printed. The JSON keys are unchanged; only the status values changed. Co-Authored-By: Claude Haiku 5.5 --- src/commands/version.spec.ts | 11 +++++------ src/commands/version.ts | 3 +-- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/src/commands/version.spec.ts b/src/commands/version.spec.ts index 92718c0..8a01569 100644 --- a/src/commands/version.spec.ts +++ b/src/commands/version.spec.ts @@ -52,10 +52,10 @@ describe('Version command', () => { expect(mockDaemonGetDaemonInfo).toHaveBeenCalledWith({}) expect(cmd.logs.some(log => log.includes('CLI: 0.4.0'))).toBe(true) expect(cmd.logs.some(log => log.includes('Daemon: 0.4.0'))).toBe(true) - expect(cmd.logs.some(log => log.includes('Status: Up to date'))).toBe(true) + expect(cmd.logs.some(log => log.includes('Status: Running'))).toBe(true) }) - it('should show version mismatch when versions differ', async () => { + it('should not report a mismatch when daemon version differs from CLI', async () => { const { default: Command } = await import('./version.js') mockDaemonGetDaemonInfo.mockResolvedValue({ version: '0.3.0', @@ -70,9 +70,8 @@ describe('Version command', () => { expect(cmd.logs.some(log => log.includes('CLI: 0.4.0'))).toBe(true) expect(cmd.logs.some(log => log.includes('Daemon: 0.3.0'))).toBe(true) - expect(cmd.logs.some(log => log.includes('Status: Version mismatch'))).toBe( - true - ) + expect(cmd.logs.some(log => log.includes('Status: Running'))).toBe(true) + expect(cmd.logs.some(log => log.includes('mismatch'))).toBe(false) }) it('should handle daemon not running', async () => { @@ -109,7 +108,7 @@ describe('Version command', () => { expect(parsed).toEqual({ cli: '0.4.0', daemon: '0.4.0', - status: 'Up to date', + status: 'Running', }) }) diff --git a/src/commands/version.ts b/src/commands/version.ts index d14fff1..27b4bd2 100644 --- a/src/commands/version.ts +++ b/src/commands/version.ts @@ -32,8 +32,7 @@ export default class Version extends Command { try { const daemonInfo = await daemonGetDaemonInfo({}) daemonVersion = daemonInfo.version - daemonStatus = - daemonVersion === cliVersion ? 'Up to date' : 'Version mismatch' + daemonStatus = 'Running' } catch { daemonStatus = 'Not running' }