fix: jaeger trace_id conversion only uses 64 bits (#236)

Author: tcolgate

opencensus/trace/exporters/jaeger_exporter.py

@@ -216,8 +216,8 @@ def translate_to_jaeger(self, span_datas):
             parent_span_id = span.parent_span_id
 
             jaeger_span = jaeger.Span(
-                traceIdHigh=_convert_hex_str_to_int(trace_id[0:8]),
-                traceIdLow=_convert_hex_str_to_int(trace_id[8:16]),
+                traceIdHigh=_convert_hex_str_to_int(trace_id[0:16]),
+                traceIdLow=_convert_hex_str_to_int(trace_id[16:32]),
                 spanId=_convert_hex_str_to_int(span_id),
                 operationName=span.name,
                 startTime=int(round(start_microsec)),
@@ -242,8 +242,8 @@ def _extract_refs_from_span(span):
         trace_id = link.trace_id
         refs.append(jaeger.SpanRef(
             refType=_convert_reftype_to_jaeger_reftype(link.type),
-            traceIdHigh=_convert_hex_str_to_int(trace_id[0:8]),
-            traceIdLow=_convert_hex_str_to_int(trace_id[8:16]),
+            traceIdHigh=_convert_hex_str_to_int(trace_id[0:16]),
+            traceIdLow=_convert_hex_str_to_int(trace_id[16:32]),
             spanId=_convert_hex_str_to_int(link.span_id)))
     return refs
 

tests/unit/trace/exporters/test_jaeger_exporter.py

@@ -172,7 +172,9 @@ def test_emit_succeeded(self, translate_mock, collector_mock, agent_mock):
 
     def test_translate_to_jaeger(self):
         self.maxDiff = None
-        trace_id = '6e0c63257de34c92bf9efcd03927272e'
+        trace_id_high = '6e0c63257de34c92'
+        trace_id_low = 'bf9efcd03927272e'
+        trace_id= trace_id_high + trace_id_low
         span_id = '6e0c63257de34c92'
         parent_span_id = '1111111111111111'
 
@@ -264,8 +266,8 @@ def test_translate_to_jaeger(self):
         spans = exporter.translate_to_jaeger(span_datas)
         expected_spans = [
             jaeger.Span(
-                traceIdHigh=1846305573,
-                traceIdLow=2112048274,
+                traceIdHigh=7929822056569588882,
+                traceIdLow=-4638992594902767826,
                 spanId=7929822056569588882,
                 parentSpanId=1229782938247303441,
                 operationName='test1',
@@ -294,18 +296,18 @@ def test_translate_to_jaeger(self):
                 references=[
                     jaeger.SpanRef(
                         refType=jaeger.SpanRefType.CHILD_OF,
-                        traceIdHigh=1846305573,
-                        traceIdLow=2112048274,
+                        traceIdHigh=7929822056569588882,
+                        traceIdLow=-4638992594902767826,
                         spanId=7929822056569588882),
                     jaeger.SpanRef(
                         refType=jaeger.SpanRefType.FOLLOWS_FROM,
-                        traceIdHigh=1846305573,
-                        traceIdLow=2112048274,
+                        traceIdHigh=7929822056569588882,
+                        traceIdLow=-4638992594902767826,
                         spanId=7929822056569588882),
                     jaeger.SpanRef(
                         refType=None,
-                        traceIdHigh=1846305573,
-                        traceIdLow=2112048274,
+                        traceIdHigh=7929822056569588882,
+                        traceIdLow=-4638992594902767826,
                         spanId=7929822056569588882)
                 ],
                 logs=[
@@ -328,8 +330,8 @@ def test_translate_to_jaeger(self):
                 ]),
             jaeger.Span(
                 operationName="test2",
-                traceIdHigh=1846305573,
-                traceIdLow=2112048274,
+                traceIdHigh=7929822056569588882,
+                traceIdLow=-4638992594902767826,
                 spanId=7929822056569588882,
                 parentSpanId=0,
                 startTime=1502820146071158,