Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Commit df8f064

Browse files
authored
Use utcnow in metrics conversions (#569)
1 parent 8128212 commit df8f064

5 files changed

Lines changed: 6 additions & 6 deletions

File tree

contrib/opencensus-ext-ocagent/opencensus/ext/ocagent/trace_exporter/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def __init__(
8484
else host_name,
8585
pid=os.getpid(),
8686
start_timestamp=utils.proto_ts_from_datetime(
87-
datetime.datetime.now())
87+
datetime.datetime.utcnow())
8888
),
8989
library_info=common_pb2.LibraryInfo(
9090
language=common_pb2.LibraryInfo.Language.Value('PYTHON'),

opencensus/metrics/export/gauge.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -481,7 +481,7 @@ def get_metrics(self):
481481
:rtype: set(:class:`opencensus.metrics.export.metric.Metric`)
482482
:return: A set of `Metric`s, one for each registered gauge.
483483
"""
484-
now = datetime.now()
484+
now = datetime.utcnow()
485485
metrics = set()
486486
for gauge in self.gauges.values():
487487
metrics.add(gauge.get_metric(now))

opencensus/stats/stats.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,4 +37,4 @@ def get_metrics(self):
3737
:rtype: Iterator[:class: `opencensus.metrics.export.metric.Metric`]
3838
"""
3939
return self.view_manager.measure_to_view_map.get_metrics(
40-
datetime.now())
40+
datetime.utcnow())

tests/unit/trace/test_blank_span.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def test_do_not_crash(self):
6464
with self.assertRaises(TypeError):
6565
span.add_time_event(time_event)
6666

67-
time_event = TimeEvent(datetime.datetime.now())
67+
time_event = TimeEvent(datetime.datetime.utcnow())
6868
span.add_time_event(time_event)
6969

7070
span_iter_list = list(iter(span))

tests/unit/trace/test_span.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ def test_add_time_event(self):
145145
with self.assertRaises(TypeError):
146146
span.add_time_event(time_event)
147147

148-
time_event = TimeEvent(datetime.datetime.now())
148+
time_event = TimeEvent(datetime.datetime.utcnow())
149149
span.add_time_event(time_event)
150150

151151
self.assertEqual(len(span.time_events), 1)
@@ -357,7 +357,7 @@ def test_format_span_json_with_parent_span(self, time_event_mock,
357357
span.start_time = start_time
358358
span.end_time = end_time
359359
span._child_spans = []
360-
span.time_events = [TimeEvent(datetime.datetime.now())]
360+
span.time_events = [TimeEvent(datetime.datetime.utcnow())]
361361
span.stack_trace = StackTrace()
362362
span.status = Status(code='200', message='test')
363363
span.links = [Link(trace_id, span_id)]

0 commit comments

Comments
 (0)