Add details about aggregation pipelines & avoid get(default) parameter (#644)

Add pipeline attribute to Pymongo integration
Remove use of get(default=) in Pymongo integration

Author: angelini

contrib/opencensus-ext-pymongo/CHANGELOG.md

@@ -2,6 +2,9 @@
 
 ## Unreleased
 
+- Include aggregation pipeline in trace attributes
+- Fix support command dictionaries
+
 ## 0.1.2
 Released 2019-04-24
 

contrib/opencensus-ext-pymongo/opencensus/ext/pymongo/trace.py

@@ -24,7 +24,7 @@
 
 MODULE_NAME = 'pymongo'
 
-COMMAND_ATTRIBUTES = ['filter', 'sort', 'skip', 'limit']
+COMMAND_ATTRIBUTES = ['filter', 'sort', 'skip', 'limit', 'pipeline']
 
 
 def trace_integration(tracer=None):
@@ -51,7 +51,7 @@ def started(self, event):
         span.span_kind = span_module.SpanKind.CLIENT
 
         for attr in COMMAND_ATTRIBUTES:
-            _attr = event.command.get(attr, default=None)
+            _attr = event.command.get(attr)
             if _attr is not None:
                 self.tracer.add_attribute_to_current_span(attr, str(_attr))
 

contrib/opencensus-ext-pymongo/tests/test_pymongo_trace.py

@@ -44,13 +44,15 @@ def test_started(self):
             'filter': 'filter',
             'sort': 'sort',
             'limit': 'limit',
+            'pipeline': 'pipeline',
             'command_name': 'find'
         }
 
         expected_attrs = {
             'filter': 'filter',
             'sort': 'sort',
             'limit': 'limit',
+            'pipeline': 'pipeline',
             'request_id': 'request_id',
             'connection_id': 'connection_id'
         }
@@ -101,9 +103,8 @@ class MockCommand(object):
     def __init__(self, command_attrs):
         self.command_attrs = command_attrs
 
-    def get(self, key, default=None):
-        return self.command_attrs[key] \
-            if key in self.command_attrs else default
+    def get(self, key):
+        return self.command_attrs.get(key)
 
 
 class MockEvent(object):