Stats: Fix hello world example and measure_to_view_map. (#233)

Author: songy23

examples/stats/helloworld/main.py

@@ -22,11 +22,12 @@
 from opencensus.tags import tag_key as tag_key_module
 from opencensus.tags import tag_map as tag_map_module
 from opencensus.tags import tag_value as tag_value_module
+from pprint import pprint
 
 MiB = 1 << 20
 FRONTEND_KEY = tag_key_module.TagKey("my.org/keys/frontend")
 VIDEO_SIZE_MEASURE = measure_module.MeasureInt(
-    "my.org/measure/video_size", "size of processed videos", "By")
+    "my.org/measures/video_size", "size of processed videos", "By")
 VIDEO_SIZE_VIEW_NAME = "my.org/views/video_size"
 VIDEO_SIZE_DISTRIBUTION = aggregation_module.DistributionAggregation(
     [0.0, 16.0 * MiB, 256.0 * MiB])
@@ -51,14 +52,15 @@ def main():
     # Process video.
     # Record the processed video size.
     tag_value = tag_value_module.TagValue("mobile-ios9.3.5")
-    tag_map = tag_map_module.TagMap().insert(FRONTEND_KEY, tag_value)
+    tag_map = tag_map_module.TagMap()
+    tag_map.insert(FRONTEND_KEY, tag_value)
     measure_map = stats_recorder.new_measurement_map()
     measure_map.measure_int_put(VIDEO_SIZE_MEASURE, 25 * MiB)
     measure_map.record(tag_map)
 
     # Get aggregated stats and print it to console.
     view_data = view_manager.get_view(VIDEO_SIZE_VIEW_NAME)
-    print(view_data)  # TODO: print more meaningful info for view_data
+    pprint(vars(view_data))   # TODO: print more meaningful info for view_data
 
 
 if __name__ == '__main__':

opencensus/stats/measure_to_view_map.py

@@ -23,9 +23,10 @@ class MeasureToViewMap(object):
     specific View Datas
 
     """
+
     def __init__(self):
         # stores the one-to-many mapping from Measures to View Datas
-        self._map = defaultdict(list)
+        self._measure_to_view_data_list_map = defaultdict(list)
         # stores a map from the registered View names to the Views
         self._registered_views = {}
         # stores a map from the registered Measure names to the Measures
@@ -44,11 +45,14 @@ def get_view(self, view_name, timestamp):
         if view is None:
             return None
 
-        views = self._map.get(view.measure.name)
-        if views is not None:
-            for view_data in views:
+        view_data_list = self._measure_to_view_data_list_map.get(
+            view.measure.name)
+        if view_data_list is not None:
+            for view_data in view_data_list:
                 if view_data.view.name == view_name:
-                    return copy.deepcopy(view_data)
+                    view_data_copy = copy.deepcopy(view_data)
+                    view_data_copy.end()
+                    return view_data_copy
 
     def filter_exported_views(self, all_views):
         """returns the subset of the given view that should be exported"""
@@ -72,24 +76,22 @@ def register_view(self, view, timestamp):
         if registered_measure is not None and registered_measure != measure:
             logging.warning(
                 "A different measure with the same name is already registered")
-        self._registered_views[measure.name] = view
+        self._registered_views[view.name] = view
         if registered_measure is None:
             self._registered_measures[measure.name] = measure
-        self._map[view.measure.name].append(ViewData(view=view,
-                                                     start_time=timestamp,
-                                                     end_time=timestamp))
+        self._measure_to_view_data_list_map[view.measure.name].append(
+            ViewData(view=view, start_time=timestamp, end_time=timestamp))
 
     def record(self, tags, measurement_map, timestamp):
         """records stats with a set of tags"""
         for measure, value in measurement_map.items():
             if measure != self._registered_measures.get(measure.name):
                 return
             view_datas = []
-            for key, value in self._map.items():
-                if key == measure.name:
-                    # note that self._map is a multi-map.
-                    view_datas.extend(self._map[key])
+            for measure_name, view_data_list \
+                    in self._measure_to_view_data_list_map.items():
+                if measure_name == measure.name:
+                    view_datas.extend(view_data_list)
             for view_data in view_datas:
-                view_data.record(context=tags,
-                                 value=view_data.view.measure,
-                                 timestamp=timestamp)
+                view_data.record(
+                    context=tags, value=value, timestamp=timestamp)