Clean up (#654)

Updated doc to use noxfile.py.
Used logging.warning instead of warn.

Author: reyang

CONTRIBUTING.md

@@ -57,5 +57,5 @@ Open a pull request against the main opencensus-python repo.
 If you want to contribute new [extensions](README.rst#extensions), you need some extra steps:
 
 * Prepare the extension code, put it under the [contrib](./contrib/) folder.
-* Update [nox.py](./nox.py) to include your new extension for testing purpose.
+* Update [noxfile.py](./noxfile.py) to include your new extension for testing purpose.
 * Update [README](./README.rst#extensions) to include your extension.

contrib/opencensus-ext-jaeger/opencensus/ext/jaeger/trace_exporter/__init__.py

@@ -314,8 +314,7 @@ def _convert_attribute_to_tag(key, attr):
             key=key,
             vDouble=attr,
             vType=jaeger.TagType.DOUBLE)
-    logging.warn('Could not serialize attribute \
-            {}:{} to tag'.format(key, attr))
+    logging.warning('Could not serialize attribute %s:%r to tag', key, attr)
     return None
 
 
@@ -450,8 +449,10 @@ def emit(self, batch):
             self.client.emitBatch(batch)
             buff = self.buffer.getvalue()
             if len(buff) > self.max_packet_size:
-                logging.warn('Data exceeds the max UDP packet size; size {},\
-                        max {}'.format(len(buff), self.max_packet_size))
+                logging.warning(
+                    'Data exceeds the max UDP packet size; size %r, max %r',
+                    len(buff),
+                    self.max_packet_size)
             else:
                 udp_socket = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
                 udp_socket.sendto(buff, self.address)

contrib/opencensus-ext-jaeger/tests/test_jaeger_exporter.py

@@ -104,14 +104,14 @@ def test_agent_emit_succeeded(self, mock_logging):
 
         agent_client.emit({})
         self.assertTrue(agent_client.client.emit_called)
-        self.assertFalse(mock_logging.warn.called)
+        self.assertFalse(mock_logging.warning.called)
 
     @mock.patch('opencensus.ext.jaeger.trace_exporter.logging')
     def test_packet_capacity_exceeded(self, mock_logging):
         agent_client = trace_exporter.AgentClientUDP(
             client=MockClient, max_packet_size=-1)
         agent_client.emit({})
-        self.assertTrue(mock_logging.warn.called)
+        self.assertTrue(mock_logging.warning.called)
 
     @mock.patch('opencensus.ext.jaeger.trace_exporter.logging')
     def test_collector_emit_failed(self, mock_logging):

contrib/opencensus-ext-zipkin/opencensus/ext/zipkin/trace_exporter/__init__.py

@@ -193,7 +193,7 @@ def _extract_tags_from_span(attr):
             res, _ = check_str_length(str_to_check=attribute_value)
             value = res
         else:
-            logging.warn('Could not serialize tag {}'.format(attribute_key))
+            logging.warning('Could not serialize tag %s', attribute_key)
             continue
         tags[attribute_key] = value
     return tags

opencensus/trace/propagation/google_cloud_format.py

@@ -50,8 +50,8 @@ def from_header(self, header):
             match = re.search(_TRACE_CONTEXT_HEADER_RE, header)
         except TypeError:
             logging.warning(
-                'Header should be str, got {}. Cannot parse the header.'
-                .format(header.__class__.__name__))
+                'Header should be str, got %s. Cannot parse the header.',
+                header.__class__.__name__)
             raise
 
         if match:
@@ -70,8 +70,8 @@ def from_header(self, header):
             return span_context
         else:
             logging.warning(
-                'Cannot parse the header {}, generate a new context instead.'
-                .format(header))
+                'Cannot parse the header %s, generate a new context instead.',
+                header)
             return SpanContext()
 
     def from_headers(self, headers):

opencensus/trace/span_context.py

@@ -102,7 +102,7 @@ def _check_span_id(self, span_id):
 
         if span_id is INVALID_SPAN_ID:
             logging.warning(
-                'Span_id {} is invalid (cannot be all zero)'.format(span_id))
+                'Span_id %s is invalid (cannot be all zero)', span_id)
             self.from_header = False
             return None
 
@@ -112,8 +112,8 @@ def _check_span_id(self, span_id):
             return span_id
         else:
             logging.warning(
-                'Span_id {} does not the match the '
-                'required format'.format(span_id))
+                'Span_id %s does not the match the '
+                'required format', span_id)
             self.from_header = False
             return None
 
@@ -132,8 +132,8 @@ def _check_trace_id(self, trace_id):
 
         if trace_id is _INVALID_TRACE_ID:
             logging.warning(
-                'Trace_id {} is invalid (cannot be all zero), '
-                'generating a new one.'.format(trace_id))
+                'Trace_id %s is invalid (cannot be all zero), '
+                'generating a new one.', trace_id)
             self.from_header = False
             return generate_trace_id()
 
@@ -143,8 +143,8 @@ def _check_trace_id(self, trace_id):
             return trace_id
         else:
             logging.warning(
-                'Trace_id {} does not the match the required format,'
-                'generating a new one instead.'.format(trace_id))
+                'Trace_id %s does not the match the required format,'
+                'generating a new one instead.', trace_id)
             self.from_header = False
             return generate_trace_id()
 

opencensus/trace/trace_options.py

@@ -39,7 +39,7 @@ def check_trace_options(self, trace_options_byte):
         trace_options_int = int(trace_options_byte)
 
         if trace_options_int < 0 or trace_options_int > 255:
-            logging.warn("Trace options invalid, should be 1 byte.")
+            logging.warning("Trace options invalid, should be 1 byte.")
             trace_options_byte = DEFAULT
 
         return trace_options_byte